Skip to contentSkip to conversation

net: mvneta: fix comment about phylink_speed_down

PATCH Applied Jisheng Zhang 3 participants 3 messages Jul 29, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 net: mvneta: fix comment about phylink_speed_down

mvneta has switched to phylink, so the comment should look like "We may have called phylink_speed_down before".

---
Since v1:
- drop patch2 which tries to avoid link flapping when changing mtu I need more time on the change mtu refactoring.

 drivers/net/ethernet/marvell/mvneta.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/marvell/mvneta.c +1 -1
index 2c9277e73cef..c9b6b0f85bb0 100644
@@ -3637,7 +3637,7 @@ static void mvneta_start_dev(struct mvneta_port *pp)
 
 	phylink_start(pp->phylink);
 
-	/* We may have called phy_speed_down before */
+	/* We may have called phylink_speed_down before */
 	phylink_speed_up(pp->phylink);
 
 	netif_tx_start_all_queues(pp->dev);
Signature · 1 line
2.28.0.rc0
Reviewed-by Russell King on v2 1/1
#1 lore raw
Quoted 4 lines · Jisheng Zhang

mvneta has switched to phylink, so the comment should look like "We may have called phylink_speed_down before".

Quoted 25 lines

---
Since v1:
- drop patch2 which tries to avoid link flapping when changing mtu I need more time on the change mtu refactoring.

 drivers/net/ethernet/marvell/mvneta.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/marvell/mvneta.c +1 -1
index 2c9277e73cef..c9b6b0f85bb0 100644
@@ -3637,7 +3637,7 @@ static void mvneta_start_dev(struct mvneta_port *pp)
 
 	phylink_start(pp->phylink);
 
-	/* We may have called phy_speed_down before */
+	/* We may have called phylink_speed_down before */
 	phylink_speed_up(pp->phylink);
 
 	netif_tx_start_all_queues(pp->dev);
Signature · 1 line
2.28.0.rc0
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
maintainer Applied
#2 lore raw
In reply to Jisheng Zhang

From: Jisheng Zhang <[email protected]>
Date: Wed, 29 Jul 2020 17:49:09 +0800

Quoted 8 lines

mvneta has switched to phylink, so the comment should look like "We may have called phylink_speed_down before".

---
Since v1:
- drop patch2 which tries to avoid link flapping when changing mtu I need more time on the change mtu refactoring.

Applied, thank you.