Skip to contentSkip to conversation

ARM: mstar: Fix compatible string for pmsleep

PATCH In review Daniel Palmer 3 participants 7 messages Jul 29, 2020 – Aug 1, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover ARM: mstar: Fix compatible string for pmsleep

This fixes up the compatible string for the pmsleep register region based on Arnd and Rob's feedback:

- Add "mstar,msc313-pmsleep" to mfd/syscon.yaml
- Remove the unneeded binding description for "mstar,pmsleep"
- Use the new string in the MStar v7 base dtsi

Daniel Palmer (3):
dt-bindings: mfd: syscon: add compatible string for
mstar,msc313-pmsleep
dt-bindings: arm: mstar: remove the binding description for
mstar,pmsleep
ARM: mstar: Correct the compatible string for pmsleep

 .../bindings/arm/mstar/mstar,pmsleep.yaml     | 43 -------------------
 .../devicetree/bindings/mfd/syscon.yaml       |  1 +
 arch/arm/boot/dts/mstar-v7.dtsi               |  2 +-
 3 files changed, 2 insertions(+), 44 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/mstar/mstar,pmsleep.yaml
Signature · 1 line
2.27.0
#1 lore raw

PATCH 1/3 dt-bindings: mfd: syscon: add compatible string for mstar,msc313-pmsleep

Add a compatible string for the pmsleep register region in the MStar MSC313 SoC.

---
 Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/mfd/syscon.yaml +1 -0
index f3fba860d3cc..614e58bb5d7d 100644
@@ -39,6 +39,7 @@ properties:
               - allwinner,sun8i-v3s-system-controller
               - allwinner,sun50i-a64-system-controller
               - microchip,sparx5-cpu-syscon
+              - mstar,msc313-pmsleep
 
           - const: syscon
 
Signature · 1 line
2.27.0
#2 lore raw

PATCH 2/3 dt-bindings: arm: mstar: remove the binding description for mstar,pmsleep

In reply to Daniel Palmer

Remove the unneeded binding description.
Compatible string is in mfd/syscon.yaml now.

---
 .../bindings/arm/mstar/mstar,pmsleep.yaml     | 43 -------------------
 1 file changed, 43 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/mstar/mstar,pmsleep.yaml
Documentation/devicetree/bindings/arm/mstar/mstar,pmsleep.yaml deleted +0 -43
deleted file mode 100644
index 0b45e7012ceb..000000000000
@@ -1,43 +0,0 @@
-# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
-# Copyright 2020 thingy.jp.
-%YAML 1.2
----
-$id: "http://devicetree.org/schemas/arm/mstar/mstar,pmsleep.yaml#"
-$schema: "http://devicetree.org/meta-schemas/core.yaml#"
-
-title: MStar/SigmaStar Armv7 SoC pmsleep register region
-
-maintainers:
-  - Daniel Palmer <[email protected]>
-
-description: |
-  MStar/Sigmastar's Armv7 SoCs contain a region of registers that are
-  in the always on domain that the vendor code calls the "pmsleep" area.
-
-  This area contains registers and bits for a broad range of functionality
-  ranging from registers that control going into deep sleep to bits that
-  turn things like the internal temperature sensor on and off.
-
-properties:
-  compatible:
-    oneOf:
-      - items:
-         - enum:
-             - mstar,pmsleep
-         - const: syscon
-
-  reg:
-    maxItems: 1
-
-required:
-  - compatible
-  - reg
-
-additionalProperties: false
-
-examples:
-  - |
-    pmsleep: pmsleep@1c00 {
-        compatible = "mstar,pmsleep", "syscon";
-        reg = <0x1c00 0x100>;
-    };
Signature · 1 line
2.27.0
#3 lore raw

Re: [PATCH 2/3] dt-bindings: arm: mstar: remove the binding description for mstar,pmsleep

Quoted 5 lines · Daniel Palmer

Remove the unneeded binding description.
Compatible string is in mfd/syscon.yaml now.

This patch for some reason did not apply, so I ended up removing the file manually and using your changelog.

Arnd

#4 lore raw

Re: [PATCH 2/3] dt-bindings: arm: mstar: remove the binding description for mstar,pmsleep

Quoted 4 lines · Arnd Bergmann

This patch for some reason did not apply, so I ended up removing the file manually and using your changelog.

Arnd

Thanks Arnd.

#5 lore raw

PATCH 3/3 ARM: mstar: Correct the compatible string for pmsleep

In reply to Daniel Palmer

The compatible string for the pmsleep region has changed. Update the MStar/Sigmastar v7 base dtsi with the new string.

---
 arch/arm/boot/dts/mstar-v7.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/mstar-v7.dtsi +1 -1
index c7458c67c4df..3b7b9b793736 100644
@@ -74,7 +74,7 @@ riu: bus@1f000000 {
 			ranges = <0x0 0x1f000000 0x00400000>;
 
 			pmsleep: syscon@1c00 {
-				compatible = "mstar,pmsleep", "syscon";
+				compatible = "mstar,msc313-pmsleep", "syscon";
 				reg = <0x1c00 0x100>;
 			};
 
Signature · 1 line
2.27.0
maintainer Reviewed-by on the v1 series
#6 lore raw
In reply to Daniel Palmer
Quoted 15 lines · Daniel Palmer

This fixes up the compatible string for the pmsleep register region based on Arnd and Rob's feedback:

- Add "mstar,msc313-pmsleep" to mfd/syscon.yaml
- Remove the unneeded binding description for "mstar,pmsleep"
- Use the new string in the MStar v7 base dtsi

Daniel Palmer (3):
dt-bindings: mfd: syscon: add compatible string for
mstar,msc313-pmsleep
dt-bindings: arm: mstar: remove the binding description for
mstar,pmsleep
ARM: mstar: Correct the compatible string for pmsleep

Quoted 5 lines
 .../bindings/arm/mstar/mstar,pmsleep.yaml     | 43 -------------------
 .../devicetree/bindings/mfd/syscon.yaml       |  1 +
 arch/arm/boot/dts/mstar-v7.dtsi               |  2 +-
 3 files changed, 2 insertions(+), 44 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/mstar/mstar,pmsleep.yaml

For the series:

Please get this into linux-next ASAP as mstar,pmsleep.yaml breaks 'make dt_binding_check' in linux-next.

Rob

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel