erofs: fold in used-once helper erofs_workgroup_unfreeze_final()
PATCH 1/1 erofs: fold in used-once helper erofs_workgroup_unfreeze_final()
It's expected that erofs_workgroup_unfreeze_final() won't be used in other places. Let's fold it to simplify the code.
Signed-off-by Gao Xiang <[email protected]>
--- fs/erofs/utils.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-)
fs/erofs/utils.c +3 -11
@@ -127,12 +127,6 @@ int erofs_workgroup_put(struct erofs_workgroup *grp)return count; } -static void erofs_workgroup_unfreeze_final (struct erofs_workgroup *grp) -{ -erofs_workgroup_unfreeze (grp,0 ); -__erofs_workgroup_free (grp); -} -static bool erofs_try_to_release_workgroup (struct erofs_sb_info *sbi,struct erofs_workgroup *grp) {
@@ -162,11 +156,9 @@ static bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,*/ DBG_BUGON (xa_erase (&sbi->managed_pslots, grp->index) != grp); -/* -* If managed cache is on, last refcount should indicate -* the related workstation. -*/ -erofs_workgroup_unfreeze_final (grp); +/* last refcount should be connected with its managed pslot. */ +erofs_workgroup_unfreeze (grp,0 ); +__erofs_workgroup_free (grp);return true; }
Signature · 1 line
2.18.1
Quoted 4 lines · Gao Xiang
It's expected that
erofs_workgroup_unfreeze_final()won't be used in other places. Let's fold it to simplify the code.Signed-off-by Gao Xiang <[email protected]>
Reviewed-by Chao Yu <[email protected]>
Thanks,
Quoted 7 lines · Chao Yu
Quoted 4 lines · Gao Xiang
It's expected that
erofs_workgroup_unfreeze_final()won't be used in other places. Let's fold it to simplify the code.Signed-off-by Gao Xiang <[email protected]>Reviewed-by Chao Yu <[email protected]>
Thanks for the review :)
Thanks,
Gao Xiang
Quoted 2 lines
Thanks,