nvmet-passthru: Reject commands with non-sgl flags set
Subsystems (2)
PATCH 1/1 nvmet-passthru: Reject commands with non-sgl flags set
Any command with a non-SGL flag set (like fuse flags) should be rejected.
Fixes c1fef73f793b ("nvmet: add passthru code to process commands")
Signed-off-by Logan Gunthorpe <[email protected]>
---
Note: this patch may be squashed with the patch noted in the fixes tag, currently in nvme-5.9.
drivers/nvme/target/passthru.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/nvme/target/passthru.c +8 -0
@@ -326,6 +326,10 @@ static u16 nvmet_setup_passthru_command(struct nvmet_req *req)u16 nvmet_parse_passthru_io_cmd (struct nvmet_req *req) { +/* Reject any commands with non-sgl flags set (ie. fused commands) */ +if (req->cmd->common.flags & ~NVME_CMD_SGL_ALL ) +return NVME_SC_INVALID_FIELD ; +switch (req->cmd->common.opcode) {case nvme_cmd_resv_register:case nvme_cmd_resv_report:
@@ -396,6 +400,10 @@ static u16 nvmet_passthru_get_set_features(struct nvmet_req *req)u16 nvmet_parse_passthru_admin_cmd (struct nvmet_req *req) { +/* Reject any commands with non-sgl flags set (ie. fused commands) */ +if (req->cmd->common.flags & ~NVME_CMD_SGL_ALL ) +return NVME_SC_INVALID_FIELD ; +/* * Passthru all vendor specific commands */
base-commit: b6cec06d19d90db5dbcc50034fb33983f6259b8b --
2.20.1
Reviewed-by Sagi Grimberg <[email protected]>
Quoted 5 lines · Logan Gunthorpe
Any command with a non-SGL flag set (like fuse flags) should be rejected.
Fixes c1fef73f793b ("nvmet: add passthru code to process commands")Signed-off-by Logan Gunthorpe<[email protected]>
Looks good.
Reviewed-by Chaitanya Kulkarni <[email protected]>