Skip to contentSkip to conversation

add brcm iproc gpio driver

PATCH New Rayagonda Kokatanur 2 participants 5 messages May 5, 2020 – Jul 29, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v6 cover add brcm iproc gpio driver

Add support for broadcom iproc gpio driver.

Changes from v5:
-Address review comments from Simon Glass,
Correct and add function comments,
Rename macro names.

Changes from v4:
-Address review comments from Simon Glass,
Check for function return value.

Changes from v3:
-Address review comments from Simon Glass,
Rearrange header file,
Add struct comment taking about members,
Use clrsetbits_le32(),
Add new line before return etc.

Changes from v2:
-remove ununsed variable "node" in iproc_get_gpio_pctrl_mapping()
func to fix compilation warning.

Changes from v1:
-Address review comments from Simon Glass,
Use dev_read_...() instead of fdtdec_...().

Rayagonda Kokatanur (2):
drivers: gpio: add broadcom iproc gpio driver support
gpio: do not include <asm/arch/gpio.h> on TARGET_BCMNS3

 arch/arm/include/asm/gpio.h |   2 +-
 drivers/gpio/Kconfig        |  11 ++
 drivers/gpio/Makefile       |   1 +
 drivers/gpio/iproc_gpio.c   | 290 ++++++++++++++++++++++++++++++++++++
 4 files changed, 303 insertions(+), 1 deletion(-)
 create mode 100644 drivers/gpio/iproc_gpio.c
Signature · 1 line
2.17.1
#1 lore raw

PATCH v6 1/2 drivers: gpio: add broadcom iproc gpio driver support

Add gpio driver support for Broadcom iproc-based socs.

---
Changes from v5:
-Address review comments from Simon Glass,
Correct and add function comments,
Rename macro names.

Changes from v4:
-Address review comments from Simon Glass,
Check for function return value.

Changes from v3:
-Address review comments from Simon Glass,
Rearrange header file,
Add struct comment taking about members,
Use clrsetbits_le32(),
Add new line before return etc.

Changes from v2:
-remove ununsed variable "node" in iproc_get_gpio_pctrl_mapping()
func to fix compilation warning.

Changes from v1:
-Address review comments from Simon Glass,
Use dev_read_...() instead of fdtdec_...().

 drivers/gpio/Kconfig      |  11 ++
 drivers/gpio/Makefile     |   1 +
 drivers/gpio/iproc_gpio.c | 290 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 302 insertions(+)
 create mode 100644 drivers/gpio/iproc_gpio.c
drivers/gpio/Kconfig +11 -0
index 2081520f42..57d2cd2e75 100644
@@ -135,6 +135,17 @@ config IMX_RGPIO2P
 	help
 	  This driver supports i.MX7ULP Rapid GPIO2P controller.
 
+config IPROC_GPIO
+	bool "Broadcom iProc GPIO driver(without pinconf)"
+	default n
+	help
+	  The Broadcom iProc based SoCs- Cygnus, NS2, NS3, NSP and Stingray,
+	  use the same GPIO Controller IP hence this driver could be used
+	  for all.
+
+	  The Broadcom iProc based SoCs have multiple GPIO controllers and only
+	  the always-ON GPIO controller (CRMU/AON) is supported by this driver.
+
 config HSDK_CREG_GPIO
 	bool "HSDK CREG GPIO griver"
 	depends on DM_GPIO
drivers/gpio/Makefile +1 -0
index 7638259007..5dc5849477 100644
@@ -19,6 +19,7 @@ obj-$(CONFIG_CORTINA_GPIO)      += cortina_gpio.o
 obj-$(CONFIG_INTEL_GPIO)	+= intel_gpio.o
 obj-$(CONFIG_INTEL_ICH6_GPIO)	+= intel_ich6_gpio.o
 obj-$(CONFIG_INTEL_BROADWELL_GPIO)	+= intel_broadwell_gpio.o
+obj-$(CONFIG_IPROC_GPIO)	+= iproc_gpio.o
 obj-$(CONFIG_KIRKWOOD_GPIO)	+= kw_gpio.o
 obj-$(CONFIG_KONA_GPIO)	+= kona_gpio.o
 obj-$(CONFIG_MARVELL_GPIO)	+= mvgpio.o
drivers/gpio/iproc_gpio.c new file +290 -0

290 lines not on this page · raw message

Signature · 1 line
2.17.1
#2 lore raw

PATCH v6 1/2 drivers: gpio: add broadcom iproc gpio driver support

Quoted 5 lines · Rayagonda Kokatanur

Add gpio driver support for Broadcom iproc-based socs.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200729/dddfc52d/attachment.sig>
#3 lore raw

PATCH v6 2/2 gpio: do not include <asm/arch/gpio.h> on TARGET_BCMNS3

In reply to Rayagonda Kokatanur

As no gpio.h is defined for this architecture, to avoid compilation failure, do not include <asm/arch/gpio.h> for arch bcmns3.

---
 arch/arm/include/asm/gpio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/include/asm/gpio.h +1 -1
index 333e407b66..c067eeb649 100644
@@ -6,7 +6,7 @@
 	!defined(CONFIG_ARCH_LS1088A) && !defined(CONFIG_ARCH_ASPEED) && \
 	!defined(CONFIG_ARCH_LS1012A) && !defined(CONFIG_ARCH_LS1043A) && \
 	!defined(CONFIG_ARCH_LS1046A) && !defined(CONFIG_ARCH_U8500) && \
-	!defined(CONFIG_CORTINA_PLATFORM)
+	!defined(CONFIG_CORTINA_PLATFORM) && !defined(CONFIG_TARGET_BCMNS3)
 #include <asm/arch/gpio.h>
 #endif
 #include <asm-generic/gpio.h>
Signature · 1 line
2.17.1
#4 lore raw

PATCH v6 2/2 gpio: do not include <asm/arch/gpio.h> on TARGET_BCMNS3

Quoted 6 lines · Rayagonda Kokatanur

As no gpio.h is defined for this architecture, to avoid compilation failure, do not include <asm/arch/gpio.h> for arch bcmns3.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200729/eee66f07/attachment.sig>