ASoC: wm8962: Do not access WM8962_GPIO_BASE
Subsystems (3)
PATCH RESEND 1/1 ASoC: wm8962: Do not access WM8962_GPIO_BASE
According to the WM8962 datasheet, there is no register at address 0x200.
WM8962_GPIO_BASE is just a base address for the GPIO registers and not a real register, so remove it from wm8962_readable_register().
Also, Register 515 (WM8962_GPIO_BASE + 3) does not exist, so skip its access.
This fixes the following errors:
wm8962 0-001a: ASoC: error at soc_component_read_no_lock on wm8962.0-001a: -16 wm8962 0-001a: ASoC: error at soc_component_read_no_lock on wm8962.0-001a: -16
Signed-off-by Fabio Estevam <[email protected]>
Acked-by Charles Keepax <[email protected]>
--- sound/soc/codecs/wm8962.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
sound/soc/codecs/wm8962.c +7 -2
@@ -956,7 +956,6 @@ static bool wm8962_readable_register(struct device *dev, unsigned int reg)case WM8962_EQ39 :case WM8962_EQ40 :case WM8962_EQ41 : -case WM8962_GPIO_BASE :case WM8962_GPIO_2 :case WM8962_GPIO_3 :case WM8962_GPIO_5 :
@@ -3437,7 +3436,13 @@ static int wm8962_probe(struct snd_soc_component *component)/* Save boards having to disable DMIC when not in use */ dmicclk = false; dmicdat = false; -for (i =0 ; i <WM8962_MAX_GPIO ; i++) { +for (i =1 ; i <WM8962_MAX_GPIO ; i++) { +/* +* Register 515 (WM8962_GPIO_BASE + 3) does not exist, +* so skip its access +*/ +if (i ==3 ) +continue ;switch (snd_soc_component_read (component,WM8962_GPIO_BASE + i) &WM8962_GP2_FN_MASK ) {case WM8962_GPIO_FN_DMICCLK :
Signature · 1 line
2.17.1