net/sched: act_pedit: Use flex_array_size() helper in memcpy()
Subsystems (3)
PATCH 1/1 net/sched: act_pedit: Use flex_array_size() helper in memcpy()
Make use of the flex_array_size() helper to calculate the size of a flexible array member within an enclosing structure.
This helper offers defense-in-depth against potential integer overflows, while at the same time makes it explicitly clear that we are dealing with a flexible array member.
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- net/sched/act_pedit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
net/sched/act_pedit.c +1 -2
@@ -436,8 +436,7 @@ static int tcf_pedit_dump(struct sk_buff *skb, struct tc_action *a,return -ENOBUFS ;spin_lock_bh (&p->tcf_lock); -memcpy (opt->keys, p->tcfp_keys, - p->tcfp_nkeys *sizeof (struct tc_pedit_key )); +memcpy (opt->keys, p->tcfp_keys,flex_array_size (opt, keys, p->tcfp_nkeys)); opt->index = p->tcf_index; opt->nkeys = p->tcfp_nkeys; opt->flags = p->tcfp_flags;
Signature · 1 line
2.27.0
From: "Gustavo A. R. Silva" <[email protected]>
Date: Wed, 29 Jul 2020 22:17:00 -0500
Quoted 8 lines
Make use of the
flex_array_size()helper to calculate the size of a flexible array member within an enclosing structure.This helper offers defense-in-depth against potential integer overflows, while at the same time makes it explicitly clear that we are dealing with a flexible array member.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied.