liquidio: Replace vmalloc with kmalloc in octeon_register_dispatch_fn()
Subsystems (3)
PATCH 1/1 liquidio: Replace vmalloc with kmalloc in octeon_register_dispatch_fn()
The size of struct octeon_dispatch is too small, it is better to use kmalloc instead of vmalloc.
Suggested-by Joe Perches <[email protected]>
Signed-off-by Wang Hai <[email protected]>
--- drivers/net/ethernet/cavium/liquidio/octeon_device.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)
drivers/net/ethernet/cavium/liquidio/octeon_device.c +4 -7
@@ -1056,7 +1056,7 @@ void octeon_delete_dispatch_list(struct octeon_device *oct)list_for_each_safe (temp, tmp2, &freelist) {list_del (temp); -vfree (temp); +kfree (temp); } }
@@ -1152,13 +1152,10 @@ octeon_register_dispatch_fn(struct octeon_device *oct,dev_dbg (&oct->pci_dev->dev,"Adding opcode to dispatch list linked list\n" ); - dispatch = (struct octeon_dispatch *) -vmalloc (sizeof (struct octeon_dispatch )); -if (!dispatch) { -dev_err (&oct->pci_dev->dev, -"No memory to add dispatch function\n" ); + dispatch =kmalloc (sizeof (*dispatch),GFP_KERNEL ); +if (!dispatch)return 1 ; - } + dispatch->opcode = combined_opcode; dispatch->dispatch_fn = fn; dispatch->arg = fn_arg;
Signature · 1 line
2.17.1
From: Wang Hai <[email protected]>
Date: Thu, 30 Jul 2020 14:11:40 +0800
Quoted 5 lines
The size of struct
octeon_dispatchis too small, it is better to use kmalloc instead of vmalloc.Suggested-by Joe Perches <[email protected]>Signed-off-by Wang Hai <[email protected]>
Applied, thank you.