net: gemini: Fix missing clk_disable_unprepare() in error path of gemini_ethernet_port_probe()
PATCH 1/1 net: gemini: Fix missing clk_disable_unprepare() in error path of gemini_ethernet_port_probe()
Fix the missing clk_disable_unprepare() before return from gemini_ethernet_port_probe() in the error handling case.
Fixes 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit ethernet")
Reported-by Hulk Robot <[email protected]>
Signed-off-by Wang Hai <[email protected]>
--- drivers/net/ethernet/cortina/gemini.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/net/ethernet/cortina/gemini.c +4 -1
@@ -2446,6 +2446,7 @@ static int gemini_ethernet_port_probe(struct platform_device *pdev) port->reset =devm_reset_control_get_exclusive (dev,NULL );if (IS_ERR (port->reset)) {dev_err (dev,"no reset\n" ); +clk_disable_unprepare (port->pclk);return PTR_ERR (port->reset); }reset_control_reset (port->reset);
@@ -2501,8 +2502,10 @@ static int gemini_ethernet_port_probe(struct platform_device *pdev)IRQF_SHARED , port_names[port->id], port); -if (ret) +if (ret) { +clk_disable_unprepare (port->pclk);return ret; + } ret =register_netdev (netdev);if (!ret) {
Signature · 1 line
2.17.1
From: Wang Hai <[email protected]>
Date: Thu, 30 Jul 2020 15:30:00 +0800
Quoted 6 lines
Fix the missing
clk_disable_unprepare()before return fromgemini_ethernet_port_probe()in the error handling case.Fixes 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit ethernet")Reported-by Hulk Robot <[email protected]>Signed-off-by Wang Hai <[email protected]>
Applied.