Revert "dpaa_eth: fix usage as DSA master, try 3"
Subsystems (3)
PATCH v2 1/1 Revert "dpaa_eth: fix usage as DSA master, try 3"
From: Vladimir Oltean <[email protected]>
This reverts commit 40a904b1c2e57b22dd002dfce73688871cb0bac8.
The patch is not wrong, but the Fixes: tag is. It should have been:
Fixes: 060ad66f9795 ("dpaa_eth: change DMA device")which means that it's fixing a commit which was introduced in:
git tag --contains 060ad66f97954
v5.5
which then means it should have not been backported to linux-5.4.y, where things _were_ working and now they're not.
---
Changes in v1:
Adjusted the commit message from linux-4.19.y to linux-5.4.y
Changes in v2:
Fixed the sha1sum of the reverted commit.
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c +1 -1
@@ -2796,7 +2796,7 @@ static int dpaa_eth_probe(struct platform_device *pdev) }/* Do this here, so we can be verbose early */ -SET_NETDEV_DEV (net_dev, dev->parent); +SET_NETDEV_DEV (net_dev, dev);dev_set_drvdata (dev, net_dev); priv =netdev_priv (net_dev);
Signature · 1 line
2.25.1
Greg KH
maintainerQuoted 44 lines · Vladimir Oltean
From: Vladimir Oltean <[email protected]>
This reverts commit
40a904b1c2e57b22dd002dfce73688871cb0bac8.The patch is not wrong, but the Fixes: tag is. It should have been:
Fixes: 060ad66f9795 ("dpaa_eth: change DMA device")which means that it's fixing a commit which was introduced in:
git tag --contains
060ad66f97954
v5.5which then means it should have not been backported to linux-5.4.y, where things _were_ working and now they're not.
Reported-by Joakim Tjernlund <[email protected]>Signed-off-by Vladimir Oltean <[email protected]>---
Changes in v1:
Adjusted the commit message from linux-4.19.y to linux-5.4.yChanges in v2:
Fixed the sha1sum of the reverted commit.drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/ethernet/freescale/dpaa/dpaa_eth.c +1
-1@@ -2796,7 +2796,7 @@ static int dpaa_eth_probe(struct platform_device *pdev) }/* Do this here, so we can be verbose early */ -SET_NETDEV_DEV (net_dev, dev->parent); +SET_NETDEV_DEV (net_dev, dev);dev_set_drvdata (dev, net_dev); priv =netdev_priv (net_dev);Signature · 1 line
2.25.1
Now queued up, thanks.
greg k-h
Quoted 4 lines · Greg KH
Now queued up, thanks.
greg k-h
Thanks Greg, I was wondering whether I should be reminding you or not.
-Vladimir