Add missing ethernet reset ID for Amlogic SoC
Subsystems (2)
cover Add missing ethernet reset ID for Amlogic SoC
These patch fix the Ethernet issue on Odroid C2 & Odroid N2 Some time Ethernet interface come up but no DHCP request is forwaded to the Router, this happens quite offern on my side. Adding Reset controller to ethernet node FIx the inilization issue.
-Anand
Anand Moon (3):
arm64: dts: amlogic: meson-gx: add missing ethernet reset ID
arm64: dts: amlogic: meson-axg: add missing ethernet reset ID
arm64: dts: amlogic: meson-g12: add missing ethernet reset ID
arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 2 ++ arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 ++ arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 3 +++ 3 files changed, 7 insertions(+)
Signature · 1 line
2.28.0
PATCH 1/3 arm64: dts: amlogic: meson-gx: add missing ethernet reset ID
Add missing etherent reset ID for reset controller to reset ethernet mac controller.
--- arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 3 +++ 1 file changed, 3 insertions(+)
arch/arm64/boot/dts/amlogic/meson-gx.dtsi +3 -0
@@ -12,6 +12,7 @@ #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/interrupt-controller/irq.h> #include <dt-bindings/interrupt-controller/arm-gic.h> +#include <dt-bindings/reset/amlogic,meson-gxbb-reset.h> #include <dt-bindings/thermal/thermal.h> / {
@@ -574,6 +575,8 @@ ethmac: ethernet@c9410000 { interrupt-names = "macirq"; rx-fifo-depth = <4096>; tx-fifo-depth = <2048>; + resets = <&reset RESET_ETHERNET>; + reset-names = "stmmaceth"; status = "disabled"; };
Signature · 1 line
2.28.0
PATCH 2/3 arm64: dts: amlogic: meson-axg: add missing ethernet reset ID
In reply to Anand MoonAdd missing etherent reset ID for reset controller to reset ethernet mac controller.
--- arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 2 ++ 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/amlogic/meson-axg.dtsi +2 -0
@@ -185,6 +185,8 @@ ethmac: ethernet@ff3f0000 { clock-names = "stmmaceth", "clkin0", "clkin1"; rx-fifo-depth = <4096>; tx-fifo-depth = <2048>; + resets = <&reset RESET_ETHERNET>; + reset-names = "stmmaceth"; status = "disabled"; };
Signature · 1 line
2.28.0
PATCH 3/3 arm64: dts: amlogic: meson-g12: add missing ethernet reset ID
In reply to Anand MoonAdd missing etherent reset ID for reset controller to reset ethernet mac controller.
--- arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 ++ 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi +2 -0
@@ -189,6 +189,8 @@ ethmac: ethernet@ff3f0000 { clock-names = "stmmaceth", "clkin0", "clkin1"; rx-fifo-depth = <4096>; tx-fifo-depth = <2048>; + resets = <&reset RESET_ETHERNET>; + reset-names = "stmmaceth"; status = "disabled"; mdio0: mdio {
Signature · 1 line
2.28.0
Quoted 6 lines · Anand Moon
These patch fix the Ethernet issue on Odroid C2 & Odroid N2 Some time Ethernet interface come up but no DHCP request is forwaded to the Router, this happens quite offern on my side. Adding Reset controller to ethernet node FIx the inilization issue.
I'm seeing this on other device as well. Strange that it pops up only now. Change tested on S905x, seems to help.
Quoted 6 lines
-Anand
Anand Moon (3):
arm64: dts: amlogic: meson-gx: add missing ethernet reset ID
arm64: dts: amlogic: meson-axg: add missing ethernet reset ID
arm64: dts: amlogic: meson-g12: add missing ethernet reset ID
None of the patches apply, please rebase on kevin's dt64 branch.
With that, you can add
Quoted 5 lines
arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 2 ++ arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 ++ arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 3 +++ 3 files changed, 7 insertions(+)
Jerome Brunet
reviewerQuoted 11 lines · Jerome Brunet
Quoted 6 lines · Anand Moon
These patch fix the Ethernet issue on Odroid C2 & Odroid N2 Some time Ethernet interface come up but no DHCP request is forwaded to the Router, this happens quite offern on my side. Adding Reset controller to ethernet node FIx the inilization issue.
I'm seeing this on other device as well. Strange that it pops up only now. Change tested on S905x, seems to help.
Strike that one - still seeing random DHCP issue on boot with this applied
Quoted 8 lines
Quoted 7 lines
-Anand
Anand Moon (3):
arm64: dts: amlogic: meson-gx: add missing ethernet reset ID
arm64: dts: amlogic: meson-axg: add missing ethernet reset ID
arm64: dts: amlogic: meson-g12: add missing ethernet reset ID
Quoted 5 lines
None of the patches apply, please rebase on kevin's dt64 branch.
With that, you can add
Tested-by Jerome Brunet <[email protected]>
So still worth rebasing and applying on I suppose but I don't think it solves the problem as described in this cover letter.
Quoted 6 lines
Quoted 6 lines
arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 2 ++ arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 ++ arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 3 +++ 3 files changed, 7 insertions(+)
Hi Jerome
Quoted 13 lines · Jerome Brunet
Quoted 9 lines · Jerome Brunet
Quoted 6 lines · Anand Moon
These patch fix the Ethernet issue on Odroid C2 & Odroid N2 Some time Ethernet interface come up but no DHCP request is forwaded to the Router, this happens quite offern on my side. Adding Reset controller to ethernet node FIx the inilization issue.
Quoted 20 lines
Quoted 2 lines
I'm seeing this on other device as well. Strange that it pops up only now. Change tested on S905x, seems to help.
Strike that one - still seeing random DHCP issue on boot with this applied
Quoted 13 lines
Quoted 7 lines
-Anand
Anand Moon (3):
arm64: dts: amlogic: meson-gx: add missing ethernet reset ID
arm64: dts: amlogic: meson-axg: add missing ethernet reset ID
arm64: dts: amlogic: meson-g12: add missing ethernet reset IDNone of the patches apply, please rebase on kevin's dt64 branch.
With that, you can add
Tested-by Jerome Brunet <[email protected]>
So I have to drop the Tested-by ?
Quoted 3 lines
So still worth rebasing and applying on I suppose but I don't think it solves the problem as described in this cover letter.
I have a mac address mapped to the ip address on my router, So I am just testing with the latest u-boot-2000.07 on my boards. Usually the ethernet comes up with no packet getting forwarded, Even ping to the device is not working, which is what I observed at my end many times.
I will try to rebase on top of Kevin's v5.9/dt64 if needed. Please let me know.
-Anand
Jerome Brunet
reviewerQuoted 30 lines · Anand Moon
Hi Jerome
Quoted 27 lines · Jerome Brunet
Quoted 11 lines · Jerome Brunet
Quoted 6 lines · Anand Moon
These patch fix the Ethernet issue on Odroid C2 & Odroid N2 Some time Ethernet interface come up but no DHCP request is forwaded to the Router, this happens quite offern on my side. Adding Reset controller to ethernet node FIx the inilization issue.
I'm seeing this on other device as well. Strange that it pops up only now. Change tested on S905x, seems to help.
Strike that one - still seeing random DHCP issue on boot with this applied
Quoted 8 lines
Quoted 7 lines
-Anand
Anand Moon (3):
arm64: dts: amlogic: meson-gx: add missing ethernet reset ID
arm64: dts: amlogic: meson-axg: add missing ethernet reset ID
arm64: dts: amlogic: meson-g12: add missing ethernet reset ID
Quoted 7 lines
Quoted 6 lines
Quoted 5 lines
None of the patches apply, please rebase on kevin's dt64 branch.
With that, you can add
Tested-by Jerome Brunet <[email protected]>So I have to drop the Tested-by ?
Yes
Quoted 10 lines
Quoted 4 lines
So still worth rebasing and applying on I suppose but I don't think it solves the problem as described in this cover letter.
I have a mac address mapped to the ip address on my router, So I am just testing with the latest u-boot-2000.07 on my boards. Usually the ethernet comes up with no packet getting forwarded, Even ping to the device is not working, which is what I observed at my end many times.
This is not the use case descibed in the cover letter. Please clarify if you resubmit.
Quoted 2 lines
I will try to rebase on top of Kevin's v5.9/dt64 if needed.
If you intend on submitting the series again, rebasing is necessary.
Quoted 3 lines
Please let me know.
-Anand
Hi Jerome,
Quoted 49 lines · Jerome Brunet
Quoted 30 lines · Anand Moon
Hi Jerome
Quoted 27 lines · Jerome Brunet
Quoted 11 lines · Jerome Brunet
Quoted 6 lines · Anand Moon
These patch fix the Ethernet issue on Odroid C2 & Odroid N2 Some time Ethernet interface come up but no DHCP request is forwaded to the Router, this happens quite offern on my side. Adding Reset controller to ethernet node FIx the inilization issue.
I'm seeing this on other device as well. Strange that it pops up only now. Change tested on S905x, seems to help.
Strike that one - still seeing random DHCP issue on boot with this applied
Quoted 8 lines
Quoted 7 lines
-Anand
Anand Moon (3):
arm64: dts: amlogic: meson-gx: add missing ethernet reset ID
arm64: dts: amlogic: meson-axg: add missing ethernet reset ID
arm64: dts: amlogic: meson-g12: add missing ethernet reset IDQuoted 7 lines
Quoted 6 lines
Quoted 5 lines
None of the patches apply, please rebase on kevin's dt64 branch.
With that, you can add
Tested-by Jerome Brunet <[email protected]>So I have to drop the Tested-by ?
Yes
Quoted 5 lines
Quoted 4 lines
So still worth rebasing and applying on I suppose but I don't think it solves the problem as described in this cover letter.
Quoted 9 lines
Quoted 5 lines
I have a mac address mapped to the ip address on my router, So I am just testing with the latest u-boot-2000.07 on my boards. Usually the ethernet comes up with no packet getting forwarded, Even ping to the device is not working, which is what I observed at my end many times.
This is not the use case descibed in the cover letter. Please clarify if you resubmit.
This was some observation at my end. If these changes don't fix the issue. I will drop my observation and just send the missing reset controller for ethernet
-Anand