ASoC: tlv320adcx140: Fix GPO register start address
Subsystems (3)
PATCH 1/2 ASoC: tlv320adcx140: Fix GPO register start address
The header was updated to align with the data sheet to start the GPO_CFG at GPO_CFG0. The code was not updated to the change and therefore the GPO_CFG0 register was not written to.
--- sound/soc/codecs/tlv320adcx140.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/tlv320adcx140.c +1 -1
@@ -790,7 +790,7 @@ static int adcx140_configure_gpo(struct adcx140_priv *adcx140) gpo_output_val = gpo_outputs[0 ] <<ADCX140_GPO_SHIFT | gpo_outputs[1 ]; - ret =regmap_write (adcx140->regmap,ADCX140_GPO_CFG1 + i, + ret =regmap_write (adcx140->regmap,ADCX140_GPO_CFG0 + i, gpo_output_val);if (ret)return ret;
Signature · 1 line
2.28.0
PATCH 2/2 ASoC: tlv320adcx140: Move device reset to before programming
Reset the device before programming the registers or all programming will be lost as the device resets registers to default settings.
--- sound/soc/codecs/tlv320adcx140.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
sound/soc/codecs/tlv320adcx140.c +4 -4
@@ -838,6 +838,10 @@ static int adcx140_codec_probe(struct snd_soc_component *component) bias_cfg = bias_source <<ADCX140_MIC_BIAS_SHIFT | vref_source; + ret =adcx140_reset (adcx140); +if (ret) + goto out; + pdm_count =device_property_count_u32 (adcx140->dev,"ti,pdm-edge-select" );if (pdm_count <=ADCX140_NUM_PDM_EDGES && pdm_count >0 ) {
@@ -885,10 +889,6 @@ static int adcx140_codec_probe(struct snd_soc_component *component)if (ret) goto out; - ret =adcx140_reset (adcx140); -if (ret) - goto out; -if (adcx140->supply_areg ==NULL ) sleep_cfg_val |=ADCX140_AREG_INTERNAL ;
Signature · 1 line
2.28.0
Mark Brown
maintainerQuoted 3 lines · Dan Murphy
The header was updated to align with the data sheet to start the
GPO_CFGatGPO_CFG0. The code was not updated to the change and therefore theGPO_CFG0register was not written to.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/2] ASoC: tlv320adcx140: Fix GPO register start address
commit: 806a8afedef82c5f156b1c9b1de1205f9abfd21e
[2/2] ASoC: tlv320adcx140: Move device reset to before programming
commit: 982f4a4134893cd48c466e7a56422d7c65837d10All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark