ethnl_set_linkmodes: remove redundant null check
Subsystems (3)
PATCH 1/1 ethnl_set_linkmodes: remove redundant null check
info cannot be NULL here since its being accessed earlier in the function: nlmsg_parse(info->nlhdr...). Remove this redundant NULL check.
--- net/ethtool/linkmodes.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
net/ethtool/linkmodes.c +1 -2
@@ -406,8 +406,7 @@ int ethnl_set_linkmodes(struct sk_buff *skb, struct genl_info *info) ret =__ethtool_get_link_ksettings (dev, &ksettings);if (ret <0 ) { -if (info) -GENL_SET_ERR_MSG (info,"failed to retrieve link settings" ); +GENL_SET_ERR_MSG (info,"failed to retrieve link settings" ); goto out_ops; }
Signature · 1 line
2.17.1
Quoted 3 lines · Gaurav Singh
info cannot be NULL here since its being accessed earlier in the function:
nlmsg_parse(info->nlhdr...). Remove this redundant NULL check.
This is what the static checker tells you but it could still mean the other place is missing the check. The actual reason why this check is superfluous is that the function is only used as ->doit() handler which is never called with null info.
Quoted 1 line
Signed-off-by Gaurav Singh <[email protected]>
The subject should rather start with "ethtool: " (instead of "[net/ethtool] ").
For the change itself:
Michal
Quoted 21 lines
--- net/ethtool/linkmodes.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)net/ethtool/linkmodes.c +1
-2@@ -406,8 +406,7 @@ int ethnl_set_linkmodes(struct sk_buff *skb, struct genl_info *info) ret =__ethtool_get_link_ksettings (dev, &ksettings);if (ret <0 ) { -if (info) -GENL_SET_ERR_MSG (info,"failed to retrieve link settings" ); +GENL_SET_ERR_MSG (info,"failed to retrieve link settings" ); goto out_ops; }Signature · 1 line
2.17.1
From: Gaurav Singh <[email protected]>
Date: Fri, 31 Jul 2020 00:58:44 -0400
Quoted 5 lines
info cannot be NULL here since its being accessed earlier in the function:
nlmsg_parse(info->nlhdr...). Remove this redundant NULL check.Signed-off-by Gaurav Singh <[email protected]>
Applied, thank you.