Skip to contentSkip to conversation

Add missing ethernet reset ID for Amlogic SoC

PATCH New Anand Moon 1 participant 4 messages Jul 31, 2020

Subsystems (2)
lore
Share & tools
lore

Anand Moon

author
#0 lore raw

v2 cover Add missing ethernet reset ID for Amlogic SoC

Add reset id for Ethernet to reset Ethernet IP.

Re-based on linux-next-20200730.
Could not test as their is build failed on linux-next-20200730.

My observation:
- Sometime the device on upgrade of the kernel don't show up in the network.
- My observation that Ethernet interface come up successfully but no packet get forwarded.
- This happens some times on my network.

-Anand

Anand Moon (3):
arm64: dts: amlogic: meson-gx: add missing ethernet reset ID
arm64: dts: amlogic: meson-axg: add missing ethernet reset ID
arm64: dts: amlogic: meson-g12: add missing ethernet reset ID

 arch/arm64/boot/dts/amlogic/meson-axg.dtsi        | 2 ++
 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 ++
 arch/arm64/boot/dts/amlogic/meson-gx.dtsi         | 3 +++
 3 files changed, 7 insertions(+)
Signature · 2 lines
2.28.0
:
author
#1 lore raw

PATCH v2 1/3 arm64: dts: amlogic: meson-gx: add missing ethernet reset ID

Add missing etherent reset ID for reset controller to reset ethernet mac controller.

---
Changes V2
-Rebased on linux-next-20200730

---
 arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 3 +++
 1 file changed, 3 insertions(+)
arch/arm64/boot/dts/amlogic/meson-gx.dtsi +3 -0
index 0edd137151f8..726b91d3a905 100644
@@ -13,6 +13,7 @@
 #include <dt-bindings/interrupt-controller/irq.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/power/meson-gxbb-power.h>
+#include <dt-bindings/reset/amlogic,meson-gxbb-reset.h>
 #include <dt-bindings/thermal/thermal.h>
 
 / {
@@ -575,6 +576,8 @@ ethmac: ethernet@c9410000 {
 			interrupt-names = "macirq";
 			rx-fifo-depth = <4096>;
 			tx-fifo-depth = <2048>;
+			resets = <&reset RESET_ETHERNET>;
+			reset-names = "stmmaceth";
 			power-domains = <&pwrc PWRC_GXBB_ETHERNET_MEM_ID>;
 			status = "disabled";
 		};
Signature · 1 line
2.28.0
author
#2 lore raw

PATCH v2 2/3 arm64: dts: amlogic: meson-axg: add missing ethernet reset ID

In reply to Anand Moon

Add missing etherent reset ID for reset controller to reset ethernet mac controller.

---
Changes V2
-Rebased on linux-next-20200730

---
 arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/amlogic/meson-axg.dtsi +2 -0
index b9efc8469265..8e134cb470d3 100644
@@ -187,6 +187,8 @@ ethmac: ethernet@ff3f0000 {
 				      "timing-adjustment";
 			rx-fifo-depth = <4096>;
 			tx-fifo-depth = <2048>;
+			resets = <&reset RESET_ETHERNET>;
+			reset-names = "stmmaceth";
 			status = "disabled";
 		};
 
Signature · 1 line
2.28.0
author
#3 lore raw

PATCH v2 3/3 arm64: dts: amlogic: meson-g12: add missing ethernet reset ID

In reply to Anand Moon

Add missing etherent reset ID for reset controller to reset ethernet mac controller.

----
Changes V2:
-Rebased on linux-next-2020730

---
 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi +2 -0
index 1e83ec5b8c91..63d19fbe8899 100644
@@ -224,6 +224,8 @@ ethmac: ethernet@ff3f0000 {
 				      "timing-adjustment";
 			rx-fifo-depth = <4096>;
 			tx-fifo-depth = <2048>;
+			resets = <&reset RESET_ETHERNET>;
+			reset-names = "stmmaceth";
 			status = "disabled";
 
 			mdio0: mdio {
Signature · 1 line
2.28.0