Skip to contentSkip to conversation

rtc: interface:: 1969-12-31T23:59:59 is set as rtc_time if rtc_time is invalid in __rtc_read_time

PATCH In review Grant Feng 2 participants 6 messages Aug 1, 2020 – Aug 3, 2020 Real time clock (RTC)

lore
Share & tools
lore

Grant Feng

author
#0 lore raw

PATCH 1/1 rtc: interface:: 1969-12-31T23:59:59 is set as rtc_time if rtc_time is invalid in __rtc_read_time

1969-12-31T23:59:59 is an error more clear than Invalid argument

For example, when the RTC clock is not set, it will print a kernel error log every time someone tries to read the clock:
~ # hwclock -r
hwclock: RTC_RD_TIME: Invalid argument

It's clear and easy to understand what happened if print

1969-12-31T23:59:59 in this situation:
        ~ # hwclock -r
        Wed Dec 31 23:59:59 1969  0.000000 seconds
---
 drivers/rtc/interface.c | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)
drivers/rtc/interface.c +13 -1
index 794a4f036b99..e6b3f4163565 100644
@@ -101,8 +101,20 @@ static int __rtc_read_time(struct rtc_device *rtc, struct rtc_time *tm)
 		rtc_add_offset(rtc, tm);
 
 		err = rtc_valid_tm(tm);
-		if (err < 0)
+		if (err < 0) {
 			dev_dbg(&rtc->dev, "read_time: rtc_time isn't valid\n");
+
+			tm->tm_sec = 59;
+			tm->tm_min = 59;
+			tm->tm_hour = 23;
+			tm->tm_mday = 31;
+			tm->tm_mon = 11;
+			tm->tm_year = 69;
+			tm->tm_wday = 3;
+			tm->tm_yday = 365;
+			tm->tm_isdst = 0;
+		}
+		err = 0;
 	}
 	return err;
 }
Signature · 1 line
2.17.1
#1 lore raw

Hi,

Quoted 1 line · Grant Feng
1969-12-31T23:59:59 is an error more clear than Invalid argument

Definitively not, 1969-12-31T23:59:59 is a valid date and should not be returned when it is known the current date is not set in the RTC.

Quoted 11 lines

For example, when the RTC clock is not set, it will print a kernel error log every time someone tries to read the clock:
~ # hwclock -r
hwclock: RTC_RD_TIME: Invalid argument

It's clear and easy to understand what happened if print

1969-12-31T23:59:59 in this situation:
        ~ # hwclock -r
        Wed Dec 31 23:59:59 1969  0.000000 seconds

How do you know this is an error an not what is actually set on the RTC?

Signature · 3 lines
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author
#2 lore raw

Re: [PATCH] rtc: interface^ 1969-12-31T23:59:59 is set as rtc_time if rtc_time is invalid in __rtc_read_time

Hi,

Quoted 4 lines · Alexandre Belloni
Quoted 1 line · Grant Feng
1969-12-31T23:59:59 is an error more clear than Invalid argument

Definitively not, 1969-12-31T23:59:59 is a valid date and should not be returned when it is known the current date is not set in the RTC.

'rtc_valid_tm' is used to check rtc_time and 1969-12-31T23:59:59 is invalid. when the RTC clock is not set, some rtc devices always return '0' or almost random data, and different rtc devices may give different return data. so, I think, it's usful to return a default date when the current date is not set in the RTC.

Quoted 11 lines
Quoted 10 lines

For example, when the RTC clock is not set, it will print a kernel error log every time someone tries to read the clock:
~ # hwclock -r
hwclock: RTC_RD_TIME: Invalid argument

It's clear and easy to understand what happened if print

1969-12-31T23:59:59 in this situation:
         ~ # hwclock -r
         Wed Dec 31 23:59:59 1969  0.000000 seconds

How do you know this is an error an not what is actually set on the RTC?

'rtc_valid_tm' will check rtc_time when someone set the RTC, the time should not be earlier than 1970-1-1T00:00:00. so 1969-12-31T23:59:59 can not be actually set on the RTC.
    When someone get
~ # hwclock -r
Wed Dec 31 23:59:59 1969  0.000000 seconds
    he knows: the RTC time doesn't match my watch, change it now. but still lots of people don't know what happened if they see ~ # hwclock -r
hwclock: RTC_RD_TIME: Invalid argument

Grant Feng
Embedded Linux and Kernel engineering RTCHIP Information Technology (Shanghai) Co., Ltd.

#3 lore raw

Re: [PATCH] rtc: interface^ 1969-12-31T23:59:59 is set as rtc_time if rtc_time is invalid in __rtc_read_time

Quoted 10 lines · Grant Feng
Quoted 4 lines · Alexandre Belloni
Quoted 1 line · Grant Feng
1969-12-31T23:59:59 is an error more clear than Invalid argument

Definitively not, 1969-12-31T23:59:59 is a valid date and should not be returned when it is known the current date is not set in the RTC.

'rtc_valid_tm' is used to check rtc_time and 1969-12-31T23:59:59 is invalid. when the RTC clock is not set, some rtc devices always return '0' or almost random data, and different rtc devices may give different return data. so, I think, it's usful to return a default date when the current date is not set in the RTC.

You are not solving the issue you mention here. If the RTC doesn't know whether the date/time is invalid and the core think it is valid, then your code will not run.

Quoted 11 lines
Quoted 11 lines
Quoted 10 lines

For example, when the RTC clock is not set, it will print a kernel error log every time someone tries to read the clock:
~ # hwclock -r
hwclock: RTC_RD_TIME: Invalid argument

It's clear and easy to understand what happened if print

1969-12-31T23:59:59 in this situation:
         ~ # hwclock -r
         Wed Dec 31 23:59:59 1969  0.000000 seconds

How do you know this is an error an not what is actually set on the RTC?

Quoted 11 lines

'rtc_valid_tm' will check rtc_time when someone set the RTC, the time should not be earlier than 1970-1-1T00:00:00. so 1969-12-31T23:59:59 can not be actually set on the RTC.
    When someone get
~ # hwclock -r
Wed Dec 31 23:59:59 1969  0.000000 seconds
    he knows: the RTC time doesn't match my watch, change it now. but still lots of people don't know what happened if they see ~ # hwclock -r
hwclock: RTC_RD_TIME: Invalid argument

This makes userspace checking for errors way worse. Think about it, first userspace will need to check for an error when calling the ioctl then it will have to check the time and consider a vlid date invalid. Seriously, if hwclock doesn't do what you want, you can either patch it or use another tool.

Signature · 3 lines
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author
#4 lore raw

Re: [PATCH] rtc: interface^ 1969-12-31T23:59:59 is set as rtc_time if rtc_time is invalid in __rtc_read_time

Thank you for explaining that.

Quoted 43 lines · Alexandre Belloni
Quoted 10 lines · Grant Feng
Quoted 4 lines · Alexandre Belloni
Quoted 1 line · Grant Feng
1969-12-31T23:59:59 is an error more clear than Invalid argument

Definitively not, 1969-12-31T23:59:59 is a valid date and should not be returned when it is known the current date is not set in the RTC.

'rtc_valid_tm' is used to check rtc_time and 1969-12-31T23:59:59 is invalid. when the RTC clock is not set, some rtc devices always return '0' or almost random data, and different rtc devices may give different return data. so, I think, it's usful to return a default date when the current date is not set in the RTC.

You are not solving the issue you mention here. If the RTC doesn't know whether the date/time is invalid and the core think it is valid, then your code will not run.

Quoted 11 lines
Quoted 11 lines
Quoted 10 lines

For example, when the RTC clock is not set, it will print a kernel error log every time someone tries to read the clock:
~ # hwclock -r
hwclock: RTC_RD_TIME: Invalid argument

It's clear and easy to understand what happened if print

1969-12-31T23:59:59 in this situation:
          ~ # hwclock -r
          Wed Dec 31 23:59:59 1969  0.000000 seconds

How do you know this is an error an not what is actually set on the RTC?

Quoted 11 lines

'rtc_valid_tm' will check rtc_time when someone set the RTC, the time should not be earlier than 1970-1-1T00:00:00. so 1969-12-31T23:59:59 can not be actually set on the RTC.
    When someone get
~ # hwclock -r
Wed Dec 31 23:59:59 1969  0.000000 seconds
    he knows: the RTC time doesn't match my watch, change it now.
but still lots of people don't know what happened if they see ~ # hwclock -r
hwclock: RTC_RD_TIME: Invalid argument

This makes userspace checking for errors way worse. Think about it, first userspace will need to check for an error when calling the ioctl then it will have to check the time and consider a vlid date invalid. Seriously, if hwclock doesn't do what you want, you can either patch it or use another tool.

author
#5 lore raw

Re: [PATCH] rtc: interface^ 1969-12-31T23:59:59 is set as rtc_time if rtc_time is invalid in __rtc_read_time

In reply to Alexandre Belloni

Thank you again for your patience to explain.
I get the log and now I get it.

commit 812318a094d0715194d9f686b22ee67e7dc59d93
Author: Alexandre Belloni <[email protected]> Date:   Wed Feb 21 11:44:26 2018 +0100

    rtc: cmos: let the core handle invalid time

    Setting the rtc to a valid time when the time is invalid is a bad practice, because then userspace doesn't know it shouldn't trust the RTC.

then you removed the following code fragment in "drivers/rtc/rtc-cmos.c":

-       cmos_read_time(&pdev->dev, &time);
-       ret = rtc_valid_tm(&time);
-       if (ret) {
-               struct rtc_time def_time = { -                       .tm_year = 1,
-                       .tm_mday = 1,
-               };
-               cmos_set_time(&pdev->dev, &def_time); -       }

Quoted 43 lines · Alexandre Belloni
Quoted 10 lines · Grant Feng
Quoted 4 lines · Alexandre Belloni
Quoted 1 line · Grant Feng
1969-12-31T23:59:59 is an error more clear than Invalid argument

Definitively not, 1969-12-31T23:59:59 is a valid date and should not be returned when it is known the current date is not set in the RTC.

'rtc_valid_tm' is used to check rtc_time and 1969-12-31T23:59:59 is invalid. when the RTC clock is not set, some rtc devices always return '0' or almost random data, and different rtc devices may give different return data. so, I think, it's usful to return a default date when the current date is not set in the RTC.

You are not solving the issue you mention here. If the RTC doesn't know whether the date/time is invalid and the core think it is valid, then your code will not run.

Quoted 11 lines
Quoted 11 lines
Quoted 10 lines

For example, when the RTC clock is not set, it will print a kernel error log every time someone tries to read the clock:
~ # hwclock -r
hwclock: RTC_RD_TIME: Invalid argument

It's clear and easy to understand what happened if print

1969-12-31T23:59:59 in this situation:
          ~ # hwclock -r
          Wed Dec 31 23:59:59 1969  0.000000 seconds

How do you know this is an error an not what is actually set on the RTC?

Quoted 11 lines

'rtc_valid_tm' will check rtc_time when someone set the RTC, the time should not be earlier than 1970-1-1T00:00:00. so 1969-12-31T23:59:59 can not be actually set on the RTC.
    When someone get
~ # hwclock -r
Wed Dec 31 23:59:59 1969  0.000000 seconds
    he knows: the RTC time doesn't match my watch, change it now.
but still lots of people don't know what happened if they see ~ # hwclock -r
hwclock: RTC_RD_TIME: Invalid argument

This makes userspace checking for errors way worse. Think about it, first userspace will need to check for an error when calling the ioctl then it will have to check the time and consider a vlid date invalid. Seriously, if hwclock doesn't do what you want, you can either patch it or use another tool.