Skip to contentSkip to conversation

staging: r8188eu: replace rtw_netdev_priv define with inline function

PATCH New Ivan Safonov 1 participant 1 message Aug 1, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 staging: r8188eu: replace rtw_netdev_priv define with inline function

The function guarantees type checking of arguments and return value.

Result of rtw_netdev_priv macro can be assigned to pointer with incompatible type without warning. The function allow compiler to perform this check.

---
Changes in v2:
- add blank line after function definition;
- improve commit message.

Changes in v3:
- use proper argument name;
- remove unnecessary parentheses.

---
 drivers/staging/rtl8188eu/include/osdep_service.h | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/staging/rtl8188eu/include/osdep_service.h +5 -2
index 31d897f1d21f..b44d602e954a 100644
@@ -71,8 +71,11 @@ struct rtw_netdev_priv_indicator {
 };
 struct net_device *rtw_alloc_etherdev_with_old_priv(void *old_priv);
 
-#define rtw_netdev_priv(netdev)					\
-	(((struct rtw_netdev_priv_indicator *)netdev_priv(netdev))->priv)
+static inline struct adapter *rtw_netdev_priv(struct net_device *netdev)
+{
+	return ((struct rtw_netdev_priv_indicator *)netdev_priv(netdev))->priv;
+}
+
 void rtw_free_netdev(struct net_device *netdev);
 
 #define FUNC_NDEV_FMT "%s(%s)"
Signature · 1 line
2.26.2