Checkpatch tool errors clean up
Subsystems (2)
cover Checkpatch tool errors clean up
Hi
I am proposing these 4 patches.
I am currently learning the core kernel the hard way. I will appreciate any feedback negative or positive. Thanks
Jules Irenge (4):
acct: Add required space between variable and operator
audit: uninitialize global variable audit_sig_sid
audit: uninitialize static variables
context_tracking: uninitialize static variables
kernel/acct.c | 2 +- kernel/audit.c | 10 +++++----- kernel/context_tracking.c | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-)
Signature · 1 line
2.26.2
PATCH 1/4 acct: Add required space between variable and operator
Checkpatch tool reports an error
"ERROR: spaces required around that == (ctx:VxV)"
To fix this space has been added between the variable, the operator and the value.
Add the missing required space.
--- kernel/acct.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/acct.c +1 -1
@@ -451,7 +451,7 @@ static void fill_ac(acct_t *ac)do_div (elapsed,AHZ ); btime =ktime_get_real_seconds () - elapsed; ac->ac_btime =clamp_t (time64_t, btime,0 ,U32_MAX ); -#if ACCT_VERSION ==2 +#if ACCT_VERSION ==2 ac->ac_ahz =AHZ ;#endif
Signature · 1 line
2.26.2
PATCH 2/4 audit: uninitialize global variable audit_sig_sid
In reply to Jules IrengeCheckpatch tool reports an error at variable audit_sig_sid declaration
"ERROR: do not initialise globals to 0"
To fix this, the global variable has been uninitialized.
--- kernel/audit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/audit.c +1 -1
@@ -125,7 +125,7 @@ static u32 audit_backlog_wait_time = AUDIT_BACKLOG_WAIT_TIME;/* The identity of the user shutting down the audit system. */ kuid_t audit_sig_uid =INVALID_UID ;pid_t audit_sig_pid =-1 ; -u32 audit_sig_sid =0 ; +u32 audit_sig_sid;/* Records can be lost in several ways: 0) [suppressed in audit_alloc]
Signature · 1 line
2.26.2
Re: [PATCH 2/4] audit: uninitialize global variable audit_sig_sid
Quoted 1 line · Jules Irenge
Checkpatch tool reports an error at variable
audit_sig_siddeclaration
[]
kernel/audit.c
Quoted 1 line
kernel/audit.c +0
-0
[]
kernel/audit.c static u32 audit_backlog_wait_time = AUDIT_BACKLOG_WAIT_TIME; · line 128
Quoted 6 lines
kernel/audit.c +1
-1@@ -125,7 +125,7 @@ static u32 audit_backlog_wait_time = AUDIT_BACKLOG_WAIT_TIME;/* The identity of the user shutting down the audit system. */ kuid_t audit_sig_uid =INVALID_UID ;pid_t audit_sig_pid =-1 ; -u32 audit_sig_sid =0 ; +u32 audit_sig_sid;
All of these are unused outside of audit.c and might as well be static and removed from the .h file.
Paul Moore
maintainerRe: [PATCH 2/4] audit: uninitialize global variable audit_sig_sid
Quoted 5 lines · Joe Perches
Quoted 1 line · Jules Irenge
Checkpatch tool reports an error at variable
audit_sig_siddeclaration[]
kernel/audit.c
Quoted 1 line
kernel/audit.c +0
-0[]
Quoted 9 lines
kernel/audit.c static u32 audit_backlog_wait_time = AUDIT_BACKLOG_WAIT_TIME; · line 128
Quoted 6 lines
kernel/audit.c +1
-1@@ -125,7 +125,7 @@ static u32 audit_backlog_wait_time = AUDIT_BACKLOG_WAIT_TIME;/* The identity of the user shutting down the audit system. */ kuid_t audit_sig_uid =INVALID_UID ;pid_t audit_sig_pid =-1 ; -u32 audit_sig_sid =0 ; +u32 audit_sig_sid;All of these are unused outside of
audit.cand might as well be static and removed from the .h file.
There's plenty of time before the merge window closes, doing this would definitely make this patch much more useful than the typical checkpatch noise.
Signature · 7 lines
paul moore www.paul-moore.com -- Linux-audit mailing list [email protected] https://www.redhat.com/mailman/listinfo/linux-audit
Re: [PATCH 2/4] audit: uninitialize global variable audit_sig_sid
In reply to Joe PerchesQuoted 5 lines · Joe Perches
Quoted 1 line · Jules Irenge
Checkpatch tool reports an error at variable
audit_sig_siddeclaration[]
kernel/audit.c
Quoted 1 line
kernel/audit.c +0
-0[]
Quoted 10 lines
kernel/audit.c static u32 audit_backlog_wait_time = AUDIT_BACKLOG_WAIT_TIME; · line 128
Quoted 6 lines
kernel/audit.c +1
-1@@ -125,7 +125,7 @@ static u32 audit_backlog_wait_time = AUDIT_BACKLOG_WAIT_TIME;/* The identity of the user shutting down the audit system. */ kuid_t audit_sig_uid =INVALID_UID ;pid_t audit_sig_pid =-1 ; -u32 audit_sig_sid =0 ; +u32 audit_sig_sid;All of these are unused outside of
audit.cand might as well be static and removed from the .h file.
Thanks for reply, I will resend a second version with the recommendation, namely make the above static and remove them from the .h file.
Jules
PATCH 3/4 audit: uninitialize static variables
In reply to Jules IrengeCheckpatch tool reports an error at variable declaration
"ERROR: do not initialise statics to 0"
This is due to the fact that these variables are stored in the buffer In the .bss section, one can not set an initial value
Here we can trust the compiler to automatically set them to zero. The variable has since been uninitialized.
--- kernel/audit.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
kernel/audit.c +4 -4
@@ -311,8 +311,8 @@ void audit_panic(const char *message)static inline int audit_rate_check (void ) { -static unsigned long last_check =0 ; -static int messages =0 ; +static unsigned long last_check; +static int messages;static DEFINE_SPINLOCK (lock);unsigned long flags;unsigned long now;
@@ -348,7 +348,7 @@ static inline int audit_rate_check(void)*/ void audit_log_lost (const char *message) { -static unsigned long last_msg =0 ; +static unsigned long last_msg;static DEFINE_SPINLOCK (lock);unsigned long flags;unsigned long now;
@@ -713,7 +713,7 @@ static int kauditd_send_queue(struct sock *sk, u32 portid, {int rc =0 ;struct sk_buff *skb; -static unsigned int failed =0 ; +static unsigned int failed;/* NOTE: kauditd_thread takes care of all our locking, we just use * the netlink info passed to us (e.g. sk and portid) */
Signature · 1 line
2.26.2
Paul Moore
maintainerRe: [PATCH 3/4] audit: uninitialize static variables
Quoted 10 lines · Jules Irenge
Checkpatch tool reports an error at variable declaration
"ERROR: do not initialise statics to 0"
This is due to the fact that these variables are stored in the buffer In the .bss section, one can not set an initial value
Here we can trust the compiler to automatically set them to zero. The variable has since been uninitialized.
Quoted 4 lines
Signed-off-by Jules Irenge <[email protected]>--- kernel/audit.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
In general this is fine, but it will have to wait until after the merge window closes.
Quoted 35 lines
kernel/audit.c +4
-5@@ -311,8 +311,8 @@ void audit_panic(const char *message)static inline int audit_rate_check (void ) { -static unsigned long last_check =0 ; -static int messages =0 ; +static unsigned long last_check; +static int messages;static DEFINE_SPINLOCK (lock);unsigned long flags;unsigned long now;@@ -348,7 +348,7 @@ static inline int audit_rate_check(void)*/ void audit_log_lost (const char *message) { -static unsigned long last_msg =0 ; +static unsigned long last_msg;static DEFINE_SPINLOCK (lock);unsigned long flags;unsigned long now;@@ -713,7 +713,7 @@ static int kauditd_send_queue(struct sock *sk, u32 portid, {int rc =0 ;struct sk_buff *skb; -static unsigned int failed =0 ; +static unsigned int failed;/* NOTE: kauditd_thread takes care of all our locking, we just use * the netlink info passed to us (e.g. sk and portid) */ --2.26.2
Signature · 7 lines
paul moore www.paul-moore.com -- Linux-audit mailing list [email protected] https://www.redhat.com/mailman/listinfo/linux-audit
PATCH 4/4 context_tracking: uninitialize static variables
In reply to Jules IrengeCheckpatch tool reports an error at a staic variable declaration
"ERROR: do not initialise statics to false"
This is due to the fact that this variable is stored in the buffer In the .bss section, one can not set an initial value Here we can trust the compiler to automatically set them to false. The variable has since been uninitialized.
--- kernel/context_tracking.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/context_tracking.c +1 -1
@@ -190,7 +190,7 @@ NOKPROBE_SYMBOL(context_tracking_user_exit);void __init context_tracking_cpu_set (int cpu) { -static __initdata bool initialized = false; +static __initdata bool initialized;if (!per_cpu (context_tracking.active, cpu)) {per_cpu (context_tracking.active, cpu) = true;
Signature · 1 line
2.26.2
Re: [PATCH 4/4] context_tracking: uninitialize static variables
Quoted 19 lines · Jules Irenge
Checkpatch tool reports an error at a staic variable declaration
"ERROR: do not initialise statics to false"
This is due to the fact that this variable is stored in the buffer In the .bss section, one can not set an initial value Here we can trust the compiler to automatically set them to false. The variable has since been uninitialized.
Signed-off-by Jules Irenge <[email protected]>--- kernel/context_tracking.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/context_tracking.c +0
-0
kernel/context_tracking.c NOKPROBE_SYMBOL(context_tracking_user_exit); · line 193
Quoted 5 lines
kernel/context_tracking.c +1
-1@@ -190,7 +190,7 @@ NOKPROBE_SYMBOL(context_tracking_user_exit);void __init context_tracking_cpu_set (int cpu) { -static __initdata bool initialized = false; +static __initdata bool initialized;
So personally I prefer having the '= false' there. It used to be that compilers were stupid and would put any initialized static variable in .data, even if it was initialized with 0. But AFAIK compilers are no longer that stupid.
Re: [PATCH 4/4] context_tracking: uninitialize static variables
Quoted 5 lines · On Mon, 3 Aug 2020, [email protected] wrote:
So personally I prefer having the '= false' there. It used to be that compilers were stupid and would put any initialized static variable in .data, even if it was initialized with 0. But AFAIK compilers are no longer that stupid.
Thanks for the reply, I completely understand the precaution measure.
Quoted 5 lines · Jules Irenge
Hi
I am proposing these 4 patches.
I am currently learning the core kernel the hard way. I will appreciate any feedback negative or positive. Thanks
Generally, whitespace only changes outside of drivers/staging are not encouraged.
Quoted 11 lines
Jules Irenge (4):
acct: Add required space between variable and operator
audit: uninitialize global variableaudit_sig_sid
audit: uninitialize static variables
context_tracking: uninitialize static variableskernel/acct.c | 2 +- kernel/audit.c | 10 +++++----- kernel/context_tracking.c | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-)
Quoted 22 lines · Joe Perches
Quoted 5 lines · Jules Irenge
Hi
I am proposing these 4 patches.
I am currently learning the core kernel the hard way. I will appreciate any feedback negative or positive. ThanksGenerally, whitespace only changes outside of
drivers/stagingare not encouraged.Quoted 11 lines
Jules Irenge (4):
acct: Add required space between variable and operator
audit: uninitialize global variableaudit_sig_sid
audit: uninitialize static variables
context_tracking: uninitialize static variableskernel/acct.c | 2 +- kernel/audit.c | 10 +++++----- kernel/context_tracking.c | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-)
Thanks, I take good note.
Kind regards,
Jules