Skip to contentSkip to conversation

mm/percpu.c: Modify size of populated bitmap of chunk for memory allocation

PATCH New mcsmonk 1 participant 1 message Aug 2, 2020 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]; [email protected]; [email protected]; [email protected]

mcsmonk

author
#1 lore raw

PATCH 1/1 mm/percpu.c: Modify size of populated bitmap of chunk for memory allocation

From: Sunghyun Jin <[email protected]>

Variable populated, which is a member of struct pcpu_chunk, is used as a unit of size of unsigned long in below code:

```
1142         /* manage populated page bitmap */
1143         chunk->immutable = true;
1144         bitmap_fill(chunk->populated, chunk->nr_pages);
```
```
230 static inline void bitmap_fill(unsigned long *dst, unsigned int
nbits)
231 {
232         unsigned int len = BITS_TO_LONGS(nbits)
                               * sizeof(unsigned long);
233         memset(dst, 0xff, len);
234 }
```

However, size of populated is miscounted. So, I fix this minor part.

---
 mm/percpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/percpu.c +1 -1
index 696367b18222..d83e0032cb20 100644
@@ -1300,7 +1300,7 @@ static struct pcpu_chunk * __init pcpu_alloc_first_chunk(unsigned long tmp_addr,
 
 	/* allocate chunk */
 	alloc_size = sizeof(struct pcpu_chunk) +
-		BITS_TO_LONGS(region_size >> PAGE_SHIFT);
+		BITS_TO_LONGS(region_size >> PAGE_SHIFT) * sizeof(unsigned long);
 	chunk = memblock_alloc(alloc_size, SMP_CACHE_BYTES);
 	if (!chunk)
 		panic("%s: Failed to allocate %zu bytes\n", __func__,
Signature · 1 line
2.17.1