arm64: dts: ti: k3-am65: restrict PCIe to Gen2 speed
Subsystems (2)
PATCH 1/1 arm64: dts: ti: k3-am65: restrict PCIe to Gen2 speed
Per errata i2104 documented in AM65x device errata document (TI document number SPRZ452E, revised June 2019), Gen3 operation is not supported for both PCIe Root Complex and Endpoint modes of operation.
See: https://www.ti.com/lit/er/sprz452e/sprz452e.pdf
Restrict speed to Gen2 to address the errata.
--- arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +4 -4
@@ -650,7 +650,7 @@ ti,syscon-pcie-mode = <&pcie0_mode>; bus-range = <0x0 0xff>; num-viewport = <16>; - max-link-speed = <3>; + max-link-speed = <2>; dma-coherent; interrupts = <GIC_SPI 340 IRQ_TYPE_EDGE_RISING>; msi-map = <0x0 &gic_its 0x0 0x10000>;
@@ -664,7 +664,7 @@ ti,syscon-pcie-mode = <&pcie0_mode>; num-ib-windows = <16>; num-ob-windows = <16>; - max-link-speed = <3>; + max-link-speed = <2>; dma-coherent; interrupts = <GIC_SPI 340 IRQ_TYPE_EDGE_RISING>; };
@@ -682,7 +682,7 @@ ti,syscon-pcie-mode = <&pcie1_mode>; bus-range = <0x0 0xff>; num-viewport = <16>; - max-link-speed = <3>; + max-link-speed = <2>; dma-coherent; interrupts = <GIC_SPI 355 IRQ_TYPE_EDGE_RISING>; msi-map = <0x0 &gic_its 0x10000 0x10000>;
@@ -696,7 +696,7 @@ ti,syscon-pcie-mode = <&pcie1_mode>; num-ib-windows = <16>; num-ob-windows = <16>; - max-link-speed = <3>; + max-link-speed = <2>; dma-coherent; interrupts = <GIC_SPI 355 IRQ_TYPE_EDGE_RISING>; };
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi Nishanth,
Quoted 9 lines · Sekhar Nori
Per errata i2104 documented in AM65x device errata document (TI document number SPRZ452E, revised June 2019), Gen3 operation is not supported for both PCIe Root Complex and Endpoint modes of operation.
See: https://www.ti.com/lit/er/sprz452e/sprz452e.pdf
Restrict speed to Gen2 to address the errata.
Signed-off-by Sekhar Nori <[email protected]>
Is this in your queue or should I rebase and resend?
Thanks,
Sekhar
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Nishanth Menon
maintainerQuoted 7 lines · Sekhar Nori
Hi Nishanth,
Quoted 4 lines · Sekhar Nori
Per errata i2104 documented in AM65x device errata document (TI document number SPRZ452E, revised June 2019), Gen3 operation is not supported for both PCIe Root Complex and Endpoint modes of operation.
Quoted 7 lines
Quoted 5 lines
See: https://www.ti.com/lit/er/sprz452e/sprz452e.pdf
Restrict speed to Gen2 to address the errata.
Signed-off-by Sekhar Nori <[email protected]>Is this in your queue or should I rebase and resend?
Thanks for the reminder. I have put it on my staging branch for now. Once rc3 gets tagged with irqchip related changes, I will move this over to next.
Now, that said, Please consider converting Documentation/devicetree/bindings/pci/pci-keystone.txt to yaml sometime in near future, if possible.
We might also want to spend a little more time with W=2 dtbs build and dtbs_check to cleanup.
Signature · 8 lines
Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
A message that is not in the archive (sent off-list or not yet received): 20200828002426.e7surnodpblgln7h@akan
Quoted 12 lines · Nishanth Menon
Quoted 11 lines · Sekhar Nori
Hi Nishanth,
Quoted 8 lines · Sekhar Nori
Per errata i2104 documented in AM65x device errata document (TI document number SPRZ452E, revised June 2019), Gen3 operation is not supported for both PCIe Root Complex and Endpoint modes of operation.
See: https://www.ti.com/lit/er/sprz452e/sprz452e.pdf
Restrict speed to Gen2 to address the errata.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Sekhar Nori <[email protected]>Is this in your queue or should I rebase and resend?
Thanks for the reminder. I have put it on my staging branch for now. Once rc3 gets tagged with irqchip related changes, I will move this over to next.
Hmm, this is errata fix and fair game for -rc cycle. Can we have this in v5.9 itself?
Quoted 7 lines
Now, that said, Please consider converting
Documentation/devicetree/bindings/pci/pci-keystone.txtto yaml sometime in near future, if possible.We might also want to spend a little more time with W=2 dtbs build and
dtbs_checkto cleanup.
Sure, will add to TODO.
Thanks,
Sekhar
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Nishanth Menon
maintainerQuoted 15 lines · Sekhar Nori
Quoted 14 lines · Nishanth Menon
Quoted 13 lines · Sekhar Nori
Hi Nishanth,
Quoted 9 lines · Sekhar Nori
Per errata i2104 documented in AM65x device errata document (TI document number SPRZ452E, revised June 2019), Gen3 operation is not supported for both PCIe Root Complex and Endpoint modes of operation.
See: https://www.ti.com/lit/er/sprz452e/sprz452e.pdf
Restrict speed to Gen2 to address the errata.
Signed-off-by Sekhar Nori <[email protected]>
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Is this in your queue or should I rebase and resend?
Thanks for the reminder. I have put it on my staging branch for now. Once rc3 gets tagged with irqchip related changes, I will move this over to next.
Hmm, this is errata fix and fair game for -rc cycle. Can we have this in v5.9 itself?
We could, but does'nt seem urgent enough for 5.9 cycle since the dts node was'nt introduced in this cycle, I think it was introduced around 5.3 or so?
Quoted 10 lines
Quoted 8 lines
Now, that said, Please consider converting
Documentation/devicetree/bindings/pci/pci-keystone.txtto yaml sometime in near future, if possible.We might also want to spend a little more time with W=2 dtbs build and
dtbs_checkto cleanup.Sure, will add to TODO.
Thanks.
Signature · 8 lines
Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 22 lines · Nishanth Menon
Quoted 21 lines · Sekhar Nori
Quoted 19 lines · Nishanth Menon
Quoted 7 lines · Sekhar Nori
Hi Nishanth,
Quoted 4 lines · Sekhar Nori
Per errata i2104 documented in AM65x device errata document (TI document number SPRZ452E, revised June 2019), Gen3 operation is not supported for both PCIe Root Complex and Endpoint modes of operation.
Quoted 7 lines
Quoted 5 lines
See: https://www.ti.com/lit/er/sprz452e/sprz452e.pdf
Restrict speed to Gen2 to address the errata.
Signed-off-by Sekhar Nori <[email protected]>Is this in your queue or should I rebase and resend?
Thanks for the reminder. I have put it on my staging branch for now. Once rc3 gets tagged with irqchip related changes, I will move this over to next.
Quoted 6 lines
Quoted 2 lines
Hmm, this is errata fix and fair game for -rc cycle. Can we have this in v5.9 itself?
We could, but does'nt seem urgent enough for 5.9 cycle since the dts node was'nt introduced in this cycle, I think it was introduced around 5.3 or so?
Isn't this too early in -rc cycle to be regressions only?
I can provide a fixes tag if you want to ensure backporting. I felt odd about it because its workaround for hardware issue, nothing wrong in the original commit when it was written.
But if you are uncomfortable, fine :)
Thanks,
Sekhar
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Nishanth Menon
maintainerQuoted 23 lines · Sekhar Nori
Quoted 22 lines · Nishanth Menon
Quoted 21 lines · Sekhar Nori
Quoted 19 lines · Nishanth Menon
Quoted 7 lines · Sekhar Nori
Hi Nishanth,
Quoted 4 lines · Sekhar Nori
Per errata i2104 documented in AM65x device errata document (TI document number SPRZ452E, revised June 2019), Gen3 operation is not supported for both PCIe Root Complex and Endpoint modes of operation.
Quoted 7 lines
Quoted 5 lines
See: https://www.ti.com/lit/er/sprz452e/sprz452e.pdf
Restrict speed to Gen2 to address the errata.
Signed-off-by Sekhar Nori <[email protected]>Is this in your queue or should I rebase and resend?
Thanks for the reminder. I have put it on my staging branch for now. Once rc3 gets tagged with irqchip related changes, I will move this over to next.
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
Hmm, this is errata fix and fair game for -rc cycle. Can we have this in v5.9 itself?
We could, but does'nt seem urgent enough for 5.9 cycle since the dts node was'nt introduced in this cycle, I think it was introduced around 5.3 or so?
Isn't this too early in -rc cycle to be regressions only?
are'nt we in rc3 already.. But anyways..
Quoted 6 lines
I can provide a fixes tag if you want to ensure backporting. I felt odd about it because its workaround for hardware issue, nothing wrong in the original commit when it was written.
But if you are uncomfortable, fine :)
Thanks. yeah, I'd rather do this for 5.10, too much mayhem in 5.9 cycle already. Need to quiet things a bit here.
Signature · 8 lines
Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 7 lines · Sekhar Nori
Per errata i2104 documented in AM65x device errata document (TI document number SPRZ452E, revised June 2019), Gen3 operation is not supported for both PCIe Root Complex and Endpoint modes of operation.
See: https://www.ti.com/lit/er/sprz452e/sprz452e.pdf
Restrict speed to Gen2 to address the errata.
Hi Sekhar Nori,
I have applied the following to branch ti-k3-dts-next on [1]. Thank you!
[1/1] arm64: dts: ti: k3-am65: restrict PCIe to Gen2 speed
commit: 269a5641b1ed0ac00e9d75b43985407b34540d77
[1] git://git.kernel.org/pub/scm/linux/kernel/git/nmenon/linux.git
Signature · 9 lines
Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel