Skip to contentSkip to conversation

ARM: s3c24xx: demote kerneldoc comment

PATCH In review Krzysztof Kozlowski 2 participants 2 messages Aug 2, 2020

Subsystems (3)
lore
Share & tools
lore

Krzysztof Kozlowski

author maintainer
#0 lore raw

PATCH 1/1 ARM: s3c24xx: demote kerneldoc comment

Remove kerneldoc annotation to fix warning:

arch/arm/mach-s3c24xx/mach-h1940.c:185: warning:
cannot understand function prototype: 'struct s3c2410fb_display h1940_lcd __initdata = '

---
 arch/arm/mach-s3c24xx/mach-h1940.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-s3c24xx/mach-h1940.c +2 -2
index 89528bea89f1..c09f61d35d57 100644
@@ -179,9 +179,9 @@ static struct s3c2410_ts_mach_info h1940_ts_cfg __initdata = {
 		.cfg_gpio = s3c24xx_ts_cfg_gpio,
 };
 
-/**
+/*
  * Set lcd on or off
- **/
+ */
 static struct s3c2410fb_display h1940_lcd __initdata = {
 	.lcdcon5=	S3C2410_LCDCON5_FRM565 | \
 			S3C2410_LCDCON5_INVVLINE | \
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 15 lines · Krzysztof Kozlowski

Remove kerneldoc annotation to fix warning:

arch/arm/mach-s3c24xx/mach-h1940.c:185: warning:
cannot understand function prototype: 'struct s3c2410fb_display h1940_lcd __initdata = '

---
 arch/arm/mach-s3c24xx/mach-h1940.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-s3c24xx/mach-h1940.c +0 -0
index 89528bea89f1..c09f61d35d57 100644

arch/arm/mach-s3c24xx/mach-h1940.c static struct s3c2410_ts_mach_info h1940_ts_cfg __initdata = { · line 184

Quoted 8 lines
arch/arm/mach-s3c24xx/mach-h1940.c +2 -2
@@ -179,9 +179,9 @@ static struct s3c2410_ts_mach_info h1940_ts_cfg __initdata = {
 		.cfg_gpio = s3c24xx_ts_cfg_gpio,
 };
 
-/**
+/*
  * Set lcd on or off
- **/
+ */

Yes, that's not kernel-doc notation, so demote it.

OTOH, we could also add "__initdata" to something that can be handled by scripts/kernel-doc if it's needed, but it doesn't seem to be needed just yet.

arch/arm/mach-s3c24xx/mach-h1940.c static struct s3c2410_ts_mach_info h1940_ts_cfg __initdata = { · line 187

Quoted 4 lines
arch/arm/mach-s3c24xx/mach-h1940.c +0 -0
 static struct s3c2410fb_display h1940_lcd __initdata = {
 	.lcdcon5=	S3C2410_LCDCON5_FRM565 | \
 			S3C2410_LCDCON5_INVVLINE | \

thanks.

Signature · 1 line
~Randy