Skip to contentSkip to conversation

tests/Makefile: test-image-locking needs CONFIG_POSIX

PATCH In review Thomas Huth 2 participants 2 messages Aug 3, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/Makefile: test-image-locking needs CONFIG_POSIX

test-image-locking.c uses the qemu_lock_fd_test() function which is only available on Posix-like systems.

---
 tests/Makefile.include | 2 ++
 1 file changed, 2 insertions(+)
tests/Makefile.include +2 -0
index 5ff731be2b..430119db74 100644
@@ -87,7 +87,9 @@ check-unit-$(CONFIG_BLOCK) += tests/test-blockjob$(EXESUF)
 check-unit-$(CONFIG_BLOCK) += tests/test-blockjob-txn$(EXESUF)
 check-unit-$(CONFIG_BLOCK) += tests/test-block-backend$(EXESUF)
 check-unit-$(CONFIG_BLOCK) += tests/test-block-iothread$(EXESUF)
+ifeq ($(CONFIG_POSIX),y)
 check-unit-$(CONFIG_BLOCK) += tests/test-image-locking$(EXESUF)
+endif
 check-unit-y += tests/test-x86-cpuid$(EXESUF)
 # all code tested by test-x86-cpuid is inside topology.h
 ifeq ($(CONFIG_SOFTMMU),y)
Signature · 1 line
2.18.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Thomas Huth

test-image-locking.c uses the qemu_lock_fd_test() function which is only available on Posix-like systems.

Quoted 19 lines
---
  tests/Makefile.include | 2 ++
  1 file changed, 2 insertions(+)
tests/Makefile.include +2 -0
index 5ff731be2b..430119db74 100644
@@ -87,7 +87,9 @@ check-unit-$(CONFIG_BLOCK) += tests/test-blockjob$(EXESUF)
  check-unit-$(CONFIG_BLOCK) += tests/test-blockjob-txn$(EXESUF)
  check-unit-$(CONFIG_BLOCK) += tests/test-block-backend$(EXESUF)
  check-unit-$(CONFIG_BLOCK) += tests/test-block-iothread$(EXESUF)
+ifeq ($(CONFIG_POSIX),y)
  check-unit-$(CONFIG_BLOCK) += tests/test-image-locking$(EXESUF)
+endif
  check-unit-y += tests/test-x86-cpuid$(EXESUF)
  # all code tested by test-x86-cpuid is inside topology.h
  ifeq ($(CONFIG_SOFTMMU),y)