Skip to contentSkip to conversation

powerpc/powernv/sriov: Fix use of uninitialised variable

PATCH Applied Oliver O'Halloran 2 participants 2 messages Aug 3, 2020 – Aug 5, 2020 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/powernv/sriov: Fix use of uninitialised variable

Initialising the value before using it is generally regarded as a good idea so do that.

Fixes 4c51f3e1e870 ("powerpc/powernv/sriov: Make single PE mode a per-BAR setting")
---
 arch/powerpc/platforms/powernv/pci-sriov.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
arch/powerpc/platforms/powernv/pci-sriov.c +1 -3
index 7894745fd4f8..c4434f20f42f 100644
@@ -253,9 +253,9 @@ void pnv_pci_ioda_fixup_iov(struct pci_dev *pdev)
 resource_size_t pnv_pci_iov_resource_alignment(struct pci_dev *pdev,
 						      int resno)
 {
+	resource_size_t align = pci_iov_resource_size(pdev, resno);
 	struct pnv_phb *phb = pci_bus_to_pnvhb(pdev->bus);
 	struct pnv_iov_data *iov = pnv_iov_get(pdev);
-	resource_size_t align;
 
 	/*
 	 * iov can be null if we have an SR-IOV device with IOV BAR that can't
@@ -266,8 +266,6 @@ resource_size_t pnv_pci_iov_resource_alignment(struct pci_dev *pdev,
 	if (!iov)
 		return align;
 
-	align = pci_iov_resource_size(pdev, resno);
-
 	/*
 	 * If we're using single mode then we can just use the native VF BAR
 	 * alignment. We validated that it's possible to use a single PE
Signature · 1 line
2.26.2