net/mlx5: remove erroneous fallthrough
Subsystems (6)
PATCH 1/1 net/mlx5: remove erroneous fallthrough
This isn't a fall through because it was after a return statement. The fall through annotation leads to a Smatch warning:
drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c:246 mlx5e_ethtool_get_sset_count() warn: ignoring unreachable code.
--- drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 1 - 1 file changed, 1 deletion(-)
drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c +0 -1
@@ -243,7 +243,6 @@ int mlx5e_ethtool_get_sset_count(struct mlx5e_priv *priv, int sset)return MLX5E_NUM_PFLAGS ;case ETH_SS_TEST :return mlx5e_self_test_num (priv); - fallthrough;default :return -EOPNOTSUPP ; }
Signature · 1 line
2.27.0
Quoted 7 lines · Dan Carpenter
This isn't a fall through because it was after a return statement. The fall through annotation leads to a Smatch warning:
drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c:246mlx5e_ethtool_get_sset_count()warn: ignoring unreachable code.Signed-off-by Dan Carpenter <[email protected]>
Thanks
--
Gustavo
Quoted 19 lines
--- drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 1 - 1 file changed, 1 deletion(-)drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c +0
-1@@ -243,7 +243,6 @@ int mlx5e_ethtool_get_sset_count(struct mlx5e_priv *priv, int sset)return MLX5E_NUM_PFLAGS ;case ETH_SS_TEST :return mlx5e_self_test_num (priv); - fallthrough;default :return -EOPNOTSUPP ; }Signature · 1 line
2.27.0
Saeed Mahameed
maintainerT24gTW9uLCAyMDIwLTA4LTAzIGF0IDEwOjQ4IC0wNTAwLCBHdXN0YXZvIEEuIFIuIFNpbHZhIHdy b3RlOg0KPiBPbiBNb24sIEF1ZyAwMywgMjAyMCBhdCAwNTozNDo0OFBNICswMzAwLCBEYW4gQ2Fy cGVudGVyIHdyb3RlOg0KPiA+IFRoaXMgaXNuJ3QgYSBmYWxsIHRocm91Z2ggYmVjYXVzZSBpdCB3 YXMgYWZ0ZXIgYSByZXR1cm4NCj4gPiBzdGF0ZW1lbnQuICBUaGUNCj4gPiBmYWxsIHRocm91Z2gg YW5ub3RhdGlvbiBsZWFkcyB0byBhIFNtYXRjaCB3YXJuaW5nOg0KPiA+IA0KPiA+ICAgICBkcml2 ZXJzL25ldC9ldGhlcm5ldC9tZWxsYW5veC9tbHg1L2NvcmUvZW5fZXRodG9vbC5jOjI0Ng0KPiA+ ICAgICBtbHg1ZV9ldGh0b29sX2dldF9zc2V0X2NvdW50KCkgd2FybjogaWdub3JpbmcgdW5yZWFj aGFibGUgY29kZS4NCj4gPiANCj4gPiBTaWduZWQtb2ZmLWJ5OiBEYW4gQ2FycGVudGVyIDxkYW4u Y2FycGVudGVyQG9yYWNsZS5jb20+DQo+IA0KPiBSZXZpZXdlZC1ieTogR3VzdGF2byBBLiBSLiBT aWx2YSA8Z3VzdGF2b2Fyc0BrZXJuZWwub3JnPg0KPiANCg0KQXBwbGllZCB0byBuZXQtbmV4dC1t bHg1DQoNClRoYW5rcyENCg=