drm/amd/dc: Read from DP_SINK_COUNT_ESI for DPDC r1.2 or higher
Subsystems (3)
PATCH 1/1 drm/amd/dc: Read from DP_SINK_COUNT_ESI for DPDC r1.2 or higher
[Why]
According to DP spec, DPRX with DPCD r1.2 or higher shall have the same Link/Sink Device Status field registers at DPCD Addresses 00200h through 00205h to the corresponding DPRX Event Status Indicator registers at DPCD Addresses 02002h through 0200Fh. We now only read from 02002h when DPCD revision number is r1.4 or higher while handling short HPD. Need to correct that.
[How]
Set to read from 02002h when DPCD is r1.2 or higher
--- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +2 -2
@@ -1834,9 +1834,9 @@ static enum dc_status read_hpd_rx_irq_data(* fail, so we now explicitly read 6 bytes which is * the req from the above mentioned test cases. * -* For DP 1.4 we need to read those from 2002h range. +* For DPCD r1.2 or higher, we need to read those from 2002h range. */ -if (link->dpcd_caps.dpcd_rev.raw <DPCD_REV_14 ) +if (link->dpcd_caps.dpcd_rev.raw <DPCD_REV_12 ) retval = core_link_read_dpcd( link, DP_SINK_COUNT,
Signature · 6 lines
2.17.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 32 lines · Wayne Lin
[Why]
According to DP spec, DPRX with DPCD r1.2 or higher shall have the same Link/Sink Device Status field registers at DPCD Addresses 00200h through 00205h to the corresponding DPRX Event Status Indicator registers at DPCD Addresses 02002h through 0200Fh. We now only read from
02002h when DPCD revision number is r1.4 or higher while handling short
HPD. Need to correct that.[How]
Set to read from 02002h when DPCD is r1.2 or higherSigned-off-by: Wayne Lin <
[email protected]Quoted 1 line
--- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +1
-1@@ -1834,9 +1834,9 @@ static enum dc_status read_hpd_rx_irq_data(* fail, so we now explicitly read 6 bytes which is * the req from the above mentioned test cases. * -* For DP 1.4 we need to read those from 2002h range. +* For DPCD r1.2 or higher, we need to read those from 2002h range.
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c static enum dc_status read_hpd_rx_irq_data( · line 1842
Quoted 6 lines
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +1
-1*/ -if (link->dpcd_caps.dpcd_rev.raw <DPCD_REV_14 ) +if (link->dpcd_caps.dpcd_rev.raw <DPCD_REV_12 ) retval = core_link_read_dpcd( link, DP_SINK_COUNT,
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Wu, Hersen
Reviewed-by Aurabindo Pillai[AMD Official Use Only - Internal Distribution Only]
-----Original Message-----
From: Pillai, Aurabindo <[email protected]>
Sent: Tuesday, August 4, 2020 9:56 AM
To: Lin, Wayne <[email protected]>; [email protected]
Cc: Wu, Hersen <[email protected]>; Kazlauskas, Nicholas <[email protected]>; Siqueira, Rodrigo <[email protected]>; Zuo, Jerry <[email protected]>
Subject: Re: [PATCH] drm/amd/dc: Read from DP_SINK_COUNT_ESI for DPDC r1.2 or higher
Quoted 30 lines · Wayne Lin
[Why]
According to DP spec, DPRX with DPCD r1.2 or higher shall have the same Link/Sink Device Status field registers at DPCD Addresses 00200h through 00205h to the corresponding DPRX Event Status Indicator registers at DPCD Addresses 02002h through 0200Fh. We now only read from 02002h when DPCD revision number is r1.4 or higher while handling short HPD. Need to correct that.[How]
Set to read from 02002h when DPCD is r1.2 or higherSigned-off-by: Wayne Lin <
[email protected]Quoted 1 line
--- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +1
-1@@ -1834,9 +1834,9 @@ static enum dc_status read_hpd_rx_irq_data(* fail, so we now explicitly read 6 bytes which is * the req from the above mentioned test cases. * -* For DP 1.4 we need to read those from 2002h range. +* For DPCD r1.2 or higher, we need to read those from 2002h range.
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c static enum dc_status read_hpd_rx_irq_data( · line 1842
Quoted 6 lines
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +1
-1*/ -if (link->dpcd_caps.dpcd_rev.raw <DPCD_REV_14 ) +if (link->dpcd_caps.dpcd_rev.raw <DPCD_REV_12 ) retval = core_link_read_dpcd( link, DP_SINK_COUNT,
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx