Skip to contentSkip to conversation

doc: announce PCI resources map API removal

PATCH Applied David Marchand 4 participants 4 messages Aug 4, 2020 – Aug 5, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 doc: announce PCI resources map API removal

The PCI resources map API (pci_map_resource/pci_unmap_resource) was imposing use of Unix mmap flags while it does not make sense on Windows. This API was only used to internally setup PCI devices in the PCI bus driver and has no known external users.

Announce its removal in 20.11 with its associated structures.

The workaround implemented in the commit 9d2b24593724 ("pci: keep API compatibility with mmap values") will be removed at the same time.

---
 doc/guides/rel_notes/deprecation.rst | 11 +++++++++++
 1 file changed, 11 insertions(+)
doc/guides/rel_notes/deprecation.rst +11 -0
index ea4cfa7a48..24808c002c 100644
@@ -67,6 +67,17 @@ Deprecation Notices
   us extending existing enum/define.
   One solution can be using a fixed size array instead of ``.*MAX.*`` value.
 
+* pci: The PCI resources map API (``pci_map_resource`` and
+  ``pci_unmap_resource``) was not abstracting the Unix mmap flags (see the
+  workaround for Windows support implemented in the commit
+  9d2b24593724 ("pci: keep API compatibility with mmap values")).
+  This API will be removed from the public API in 20.11 and moved to the PCI
+  bus driver along with the PCI resources lists and associated structures
+  (``pci_map``, ``pci_msix_table``, ``mapped_pci_resource`` and
+  ``mapped_pci_res_list``).
+  With this removal, there won't be a need for the mentioned workaround which
+  will be reverted.
+
 * ethdev: Split the ``struct eth_dev_ops`` struct to hide it as much as possible
   will be done in 20.11.
   Currently the ``struct eth_dev_ops`` struct is accessible by the application
Signature · 1 line
2.23.0
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · David Marchand

The PCI resources map API (pci_map_resource/pci_unmap_resource) was imposing use of Unix mmap flags while it does not make sense on Windows. This API was only used to internally setup PCI devices in the PCI bus driver and has no known external users.

Quoted 6 lines

Announce its removal in 20.11 with its associated structures.

The workaround implemented in the commit 9d2b24593724 ("pci: keep API compatibility with mmap values") will be removed at the same time.

Quoted 29 lines
---
 doc/guides/rel_notes/deprecation.rst | 11 +++++++++++
 1 file changed, 11 insertions(+)
doc/guides/rel_notes/deprecation.rst +11 -1
index ea4cfa7a48..24808c002c 100644
@@ -67,6 +67,17 @@ Deprecation Notices
   us extending existing enum/define.
   One solution can be using a fixed size array instead of ``.*MAX.*`` value.
 
+* pci: The PCI resources map API (``pci_map_resource`` and
+  ``pci_unmap_resource``) was not abstracting the Unix mmap flags (see the
+  workaround for Windows support implemented in the commit
+  9d2b24593724 ("pci: keep API compatibility with mmap values")).
+  This API will be removed from the public API in 20.11 and moved to the PCI
+  bus driver along with the PCI resources lists and associated structures
+  (``pci_map``, ``pci_msix_table``, ``mapped_pci_resource`` and
+  ``mapped_pci_res_list``).
+  With this removal, there won't be a need for the mentioned workaround which
+  will be reverted.
+
 * ethdev: Split the ``struct eth_dev_ops`` struct to hide it as much as possible
   will be done in 20.11.
   Currently the ``struct eth_dev_ops`` struct is accessible by the application
--

2.23.0

Acked-by
#2 lore raw
Quoted 7 lines · Jerin Jacob
Quoted 6 lines · David Marchand

The PCI resources map API (pci_map_resource/pci_unmap_resource) was imposing use of Unix mmap flags while it does not make sense on Windows. This API was only used to internally setup PCI devices in the PCI bus driver and has no known external users.

Quoted 9 lines
Quoted 6 lines

Announce its removal in 20.11 with its associated structures.

The workaround implemented in the commit 9d2b24593724 ("pci: keep API compatibility with mmap values") will be removed at the same time.

Quoted 30 lines
Quoted 30 lines
---
 doc/guides/rel_notes/deprecation.rst | 11 +++++++++++
 1 file changed, 11 insertions(+)
doc/guides/rel_notes/deprecation.rst +11 -1
index ea4cfa7a48..24808c002c 100644
@@ -67,6 +67,17 @@ Deprecation Notices
   us extending existing enum/define.
   One solution can be using a fixed size array instead of ``.*MAX.*`` value.
 
+* pci: The PCI resources map API (``pci_map_resource`` and
+  ``pci_unmap_resource``) was not abstracting the Unix mmap flags (see the
+  workaround for Windows support implemented in the commit
+  9d2b24593724 ("pci: keep API compatibility with mmap values")).
+  This API will be removed from the public API in 20.11 and moved to the PCI
+  bus driver along with the PCI resources lists and associated structures
+  (``pci_map``, ``pci_msix_table``, ``mapped_pci_resource`` and
+  ``mapped_pci_res_list``).
+  With this removal, there won't be a need for the mentioned workaround which
+  will be reverted.
+
 * ethdev: Split the ``struct eth_dev_ops`` struct to hide it as much as possible
   will be done in 20.11.
   Currently the ``struct eth_dev_ops`` struct is accessible by the application
--

2.23.0

Signature · 1 line
Gaëtan
Acked-by Applied
#3 lore raw

04/08/2020 13:20, Gaëtan Rivet:

Quoted 8 lines · Jerin Jacob
Quoted 7 lines · David Marchand
Quoted 6 lines

The PCI resources map API (pci_map_resource/pci_unmap_resource) was imposing use of Unix mmap flags while it does not make sense on Windows. This API was only used to internally setup PCI devices in the PCI bus driver and has no known external users.

Quoted 8 lines
Quoted 7 lines
Quoted 6 lines

Announce its removal in 20.11 with its associated structures.

The workaround implemented in the commit 9d2b24593724 ("pci: keep API compatibility with mmap values") will be removed at the same time.

Applied, thanks