Skip to contentSkip to conversation

staging: wfx: fixed misspelled word in comment

PATCH In review Aditya Bansal 4 participants 7 messages Aug 4, 2020 – Aug 18, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: wfx: fixed misspelled word in comment

From: Aditya Bansal <[email protected]>

Subject: [PATCH] fixed typo in driver/staging/wfx/hif_tx.c file

Correct the spelling of function

---

drivers/staging/wfx/hif_tx.c +1 -1
index 5110f9b93762..6a485fa5b72b 100644
@@ -125,7 +125,7 @@ int wfx_cmd_send(struct wfx_dev *wdev, struct hif_msg *request,
 
 // This function is special. After HIF_REQ_ID_SHUT_DOWN, chip won't reply to any
 // request anymore. We need to slightly hack struct wfx_hif_cmd for that job. Be
-// carefull to only call this funcion during device unregister.
+// carefull to only call this function during device unregister.
 int hif_shutdown(struct wfx_dev *wdev)
 {
 	int ret;
#1 lore raw
Quoted 14 lines · Aditya Bansal

From: Aditya Bansal <[email protected]>

Subject: [PATCH] fixed typo in driver/staging/wfx/hif_tx.c file

Correct the spelling of function

---

drivers/staging/wfx/hif_tx.c +0 -0
index 5110f9b93762..6a485fa5b72b 100644

drivers/staging/wfx/hif_tx.c int wfx_cmd_send(struct wfx_dev *wdev, struct hif_msg *request, · line 128

Quoted 5 lines
drivers/staging/wfx/hif_tx.c +1 -1
@@ -125,7 +125,7 @@ int wfx_cmd_send(struct wfx_dev *wdev, struct hif_msg *request,
 
 // This function is special. After HIF_REQ_ID_SHUT_DOWN, chip won't reply to any
 // request anymore. We need to slightly hack struct wfx_hif_cmd for that job. Be
-// carefull to only call this funcion during device unregister.
+// carefull to only call this function during device unregister.

careful

Quoted 3 lines
drivers/staging/wfx/hif_tx.c +0 -0
 int hif_shutdown(struct wfx_dev *wdev)
 {
 	int ret;
Signature · 1 line
~Randy
#2 lore raw
Quoted 16 lines · Randy Dunlap
Quoted 15 lines · Aditya Bansal

From: Aditya Bansal <[email protected]>

Subject: [PATCH] fixed typo in driver/staging/wfx/hif_tx.c file

Correct the spelling of function

---

drivers/staging/wfx/hif_tx.c +0 -0
index 5110f9b93762..6a485fa5b72b 100644
@@ -125,7 +125,7 @@ int wfx_cmd_send(struct wfx_dev *wdev, struct hif_msg *request,
 
Quoted 6 lines

drivers/staging/wfx/hif_tx.c int wfx_cmd_send(struct wfx_dev *wdev, struct hif_msg *request, · line 128

Quoted 4 lines
drivers/staging/wfx/hif_tx.c +1 -1
 // This function is special. After HIF_REQ_ID_SHUT_DOWN, chip won't reply to any
 // request anymore. We need to slightly hack struct wfx_hif_cmd for that job. Be
-// carefull to only call this funcion during device unregister.
+// carefull to only call this function during device unregister.

careful

And if you could do all of them:

$ git grep -w -i -n carefull
arch/m68k/coldfire/pci.c:34: * We need to be carefull probing on bus 0 (directly connected to host
arch/openrisc/kernel/head.S:289: *       a bit more carefull (if we have a PT_SP or current pointer
drivers/staging/wfx/debug.c:302:	// Be carefull, write() is waiting for a full message while read()
drivers/staging/wfx/hif_tx.c:128:// carefull to only call this funcion during device unregister.
fs/ceph/inode.c:1475:		/* parent inode is not locked, be carefull */
#3 lore raw

Should I correct all the instances of the "careful" and submit the patch including both "carefull" and "function" word correct? or only for the "carefull"? I have already submitted one for the "funcion" word.

Quoted 36 lines · Joe Perches
Quoted 16 lines · Randy Dunlap
Quoted 15 lines · Aditya Bansal

From: Aditya Bansal <[email protected]>

Subject: [PATCH] fixed typo in driver/staging/wfx/hif_tx.c file

Correct the spelling of function

---

drivers/staging/wfx/hif_tx.c +0 -0
index 5110f9b93762..6a485fa5b72b 100644
@@ -125,7 +125,7 @@ int wfx_cmd_send(struct wfx_dev *wdev, struct hif_msg *request,
 
Quoted 6 lines

drivers/staging/wfx/hif_tx.c int wfx_cmd_send(struct wfx_dev *wdev, struct hif_msg *request, · line 128

Quoted 4 lines
drivers/staging/wfx/hif_tx.c +1 -1
 // This function is special. After HIF_REQ_ID_SHUT_DOWN, chip won't reply to any
 // request anymore. We need to slightly hack struct wfx_hif_cmd for that job. Be
-// carefull to only call this funcion during device unregister.
+// carefull to only call this function during device unregister.

careful

And if you could do all of them:

$ git grep -w -i -n carefull
arch/m68k/coldfire/pci.c:34: * We need to be carefull probing on bus 0 (directly connected to host
arch/openrisc/kernel/head.S:289: *       a bit more carefull (if we have a PT_SP or current pointer
drivers/staging/wfx/debug.c:302:        // Be carefull, write() is waiting for a full message while read()
drivers/staging/wfx/hif_tx.c:128:// carefull to only call this funcion during device unregister.
fs/ceph/inode.c:1475:           /* parent inode is not locked, be carefull */
#4 lore raw
Quoted 4 lines · Aditya Bansal

Should I correct all the instances of the "careful" and submit the patch including both "carefull" and "function" word correct? or only for the "carefull"? I have already submitted one for the "funcion" word.

I suggest submitting a V2 patch with both fixes.

Generally it's better to submit all spelling fixes in a single file at once, especially when multiple spelling fixes are on the same line.

Also, it's generally better to submit separate patches for individual files.

#5 lore raw
In reply to Aditya Bansal

From: Aditya Bansal <[email protected]>

Subject: [PATCH v2] fixed typo in driver/staging/wfx/hif_tx.c file

Correct the spelling of word function and careful

---

drivers/staging/wfx/hif_tx.c +1 -1
index 5110f9b93762..fc12f9dcefce 100644
@@ -125,7 +125,7 @@ int wfx_cmd_send(struct wfx_dev *wdev, struct hif_msg *request,
 
 // This function is special. After HIF_REQ_ID_SHUT_DOWN, chip won't reply to any
 // request anymore. We need to slightly hack struct wfx_hif_cmd for that job. Be
-// carefull to only call this funcion during device unregister.
+// careful to only call this function during device unregister.
 int hif_shutdown(struct wfx_dev *wdev)
 {
        int ret;
maintainer
#6 lore raw
Quoted 22 lines · Aditya Bansal

From: Aditya Bansal <[email protected]>

Subject: [PATCH v2] fixed typo in driver/staging/wfx/hif_tx.c file

Correct the spelling of word function and careful

---

drivers/staging/wfx/hif_tx.c +1 -1
index 5110f9b93762..fc12f9dcefce 100644
@@ -125,7 +125,7 @@ int wfx_cmd_send(struct wfx_dev *wdev, struct hif_msg *request,
 
 // This function is special. After HIF_REQ_ID_SHUT_DOWN, chip won't reply to any
 // request anymore. We need to slightly hack struct wfx_hif_cmd for that job. Be
-// carefull to only call this funcion during device unregister.
+// careful to only call this function during device unregister.
 int hif_shutdown(struct wfx_dev *wdev)
 {
        int ret;
Quoted 4 lines

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Does not apply to my tree, can you please refresh and resend?

thanks,

greg k-h