Skip to contentSkip to conversation

soc: fsl: qe: Remove unnessesary check in ucc_set_tdm_rxtx_clk

PATCH In review Wang Hai 2 participants 2 messages Aug 4, 2020 – Sep 22, 2020

Subsystems (2)
lore
Share & tools
lore

Wang Hai

author
#0 lore raw

PATCH 1/1 soc: fsl: qe: Remove unnessesary check in ucc_set_tdm_rxtx_clk

Fix smatch warning:

drivers/soc/fsl/qe/ucc.c:526
ucc_set_tdm_rxtx_clk() warn: unsigned 'tdm_num' is never less than zero.

'tdm_num' is u32 type, never less than zero.

---
 drivers/soc/fsl/qe/ucc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/fsl/qe/ucc.c +1 -1
index cac0fb7693a0..21dbcd787cd5 100644
@@ -523,7 +523,7 @@ int ucc_set_tdm_rxtx_clk(u32 tdm_num, enum qe_clock clock,
 
 	qe_mux_reg = &qe_immr->qmx;
 
-	if (tdm_num > 7 || tdm_num < 0)
+	if (tdm_num > 7)
 		return -EINVAL;
 
 	/* The communications direction must be RX or TX */
Signature · 1 line
2.17.1
#1 lore raw
Quoted 9 lines · Wang Hai

Fix smatch warning:

drivers/soc/fsl/qe/ucc.c:526
ucc_set_tdm_rxtx_clk() warn: unsigned 'tdm_num' is never less than zero.

'tdm_num' is u32 type, never less than zero.

Applied for next. Thanks.

Quoted 20 lines
---
 drivers/soc/fsl/qe/ucc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/fsl/qe/ucc.c +1 -2
index cac0fb7693a0..21dbcd787cd5 100644
@@ -523,7 +523,7 @@ int ucc_set_tdm_rxtx_clk(u32 tdm_num, enum qe_clock clock,
 
        qe_mux_reg = &qe_immr->qmx;
 
-       if (tdm_num > 7 || tdm_num < 0)
+       if (tdm_num > 7)
                return -EINVAL;
 
        /* The communications direction must be RX or TX */
--

2.17.1