Skip to contentSkip to conversation

doc: announce kernel driver enum removal

PATCH Applied David Marchand 4 participants 4 messages Aug 4, 2020 – Aug 5, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 doc: announce kernel driver enum removal

rte_kernel_driver is only used by the PCI subsystem and has polluted ethdev for no reason.
Hide it in the PCI bus driver.

---
 doc/guides/rel_notes/deprecation.rst | 7 +++++++
 1 file changed, 7 insertions(+)
doc/guides/rel_notes/deprecation.rst +7 -0
index 9f73297173..6e86963c39 100644
@@ -81,6 +81,13 @@ Deprecation Notices
   With this removal, there won't be a need for the mentioned workaround which
   will be reverted.
 
+* pci: The ``rte_kernel_driver`` enum defined in rte_dev.h will be made private
+  to the PCI subsystem as it is used only by the PCI bus driver and PCI
+  drivers.
+  The associated field ``kdrv`` in the ethdev ``rte_eth_dev_data`` structure
+  will be removed as it gave no useful abstracted information to the
+  applications and had no user (neither internal nor external).
+
 * ethdev: Split the ``struct eth_dev_ops`` struct to hide it as much as possible
   will be done in 20.11.
   Currently the ``struct eth_dev_ops`` struct is accessible by the application
Signature · 1 line
2.23.0
Acked-by on v1 1/1
#1 lore raw
Quoted 18 lines · David Marchand

rte_kernel_driver is only used by the PCI subsystem and has polluted ethdev for no reason.
Hide it in the PCI bus driver.

---
 doc/guides/rel_notes/deprecation.rst | 7 +++++++
 1 file changed, 7 insertions(+)
doc/guides/rel_notes/deprecation.rst +0 -0
index 9f73297173..6e86963c39 100644
@@ -81,6 +81,13 @@ Deprecation Notices
   With this removal, there won't be a need for the mentioned workaround which
   will be reverted.
 

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 93

Quoted 10 lines
doc/guides/rel_notes/deprecation.rst +7 -0
+* pci: The ``rte_kernel_driver`` enum defined in rte_dev.h will be made private
+  to the PCI subsystem as it is used only by the PCI bus driver and PCI
+  drivers.
+  The associated field ``kdrv`` in the ethdev ``rte_eth_dev_data`` structure
+  will be removed as it gave no useful abstracted information to the
+  applications and had no user (neither internal nor external).
+
 * ethdev: Split the ``struct eth_dev_ops`` struct to hide it as much as possible
   will be done in 20.11.
   Currently the ``struct eth_dev_ops`` struct is accessible by the application
Acked-by
#2 lore raw
Quoted 18 lines · Bruce Richardson
Quoted 17 lines · David Marchand

rte_kernel_driver is only used by the PCI subsystem and has polluted ethdev for no reason.
Hide it in the PCI bus driver.

---
 doc/guides/rel_notes/deprecation.rst | 7 +++++++
 1 file changed, 7 insertions(+)
doc/guides/rel_notes/deprecation.rst +0 -0
index 9f73297173..6e86963c39 100644
@@ -81,6 +81,13 @@ Deprecation Notices
   With this removal, there won't be a need for the mentioned workaround which
   will be reverted.
 
Quoted 13 lines

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 93

Quoted 11 lines
doc/guides/rel_notes/deprecation.rst +7 -0
+* pci: The ``rte_kernel_driver`` enum defined in rte_dev.h will be made private
+  to the PCI subsystem as it is used only by the PCI bus driver and PCI
+  drivers.
+  The associated field ``kdrv`` in the ethdev ``rte_eth_dev_data`` structure
+  will be removed as it gave no useful abstracted information to the
+  applications and had no user (neither internal nor external).
+
 * ethdev: Split the ``struct eth_dev_ops`` struct to hide it as much as possible
   will be done in 20.11.
   Currently the ``struct eth_dev_ops`` struct is accessible by the application
Signature · 1 line
Gaëtan
Acked-by Applied
#3 lore raw

04/08/2020 16:44, Gaëtan Rivet:

Quoted 18 lines · Bruce Richardson
Quoted 5 lines · David Marchand
Quoted 4 lines

rte_kernel_driver is only used by the PCI subsystem and has polluted ethdev for no reason.
Hide it in the PCI bus driver.

Quoted 12 lines

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 89

Quoted 10 lines

---

doc/guides/rel_notes/deprecation.rst +6 -0
+* pci: The ``rte_kernel_driver`` enum defined in rte_dev.h will be made private
+  to the PCI subsystem as it is used only by the PCI bus driver and PCI
+  drivers.
+  The associated field ``kdrv`` in the ethdev ``rte_eth_dev_data`` structure
+  will be removed as it gave no useful abstracted information to the
+  applications and had no user (neither internal nor external).
Quoted 1 line

Applied, thanks