firmware: dmi-sysfs: Add clean-up operations to fix refcount leak
PATCH 1/1 firmware: dmi-sysfs: Add clean-up operations to fix refcount leak
According to the documentation of function kobject_init_and_add(), when this function returns an error, kobject_put() must be called to properly clean up the memory associated with the object.
Fixes 925a1da7477f ("firmware: Break out system_event_log in dmi-sysfs")
Signed-off-by James Bond <[email protected]>
--- drivers/firmware/dmi-sysfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/firmware/dmi-sysfs.c +3 -1
@@ -457,8 +457,10 @@ static int dmi_system_event_log(struct dmi_sysfs_entry *entry) &dmi_system_event_log_ktype, &entry->kobj, "system_event_log"); -if (ret) +if (ret) { +kobject_put (entry->child); goto out_free; + } ret =sysfs_create_bin_file (entry->child, &dmi_sel_raw_attr);if (ret)
Signature · 1 line
2.17.1