Skip to contentSkip to conversation

io_uring: Fix use-after-free in io_sq_wq_submit_work()

PATCH In review Guoyu Huang 2 participants 2 messages Aug 5, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 io_uring: Fix use-after-free in io_sq_wq_submit_work()

when ctx->sqo_mm is zero, io_sq_wq_submit_work() frees 'req' without deleting it from 'task_list'. After that, 'req' is accessed in io_ring_ctx_wait_and_kill() which lead to a use-after-free.

---
 fs/io_uring.c | 1 +
 1 file changed, 1 insertion(+)
fs/io_uring.c +1 -0
index e0200406765c..4b5ac381c67f 100644
@@ -2242,6 +2242,7 @@ static void io_sq_wq_submit_work(struct work_struct *work)
 		if (io_sqe_needs_user(sqe) && !cur_mm) {
 			if (!mmget_not_zero(ctx->sqo_mm)) {
 				ret = -EFAULT;
+				goto end_req;
 			} else {
 				cur_mm = ctx->sqo_mm;
 				use_mm(cur_mm);

--
2.25.1

maintainer
#1 lore raw
Quoted 4 lines · Guoyu Huang

when ctx->sqo_mm is zero, io_sq_wq_submit_work() frees 'req' without deleting it from 'task_list'. After that, 'req' is accessed in io_ring_ctx_wait_and_kill() which lead to a use-after-free.

This looks like an old one, that affects 5.4 only. I've massaged it to apply on top of another fix, will ask to get it queued up for stable. Thanks!

Signature · 1 line
Jens Axboe