Skip to contentSkip to conversation

libunwind: Use -fcommon option to compile

PATCH In review Khem Raj 2 participants 4 messages Aug 5, 2020

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/2 libunwind: Use -fcommon option to compile

defaults for gcc is to use -fno-common this ensures that it keeps using -fcommon until the real issue is fixed

Fixes
src/arm/Ginit.c:60: multiple definition of `_U_dyn_info_list'; mi/.libs/dyn-info-list.o:/usr/src/debug/libunwind/1.4.0-r0/build/src/../../libunwind-1.4.0/src/mi/dyn-info-list.c:28: first defined here

---
 meta/recipes-support/libunwind/libunwind_1.4.0.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-support/libunwind/libunwind_1.4.0.bb +2 -0
index 34c2249e91..a0bfec90b5 100644
@@ -23,3 +23,5 @@ ARM_INSTRUCTION_SET_armv5 = "arm"
 LDFLAGS += "-Wl,-z,relro,-z,now ${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', ' -fuse-ld=bfd ', '', d)}"
 
 SECURITY_LDFLAGS_append_libc-musl = " -lssp_nonshared"
+
+CFLAGS += "-fcommon"
Signature · 1 line
2.28.0
author
#1 lore raw

PATCH 2/2 dhcp: Use -fcommon compiler option

This ensures -fcommon is still used when compiler defaults to -fno-common in gcc10 and clang11

Fixes
dhcp-4.4.2/server/mdb.c:70: multiple definition of `dhcp_type_host'; dhcpd-omapi.o:/usr/src/debug/dhcp/4.4.2-r0/dhcp-4.4.2/server/omapi.c:50: first defined here

---
 meta/recipes-connectivity/dhcp/dhcp_4.4.2.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-connectivity/dhcp/dhcp_4.4.2.bb +2 -0
index b56a204821..cf4af82609 100644
@@ -19,3 +19,5 @@ LDFLAGS_append = " -pthread"
 
 PACKAGECONFIG ?= ""
 PACKAGECONFIG[bind-httpstats] = "--with-libxml2,--without-libxml2,libxml2"
+
+CFLAGS += "-fcommon"
Signature · 1 line
2.28.0
#2 lore raw
In reply to Khem Raj
Quoted 6 lines · Khem Raj

defaults for gcc is to use -fno-common this ensures that it keeps using -fcommon until the real issue is fixed

Fixes
src/arm/Ginit.c:60: multiple definition of `_U_dyn_info_list'; mi/.libs/dyn-info-list.o:/usr/src/debug/libunwind/1.4.0-r0/build/src/../../libunwind-1.4.0/src/mi/dyn-info-list.c:28: first defined here
...

The upstream fix is
https://github.com/libunwind/libunwind/commit/29e17d8d2ccbca07c423e3089a6d5ae8a1c9cb6e

cu
Adrian

author
#3 lore raw
Quoted 5 lines · Adrian Bunk
Quoted 3 lines · Khem Raj

defaults for gcc is to use -fno-common this ensures that it keeps using -fcommon until the real issue is fixed

Quoted 7 lines
Quoted 3 lines

Fixes
src/arm/Ginit.c:60: multiple definition of `_U_dyn_info_list'; mi/.libs/dyn-info-list.o:/usr/src/debug/libunwind/1.4.0-r0/build/src/../../libunwind-1.4.0/src/mi/dyn-info-list.c:28: first defined here
...

The upstream fix is
https://github.com/libunwind/libunwind/commit/29e17d8d2ccbca07c423e3089a6d5ae8a1c9cb6e

Thanks for suggesting this, I have sent a v2

Quoted 2 lines

cu
Adrian