selftests/net: relax cpu affinity requirement in msg_zerocopy test
Subsystems (3)
PATCH 1/1 selftests/net: relax cpu affinity requirement in msg_zerocopy test
From: Willem de Bruijn <[email protected]>
The msg_zerocopy test pins the sender and receiver threads to separate cores to reduce variance between runs.
But it hardcodes the cores and skips core 0, so it fails on machines with the selected cores offline, or simply fewer cores.
The test mainly gives code coverage in automated runs. The throughput of zerocopy ('-z') and non-zerocopy runs is logged for manual inspection.
Continue even when sched_setaffinity fails. Just log to warn anyone interpreting the data.
--- tools/testing/selftests/net/msg_zerocopy.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
tools/testing/selftests/net/msg_zerocopy.c +2 -3
@@ -125,9 +125,8 @@ static int do_setcpu(int cpu)CPU_ZERO (&mask);CPU_SET (cpu, &mask);if (sched_setaffinity (0 ,sizeof (mask), &mask)) -error (1 ,0 ,"setaffinity %d" , cpu); - -if (cfg_verbose) +fprintf (stderr,"cpu: unable to pin, may increase variance.\n" ); +else if (cfg_verbose)fprintf (stderr,"cpu: %u\n" , cpu);return 0 ;
Signature · 1 line
2.28.0.236.gb10cc79966-goog
ACK: [PATCH net] selftests/net: relax cpu affinity requirement in msg_zerocopy test
Quoted 29 lines · Willem de Bruijn
From: Willem de Bruijn <[email protected]>
The
msg_zerocopytest pins the sender and receiver threads to separate cores to reduce variance between runs.But it hardcodes the cores and skips core 0, so it fails on machines with the selected cores offline, or simply fewer cores.
The test mainly gives code coverage in automated runs. The throughput of zerocopy ('-z') and non-zerocopy runs is logged for manual inspection.
Continue even when
sched_setaffinityfails. Just log to warn anyone interpreting the data.Fixes 07b65c5b31ce ("test: add msg_zerocopy test")Reported-by Colin Ian King <[email protected]>Signed-off-by Willem de Bruijn <[email protected]>--- tools/testing/selftests/net/msg_zerocopy.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)tools/testing/selftests/net/msg_zerocopy.c +0
-0@@ -125,9 +125,8 @@ static int do_setcpu(int cpu)CPU_ZERO (&mask);
tools/testing/selftests/net/msg_zerocopy.c static int do_setcpu(int cpu) · line 132
Quoted 10 lines
tools/testing/selftests/net/msg_zerocopy.c +2
-3CPU_SET (cpu, &mask);if (sched_setaffinity (0 ,sizeof (mask), &mask)) -error (1 ,0 ,"setaffinity %d" , cpu); - -if (cfg_verbose) +fprintf (stderr,"cpu: unable to pin, may increase variance.\n" ); +else if (cfg_verbose)fprintf (stderr,"cpu: %u\n" , cpu);return 0 ;
Thanks, you solution is good for my testing requirements
David Miller
maintainerFrom: Willem de Bruijn <[email protected]>
Date: Wed, 5 Aug 2020 04:40:45 -0400
Quoted 12 lines
From: Willem de Bruijn <[email protected]>
The
msg_zerocopytest pins the sender and receiver threads to separate cores to reduce variance between runs.But it hardcodes the cores and skips core 0, so it fails on machines with the selected cores offline, or simply fewer cores.
The test mainly gives code coverage in automated runs. The throughput of zerocopy ('-z') and non-zerocopy runs is logged for manual inspection.
Quoted 6 lines
Continue even when
sched_setaffinityfails. Just log to warn anyone interpreting the data.Fixes 07b65c5b31ce ("test: add msg_zerocopy test")Reported-by Colin Ian King <[email protected]>Signed-off-by Willem de Bruijn <[email protected]>
Applied and queued up for -stable, thanks.