Skip to contentSkip to conversation

i2c: nvidia-gpu: Use put_unaligned_be24()

PATCH Applied Andy Shevchenko 3 participants 4 messages Jul 16, 2020 – Sep 21, 2020

Subsystems (2)
I2C subsystem host drivers I2C controller driver for NVIDIA GPU
lore
Share & tools
lore

Andy Shevchenko

author
#0 lore raw

PATCH 1/1 i2c: nvidia-gpu: Use put_unaligned_be24()

This makes the driver code slightly easier to read.

Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/i2c/busses/i2c-nvidia-gpu.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/i2c/busses/i2c-nvidia-gpu.c +1 -2
index f480105000b8..f9a69b109e5c 100644
@@ -125,8 +125,7 @@ static int gpu_i2c_read(struct gpu_i2c_dev *i2cd, u8 *data, u16 len)
 		put_unaligned_be16(val, data);
 		break;
 	case 3:
-		put_unaligned_be16(val >> 8, data);
-		data[2] = val;
+		put_unaligned_be24(val, data);
 		break;
 	case 4:
 		put_unaligned_be32(val, data);
Signature · 1 line
2.27.0
#1 lore raw
Quoted 4 lines · Andy Shevchenko

This makes the driver code slightly easier to read.

Signed-off-by Andy Shevchenko <[email protected]>

---

Ajay, any comments?

Quoted 20 lines
 drivers/i2c/busses/i2c-nvidia-gpu.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/i2c/busses/i2c-nvidia-gpu.c +1 -2
index f480105000b8..f9a69b109e5c 100644
@@ -125,8 +125,7 @@ static int gpu_i2c_read(struct gpu_i2c_dev *i2cd, u8 *data, u16 len)
 		put_unaligned_be16(val, data);
 		break;
 	case 3:
-		put_unaligned_be16(val >> 8, data);
-		data[2] = val;
+		put_unaligned_be24(val, data);
 		break;
 	case 4:
 		put_unaligned_be32(val, data);
Signature · 1 line
2.27.0
maintainer Reviewed-by
#2 lore raw

Hi Wolfram,

Quoted 7 lines

-----Original Message-----
From: Wolfram Sang <[email protected]>
Sent: Wednesday, August 5, 2020 2:29 AM
To: Andy Shevchenko <[email protected]>
Cc: Ajay Gupta <[email protected]>; [email protected]
Subject: Re: [PATCH v1] i2c: nvidia-gpu: Use put_unaligned_be24()

Quoted 7 lines
Quoted 4 lines · Andy Shevchenko

This makes the driver code slightly easier to read.

Signed-off-by Andy Shevchenko <[email protected]>

---

Ajay, any comments?

The change looks good to me.

Reviewed-by Ajay Gupta <[email protected]>

Thanks

Quoted 24 lines

nvpublic

drivers/i2c/busses/i2c-

Quoted 4 lines
 drivers/i2c/busses/i2c-nvidia-gpu.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/i2c/busses/i2c- renamed from drivers/i2c/busses/i2c-nvidia-gpu.c +0 -0

nvidia-gpu.c

drivers/i2c/busses/i2c-nvidia-gpu.c static int gpu_i2c_read(struct gpu_i2c_dev *i2cd, u8

Quoted 4 lines

index f480105000b8..f9a69b109e5c 100644

drivers/i2c/busses/i2c-nvidia-gpu.c +0 -0
@@ -125,8 +125,7 @@ static int gpu_i2c_read(struct gpu_i2c_dev *i2cd, u8

*data, u16 len)

Quoted 12 lines
drivers/i2c/busses/i2c-nvidia-gpu.c +1 -3
 		put_unaligned_be16(val, data);
 		break;
 	case 3:
-		put_unaligned_be16(val >> 8, data);
-		data[2] = val;
+		put_unaligned_be24(val, data);
 		break;
 	case 4:
 		put_unaligned_be32(val, data);
--

2.27.0