Skip to contentSkip to conversation

habanalabs: Fix a loop in gaudi_extract_ecc_info()

PATCH In review Dan Carpenter 2 participants 2 messages Aug 5, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 habanalabs: Fix a loop in gaudi_extract_ecc_info()

The condition was reversed. It should have been less than instead of greater than. The result is that we never enter the loop.

Fixes fcc6a4e60678 ("habanalabs: Extract ECC information from FW")
---
 drivers/misc/habanalabs/gaudi/gaudi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/habanalabs/gaudi/gaudi.c +1 -1
index 00a0a7238d81..de2f81b80ced 100644
@@ -5215,7 +5215,7 @@ static int gaudi_extract_ecc_info(struct hl_device *hdev,
 	*memory_wrapper_idx = 0xFF;
 
 	/* Iterate through memory wrappers, a single bit must be set */
-	for (i = 0 ; i > num_mem_regs ; i++) {
+	for (i = 0 ; i < num_mem_regs ; i++) {
 		err_addr += i * 4;
 		err_word = RREG32(err_addr);
 		if (err_word) {
Signature · 1 line
2.27.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 24 lines · Dan Carpenter

The condition was reversed. It should have been less than instead of greater than. The result is that we never enter the loop.

Fixes fcc6a4e60678 ("habanalabs: Extract ECC information from FW")
---
 drivers/misc/habanalabs/gaudi/gaudi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/habanalabs/gaudi/gaudi.c +1 -2
index 00a0a7238d81..de2f81b80ced 100644
@@ -5215,7 +5215,7 @@ static int gaudi_extract_ecc_info(struct hl_device *hdev,
        *memory_wrapper_idx = 0xFF;
 
        /* Iterate through memory wrappers, a single bit must be set */
-       for (i = 0 ; i > num_mem_regs ; i++) {
+       for (i = 0 ; i < num_mem_regs ; i++) {
                err_addr += i * 4;
                err_word = RREG32(err_addr);
                if (err_word) {
--
Quoted 2 lines

2.27.0

This patch is:

Thanks!
Applied to -fixes