Skip to contentSkip to conversation

sysreset: socfpga: agilex: Enable sysreset support

PATCH New Chee Hong Ang 2 participants 4 messages Aug 5, 2020 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sysreset: socfpga: agilex: Enable sysreset support

Enable sysreset support for Agilex platform.

---
 arch/arm/Kconfig         | 2 +-
 drivers/sysreset/Kconfig | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
arch/arm/Kconfig +1 -1
index 6b8a32c38d..105b5f08a9 100644
@@ -991,7 +991,7 @@ config ARCH_SOCFPGA
 	select SYS_THUMB_BUILD if TARGET_SOCFPGA_GEN5 || TARGET_SOCFPGA_ARRIA10
 	select SYSRESET
 	select SYSRESET_SOCFPGA if TARGET_SOCFPGA_GEN5 || TARGET_SOCFPGA_ARRIA10
-	select SYSRESET_SOCFPGA_S10 if TARGET_SOCFPGA_STRATIX10
+	select SYSRESET_SOCFPGA_S10 if TARGET_SOCFPGA_STRATIX10 || TARGET_SOCFPGA_AGILEX
 	imply CMD_DM
 	imply CMD_MTDPARTS
 	imply CRC32_VERIFY
drivers/sysreset/Kconfig +3 -3
index 6ebc90e1d3..d886d1c933 100644
@@ -80,11 +80,11 @@ config SYSRESET_SOCFPGA
 	  (Cyclone 5, Arria 5 and Arria 10).
 
 config SYSRESET_SOCFPGA_S10
-	bool "Enable support for Intel SOCFPGA Stratix 10"
-	depends on ARCH_SOCFPGA && TARGET_SOCFPGA_STRATIX10
+	bool "Enable support for Intel SOCFPGA SoC64 family (Stratix10/Agilex)"
+	depends on ARCH_SOCFPGA && (TARGET_SOCFPGA_STRATIX10 || TARGET_SOCFPGA_AGILEX)
 	help
 	  This enables the system reset driver support for Intel SOCFPGA
-	  Stratix SoCs.
+	  SoC64 SoCs.
 
 config SYSRESET_TI_SCI
 	bool "TI System Control Interface (TI SCI) system reset driver"
Signature · 1 line
2.19.0
#1 lore raw

PATCH 1/1 sysreset: socfpga: agilex: Enable sysreset support

Quoted 43 lines

-----Original Message-----
From: Ang, Chee Hong <[email protected]>
Sent: Wednesday, August 5, 2020 5:54 PM
To: u-boot at lists.denx.de
Cc: Marek Vasut <[email protected]>; Simon Goldschmidt <[email protected]>; Tom Rini <[email protected]>; See, Chin Liang <[email protected]>; Tan, Ley Foon <[email protected]>; Ang, Chee Hong <[email protected]>; Chee, Tien Fong <[email protected]>; Lim, Elly Siew Chin <[email protected]>
Subject: [PATCH v1] sysreset: socfpga: agilex: Enable sysreset support

Enable sysreset support for Agilex platform.

---
 arch/arm/Kconfig         | 2 +-
 drivers/sysreset/Kconfig | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
arch/arm/Kconfig index renamed from arch/arm/Kconfig +0 -0

6b8a32c38d..105b5f08a9 100644

arch/arm/Kconfig +0 -0
@@ -991,7 +991,7 @@ config ARCH_SOCFPGA
 	select SYS_THUMB_BUILD if TARGET_SOCFPGA_GEN5 ||

TARGET_SOCFPGA_ARRIA10

arch/arm/Kconfig +0 -0
 	select SYSRESET
 	select SYSRESET_SOCFPGA if TARGET_SOCFPGA_GEN5 ||

TARGET_SOCFPGA_ARRIA10

arch/arm/Kconfig +2 -1
-	select SYSRESET_SOCFPGA_S10 if TARGET_SOCFPGA_STRATIX10
+	select SYSRESET_SOCFPGA_S10 if TARGET_SOCFPGA_STRATIX10 ||
+TARGET_SOCFPGA_AGILEX
 	imply CMD_DM
 	imply CMD_MTDPARTS
 	imply CRC32_VERIFY
drivers/sysreset/Kconfig index renamed from drivers/sysreset/Kconfig +0 -0

6ebc90e1d3..d886d1c933 100644

drivers/sysreset/Kconfig config SYSRESET_SOCFPGA · line 82

Quoted 3 lines
drivers/sysreset/Kconfig +0 -0
@@ -80,11 +80,11 @@ config SYSRESET_SOCFPGA
 	  (Cyclone 5, Arria 5 and Arria 10).
 
 config SYSRESET_SOCFPGA_S10

This can change to _SOC64.

drivers/sysreset/Kconfig

Quoted 6 lines
drivers/sysreset/Kconfig +1 -2
-	bool "Enable support for Intel SOCFPGA Stratix 10"
-	depends on ARCH_SOCFPGA && TARGET_SOCFPGA_STRATIX10
+	bool "Enable support for Intel SOCFPGA SoC64 family

(Stratix10/Agilex)"

drivers/sysreset/Kconfig +2 -0
+	depends on ARCH_SOCFPGA && (TARGET_SOCFPGA_STRATIX10 ||
+TARGET_SOCFPGA_AGILEX)

Regards
Ley Foon

#2 lore raw

PATCH 1/1 sysreset: socfpga: agilex: Enable sysreset support

Quoted 43 lines
Quoted 43 lines

-----Original Message-----
From: Ang, Chee Hong <[email protected]>
Sent: Wednesday, August 5, 2020 5:54 PM
To: u-boot at lists.denx.de
Cc: Marek Vasut <[email protected]>; Simon Goldschmidt <[email protected]>; Tom Rini <[email protected]>; See, Chin Liang <[email protected]>; Tan, Ley Foon <[email protected]>; Ang, Chee Hong <[email protected]>; Chee, Tien Fong <[email protected]>; Lim, Elly Siew Chin <[email protected]>
Subject: [PATCH v1] sysreset: socfpga: agilex: Enable sysreset support

Enable sysreset support for Agilex platform.

---
 arch/arm/Kconfig         | 2 +-
 drivers/sysreset/Kconfig | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
arch/arm/Kconfig index renamed from arch/arm/Kconfig +0 -0

6b8a32c38d..105b5f08a9 100644

arch/arm/Kconfig +0 -0
@@ -991,7 +991,7 @@ config ARCH_SOCFPGA
 	select SYS_THUMB_BUILD if TARGET_SOCFPGA_GEN5 ||

TARGET_SOCFPGA_ARRIA10

arch/arm/Kconfig +0 -0
 	select SYSRESET
 	select SYSRESET_SOCFPGA if TARGET_SOCFPGA_GEN5 ||

TARGET_SOCFPGA_ARRIA10

arch/arm/Kconfig +2 -1
-	select SYSRESET_SOCFPGA_S10 if TARGET_SOCFPGA_STRATIX10
+	select SYSRESET_SOCFPGA_S10 if TARGET_SOCFPGA_STRATIX10 ||
+TARGET_SOCFPGA_AGILEX
 	imply CMD_DM
 	imply CMD_MTDPARTS
 	imply CRC32_VERIFY
drivers/sysreset/Kconfig index renamed from drivers/sysreset/Kconfig +0 -0

6ebc90e1d3..d886d1c933 100644

drivers/sysreset/Kconfig +0 -0
@@ -80,11 +80,11 @@ config SYSRESET_SOCFPGA
 	  (Cyclone 5, Arria 5 and Arria 10).
 
Quoted 3 lines

drivers/sysreset/Kconfig config SYSRESET_SOCFPGA · line 82

Quoted 1 line
drivers/sysreset/Kconfig +0 -0
 config SYSRESET_SOCFPGA_S10

This can change to _SOC64.

Do I need to change the source file from drivers/sysreset/sysreset_socfpga_s10.c to drivers/sysreset/sysreset_socfpga_soc64.c as well ? drivers/sysreset/makefile has this:
obj-$(CONFIG_SYSRESET_SOCFPGA_S10) += sysreset_socfpga_s10.o

Quoted 14 lines

drivers/sysreset/Kconfig

Quoted 8 lines
drivers/sysreset/Kconfig +1 -2
-	bool "Enable support for Intel SOCFPGA Stratix 10"
-	depends on ARCH_SOCFPGA && TARGET_SOCFPGA_STRATIX10
+	bool "Enable support for Intel SOCFPGA SoC64 family

(Stratix10/Agilex)"

drivers/sysreset/Kconfig +2 -0
+	depends on ARCH_SOCFPGA && (TARGET_SOCFPGA_STRATIX10 ||
+TARGET_SOCFPGA_AGILEX)

Regards
Ley Foon

#3 lore raw

PATCH 1/1 sysreset: socfpga: agilex: Enable sysreset support

Quoted 58 lines

-----Original Message-----
From: Ang, Chee Hong <[email protected]>
Sent: Wednesday, August 5, 2020 6:08 PM
To: Tan, Ley Foon <[email protected]>; u-boot at lists.denx.de
Cc: Marek Vasut <[email protected]>; Simon Goldschmidt <[email protected]>; Tom Rini <[email protected]>; See, Chin Liang <[email protected]>; Chee, Tien Fong <[email protected]>; Lim, Elly Siew Chin <[email protected]>
Subject: RE: [PATCH v1] sysreset: socfpga: agilex: Enable sysreset support

Quoted 45 lines
Quoted 45 lines

-----Original Message-----
From: Ang, Chee Hong <[email protected]>
Sent: Wednesday, August 5, 2020 5:54 PM
To: u-boot at lists.denx.de
Cc: Marek Vasut <[email protected]>; Simon Goldschmidt <[email protected]>; Tom Rini <[email protected]>; See, Chin Liang <[email protected]>; Tan, Ley Foon <[email protected]>; Ang, Chee Hong <[email protected]>; Chee, Tien Fong <[email protected]>; Lim, Elly Siew Chin <[email protected]>
Subject: [PATCH v1] sysreset: socfpga: agilex: Enable sysreset support

Enable sysreset support for Agilex platform.

---
 arch/arm/Kconfig         | 2 +-
 drivers/sysreset/Kconfig | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
arch/arm/Kconfig index renamed from arch/arm/Kconfig +0 -0

6b8a32c38d..105b5f08a9 100644

arch/arm/Kconfig +0 -0
@@ -991,7 +991,7 @@ config ARCH_SOCFPGA
 	select SYS_THUMB_BUILD if TARGET_SOCFPGA_GEN5 ||

TARGET_SOCFPGA_ARRIA10

arch/arm/Kconfig +0 -0
 	select SYSRESET
 	select SYSRESET_SOCFPGA if TARGET_SOCFPGA_GEN5 ||

TARGET_SOCFPGA_ARRIA10

arch/arm/Kconfig +2 -1
-	select SYSRESET_SOCFPGA_S10 if TARGET_SOCFPGA_STRATIX10
+	select SYSRESET_SOCFPGA_S10 if TARGET_SOCFPGA_STRATIX10 ||
+TARGET_SOCFPGA_AGILEX
 	imply CMD_DM
 	imply CMD_MTDPARTS
 	imply CRC32_VERIFY
drivers/sysreset/Kconfig +0 -0

index
6ebc90e1d3..d886d1c933 100644

drivers/sysreset/Kconfig +0 -0
@@ -80,11 +80,11 @@ config SYSRESET_SOCFPGA
 	  (Cyclone 5, Arria 5 and Arria 10).
 
Quoted 9 lines
Quoted 3 lines

drivers/sysreset/Kconfig config SYSRESET_SOCFPGA · line 82

Quoted 1 line
drivers/sysreset/Kconfig +0 -0
 config SYSRESET_SOCFPGA_S10

This can change to _SOC64.

Do I need to change the source file from drivers/sysreset/sysreset_socfpga_s10.c to drivers/sysreset/sysreset_socfpga_soc64.c as well ? drivers/sysreset/makefile has this:
obj-$(CONFIG_SYSRESET_SOCFPGA_S10) += sysreset_socfpga_s10.o

Yes, I think it is better. Rename first , then add Agilex support.

Regards
Ley Foon