Skip to contentSkip to conversation

configs: socfpga: soc64: Avoid SPL enter infinite loop during exception

PATCH New Chee Hong Ang 2 participants 2 messages Aug 5, 2020 – Aug 6, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configs: socfpga: soc64: Avoid SPL enter infinite loop during exception

From: Chin Liang See <[email protected]>

In current implementation, any exception would trigger a CPU reset. But a bad written SPL would cause infinite loop where the system will reload the same SPL instead of loading factory safe image.

Hence this patch is to ensure any exception will cause a hang. At this moment, watchdog shall be triggered and Remote System Update mechanism shall load the next production image or factory safe image.

---
 configs/socfpga_agilex_defconfig    | 1 +
 configs/socfpga_stratix10_defconfig | 1 +
 2 files changed, 2 insertions(+)
configs/socfpga_agilex_defconfig +1 -0
index 2885c60..acf0316 100644
@@ -61,3 +61,4 @@ CONFIG_DM_USB=y
 CONFIG_USB_DWC2=y
 CONFIG_USB_STORAGE=y
 # CONFIG_SPL_USE_TINY_PRINTF is not set
+CONFIG_PANIC_HANG=y
configs/socfpga_stratix10_defconfig +1 -0
index 9ae6ef6..8b4d1fb 100644
@@ -67,3 +67,4 @@ CONFIG_USB_STORAGE=y
 CONFIG_DESIGNWARE_WATCHDOG=y
 CONFIG_WDT=y
 # CONFIG_SPL_USE_TINY_PRINTF is not set
+CONFIG_PANIC_HANG=y
Signature · 1 line
2.2.0
#1 lore raw

PATCH 1/1 configs: socfpga: soc64: Avoid SPL enter infinite loop during exception

Quoted 25 lines

-----Original Message-----
From: Ang, Chee Hong <[email protected]>
Sent: Wednesday, August 5, 2020 6:35 PM
To: u-boot at lists.denx.de
Cc: Marek Vasut <[email protected]>; Simon Goldschmidt <[email protected]>; Tom Rini <[email protected]>; See, Chin Liang <[email protected]>; Tan, Ley Foon <[email protected]>; Ang, Chee Hong <[email protected]>; Chee, Tien Fong <[email protected]>; Lim, Elly Siew Chin <[email protected]>
Subject: [PATCH v1] configs: socfpga: soc64: Avoid SPL enter infinite loop during exception

From: Chin Liang See <[email protected]>

In current implementation, any exception would trigger a CPU reset. But a bad written SPL would cause infinite loop where the system will reload the same SPL instead of loading factory safe image.

Hence this patch is to ensure any exception will cause a hang. At this moment, watchdog shall be triggered and Remote System Update mechanism shall load the next production image or factory safe image.

Quoted 7 lines
---
 configs/socfpga_agilex_defconfig    | 1 +
 configs/socfpga_stratix10_defconfig | 1 +
 2 files changed, 2 insertions(+)

Regards
Ley Foon