virtio_net: use LE accessors for speed/duplex
Subsystems (4)
Michael S. Tsirkin
maintainerPATCH 1/1 virtio_net: use LE accessors for speed/duplex
Speed and duplex config fields depend on VIRTIO_NET_F_SPEED_DUPLEX which being 63>31 depends on VIRTIO_F_VERSION_1.
Accordingly, use LE accessors for these fields.
Reported-by Cornelia Huck <[email protected]>
Signed-off-by Michael S. Tsirkin <[email protected]>
--- drivers/net/virtio_net.c | 9 +++++---- include/uapi/linux/virtio_net.h | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-)
drivers/net/virtio_net.c +5 -4
@@ -2264,12 +2264,13 @@ static void virtnet_update_settings(struct virtnet_info *vi)if (!virtio_has_feature (vi->vdev,VIRTIO_NET_F_SPEED_DUPLEX ))return ; - speed =virtio_cread32 (vi->vdev, offsetof(struct virtio_net_config , - speed)); + virtio_cread_le(vi->vdev, struct virtio_net_config, speed, &speed); +if (ethtool_validate_speed (speed)) vi->speed = speed; - duplex =virtio_cread8 (vi->vdev, offsetof(struct virtio_net_config , - duplex)); + + virtio_cread_le(vi->vdev, struct virtio_net_config, duplex, &duplex); +if (ethtool_validate_duplex (duplex)) vi->duplex = duplex; }
include/uapi/linux/virtio_net.h +1 -1
@@ -99,7 +99,7 @@ struct virtio_net_config {* speed, in units of 1Mb. All values 0 to INT_MAX are legal. * Any other value stands for unknown. */ -__virtio32 speed; +__le32 speed;/* * 0x00 - half duplex * 0x01 - full duplex
Signature · 6 lines
MST _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization