omapfb: dss: Fix max fclk divider for omap36xx
PATCH 1/1 omapfb: dss: Fix max fclk divider for omap36xx
There appears to be a timing issue where using a divider of 32 breaks the DSS for OMAP36xx despite the TRM stating 32 is a valid number. Through experimentation, it appears that 31 works.
This same fix was issued for kernels 4.5+. However, between kernels 4.4 and 4.5, the directory structure was changed when the dss directory was moved inside the omapfb directory. That broke the patch on kernels older than 4.5, because it didn't permit the patch to apply cleanly for 4.4 and older.
A similar patch was applied to the 3.16 kernel already, but not to 4.4. Commit 4b911101a5cd ("drm/omap: fix max fclk divider for omap36xx") is on the 3.16 stable branch with notes from Ben about the path change.
Since this was applied for 3.16 already, this patch is for kernels 3.17 through 4.4 only.
drivers/video/fbdev/omap2/dss/dss.c +1 -1
@@ -843,7 +843,7 @@ static const struct dss_features omap34xx_dss_feats = { };static const struct dss_features omap3630_dss_feats = { - .fck_div_max =32 , + .fck_div_max =31 , .dss_fck_multiplier =1 , .parent_clk_name ="dpll4_ck" , .dpi_select_source = &dss_dpi_select_source_omap2_omap3,
Signature · 1 line
2.25.1
A message that is not in the archive (sent off-list or not yet received): CAHCN7x+crwfE4pfufad_WEUhiJQXccSZHot+YNDZzZKvqhrmWA@mail.gmail.com
Tomi Valkeinen
Reviewed-byQuoted 23 lines · Adam Ford
On Thu, Jul 9, 2020 at 7:12 AM Adam Ford <[email protected] <mailto:[email protected]>> wrote:
There appears to be a timing issue where using a divider of 32 breaks the DSS for OMAP36xx despite the TRM stating 32 is a valid number. Through experimentation, it appears that 31 works.
This same fix was issued for kernels 4.5+. However, between kernels 4.4 and 4.5, the directory structure was changed when the dss directory was moved inside the omapfb directory. That broke the patch on kernels older than 4.5, because it didn't permit the patch to apply cleanly for 4.4 and older.
A similar patch was applied to the 3.16 kernel already, but not to 4.4. Commit
4b911101a5cd("drm/omap: fix max fclk divider for omap36xx") is on the 3.16 stable branch with notes from Ben about the path change.Since this was applied for 3.16 already, this patch is for kernels 3.17 through 4.4 only.
Fixes f7018c213502 ("video: move fbdev to drivers/video/fbdev")
Quoted 8 lines
Cc <[email protected] <mailto:[email protected]>> #3.17 - 4.4CC <[email protected] <mailto:[email protected]>>Signed-off-by Adam Ford <[email protected] <mailto:[email protected]>>Tomi,
Can you comment on this? The 4.4 is still waiting for this fix. The other branches are fixed.
Looks good to me.
Tomi
Signature · 2 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Quoted 29 lines · Tomi Valkeinen
Quoted 28 lines · Adam Ford
On Thu, Jul 9, 2020 at 7:12 AM Adam Ford <[email protected] <mailto:[email protected]>> wrote:
There appears to be a timing issue where using a divider of 32 breaks the DSS for OMAP36xx despite the TRM stating 32 is a valid number. Through experimentation, it appears that 31 works.
This same fix was issued for kernels 4.5+. However, between kernels 4.4 and 4.5, the directory structure was changed when the dss directory was moved inside the omapfb directory. That broke the patch on kernels older than 4.5, because it didn't permit the patch to apply cleanly for 4.4 and older.
A similar patch was applied to the 3.16 kernel already, but not to 4.4. Commit
4b911101a5cd("drm/omap: fix max fclk divider for omap36xx") is on the 3.16 stable branch with notes from Ben about the path change.Since this was applied for 3.16 already, this patch is for kernels 3.17 through 4.4 only.
Fixes f7018c213502 ("video: move fbdev to drivers/video/fbdev")Cc <[email protected] <mailto:[email protected]>> #3.17 - 4.4CC <[email protected] <mailto:[email protected]>>Signed-off-by Adam Ford <[email protected] <mailto:[email protected]>>
Quoted 7 lines
Quoted 3 lines
Tomi,
Can you comment on this? The 4.4 is still waiting for this fix. The other branches are fixed.
Looks good to me.
Reviewed-by Tomi Valkeinen <[email protected]>
I don't seem to have the original of this anymore, can someone please resend it?
thanks,
greg k-h
Hi Greg,
Quoted 32 lines · Greg KH
Quoted 31 lines · Tomi Valkeinen
Quoted 30 lines · Adam Ford
On Thu, Jul 9, 2020 at 7:12 AM Adam Ford <[email protected] <mailto:[email protected]>> wrote:
There appears to be a timing issue where using a divider of 32 breaks the DSS for OMAP36xx despite the TRM stating 32 is a valid number. Through experimentation, it appears that 31 works.
This same fix was issued for kernels 4.5+. However, between kernels 4.4 and 4.5, the directory structure was changed when the dss directory was moved inside the omapfb directory. That broke the patch on kernels older than 4.5, because it didn't permit the patch to apply cleanly for 4.4 and older.
A similar patch was applied to the 3.16 kernel already, but not to 4.4. Commit
4b911101a5cd("drm/omap: fix max fclk divider for omap36xx") is on the 3.16 stable branch with notes from Ben about the path change.Since this was applied for 3.16 already, this patch is for kernels 3.17 through 4.4 only.
Fixes f7018c213502 ("video: move fbdev to drivers/video/fbdev")Cc <[email protected] <mailto:[email protected]>> #3.17 - 4.4CC <[email protected] <mailto:[email protected]>>Signed-off-by Adam Ford <[email protected] <mailto:[email protected]>>Tomi,
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Can you comment on this? The 4.4 is still waiting for this fix. The other branches are fixed.
Looks good to me.
Reviewed-by Tomi Valkeinen <[email protected]>I don't seem to have the original of this anymore, can someone please resend it?
I have attached the original.
Tomi
Signature · 2 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Quoted 38 lines · Tomi Valkeinen
Hi Greg,
Quoted 34 lines · Greg KH
Quoted 33 lines · Tomi Valkeinen
Quoted 31 lines · Adam Ford
On Thu, Jul 9, 2020 at 7:12 AM Adam Ford <[email protected] <mailto:[email protected]>> wrote:
There appears to be a timing issue where using a divider of 32 breaks the DSS for OMAP36xx despite the TRM stating 32 is a valid number. Through experimentation, it appears that 31 works.
This same fix was issued for kernels 4.5+. However, between kernels 4.4 and 4.5, the directory structure was changed when the dss directory was moved inside the omapfb directory. That broke the patch on kernels older than 4.5, because it didn't permit the patch to apply cleanly for 4.4 and older.
A similar patch was applied to the 3.16 kernel already, but not to 4.4. Commit
4b911101a5cd("drm/omap: fix max fclk divider for omap36xx") is on the 3.16 stable branch with notes from Ben about the path change.Since this was applied for 3.16 already, this patch is for kernels 3.17 through 4.4 only.
Fixes f7018c213502 ("video: move fbdev to drivers/video/fbdev")Cc <[email protected] <mailto:[email protected]>> #3.17 - 4.4CC <[email protected] <mailto:[email protected]>>Signed-off-by Adam Ford <[email protected] <mailto:[email protected]>>Tomi,
Can you comment on this? The 4.4 is still waiting for this fix. The other branches are fixed.
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Looks good to me.
Reviewed-by Tomi Valkeinen <[email protected]>I don't seem to have the original of this anymore, can someone please resend it?
I have attached the original.
Greg,
Do you have what you need? I see all the other kernels have been had the corresponding patches pushed, but 4.4 needed something different due to some path / naming changes.
adam
Quoted 6 lines
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Quoted 46 lines · Adam Ford
Quoted 45 lines · Tomi Valkeinen
Hi Greg,
Quoted 40 lines · Greg KH
Quoted 29 lines · Tomi Valkeinen
Quoted 28 lines · Adam Ford
On Thu, Jul 9, 2020 at 7:12 AM Adam Ford <[email protected] <mailto:[email protected]>> wrote:
There appears to be a timing issue where using a divider of 32 breaks the DSS for OMAP36xx despite the TRM stating 32 is a valid number. Through experimentation, it appears that 31 works.
This same fix was issued for kernels 4.5+. However, between kernels 4.4 and 4.5, the directory structure was changed when the dss directory was moved inside the omapfb directory. That broke the patch on kernels older than 4.5, because it didn't permit the patch to apply cleanly for 4.4 and older.
A similar patch was applied to the 3.16 kernel already, but not to 4.4. Commit
4b911101a5cd("drm/omap: fix max fclk divider for omap36xx") is on the 3.16 stable branch with notes from Ben about the path change.Since this was applied for 3.16 already, this patch is for kernels 3.17 through 4.4 only.
Fixes f7018c213502 ("video: move fbdev to drivers/video/fbdev")Cc <[email protected] <mailto:[email protected]>> #3.17 - 4.4CC <[email protected] <mailto:[email protected]>>Signed-off-by Adam Ford <[email protected] <mailto:[email protected]>>Quoted 7 lines
Quoted 3 lines
Tomi,
Can you comment on this? The 4.4 is still waiting for this fix. The other branches are fixed.
Looks good to me.
Reviewed-by Tomi Valkeinen <[email protected]>I don't seem to have the original of this anymore, can someone please resend it?
Quoted 7 lines
Quoted 1 line
I have attached the original.
Greg,
Do you have what you need? I see all the other kernels have been had the corresponding patches pushed, but 4.4 needed something different due to some path / naming changes.
All good, now queued up, thanks!
greg k-h