arm64: tlb: fix ARM64_TLB_RANGE with LLVM's integrated assembler
PATCH 1/1 arm64: tlb: fix ARM64_TLB_RANGE with LLVM's integrated assembler
Commit 7c78f67e9bd9 ("arm64: enable tlbi range instructions") breaks LLVM's integrated assembler, because -Wa,-march is only passed to external assemblers and therefore, the new instructions are not enabled when IAS is used.
As binutils doesn't support .arch_extension tlb-rmi, this change adds .arch armv8.4-a to __TLBI_0 and __TLBI_1 to fix the issue with both LLVM IAS and binutils.
--- arch/arm64/include/asm/tlbflush.h | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-)
arch/arm64/include/asm/tlbflush.h +14 -2
@@ -16,6 +16,16 @@#include <asm/cputype.h> #include <asm/mmu.h> +/* +* Enable ARMv8.4-TLBI instructions with ARM64_TLB_RANGE. Note that binutils +* doesn't support .arch_extension tlb-rmi, so use .arch armv8.4-a instead. +*/ +#ifdef CONFIG_ARM64_TLB_RANGE +#define __TLBI_PREAMBLE ".arch armv8.4-a\n" +#else +#define __TLBI_PREAMBLE +#endif +/* * Raw TLBI operations. *
@@ -28,14 +38,16 @@* not. The macros handles invoking the asm with or without the * register argument as appropriate. */ -#define __TLBI_0 (op, arg) asm ("tlbi " #op "\n" \ +#define __TLBI_0 (op, arg) asm (__TLBI_PREAMBLE \ + "tlbi " #op "\n" \ ALTERNATIVE("nop\n nop", \ "dsb ish\n tlbi " #op, \ ARM64_WORKAROUND_REPEAT_TLBI, \ CONFIG_ARM64_WORKAROUND_REPEAT_TLBI) \ : : ) -#define __TLBI_1 (op, arg) asm ("tlbi " #op ", %0\n" \ +#define __TLBI_1 (op, arg) asm (__TLBI_PREAMBLE \ + "tlbi " #op ", %0\n" \ ALTERNATIVE("nop\n nop", \ "dsb ish\n tlbi " #op ", %0", \ ARM64_WORKAROUND_REPEAT_TLBI, \
base-commit: 4834ce9d8e074bb7ae197632e0708219b9f389b5
Signature · 1 line
2.28.0.163.g6104cc2f0b6-goog
Quoted 6 lines · Sami Tolvanen
Commit
7c78f67e9bd9("arm64: enable tlbi range instructions") breaks LLVM's integrated assembler, because -Wa,-march is only passed to external assemblers and therefore, the new instructions are not enabled when IAS is used.
Quoted 7 lines
As binutils doesn't support .arch_extension tlb-rmi, this change adds .arch armv8.4-a to
__TLBI_0and__TLBI_1to fix the issue with both LLVM IAS and binutils.Fixes 7c78f67e9bd9 ("arm64: enable tlbi range instructions")Signed-off-by Sami Tolvanen <[email protected]>
I've filed https://sourceware.org/bugzilla/show_bug.cgi?id=26339 to discuss more with ARM binutils devs about some of the compat issues around these assembler directives.
Quoted 49 lines
--- arch/arm64/include/asm/tlbflush.h | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-)arch/arm64/include/asm/tlbflush.h +14
-2@@ -16,6 +16,16 @@#include <asm/cputype.h> #include <asm/mmu.h> +/* +* Enable ARMv8.4-TLBI instructions with ARM64_TLB_RANGE. Note that binutils +* doesn't support .arch_extension tlb-rmi, so use .arch armv8.4-a instead. +*/ +#ifdef CONFIG_ARM64_TLB_RANGE +#define __TLBI_PREAMBLE ".arch armv8.4-a\n" +#else +#define __TLBI_PREAMBLE +#endif +/* * Raw TLBI operations. * @@ -28,14 +38,16 @@* not. The macros handles invoking the asm with or without the * register argument as appropriate. */ -#define __TLBI_0 (op, arg) asm ("tlbi " #op "\n" \ +#define __TLBI_0 (op, arg) asm (__TLBI_PREAMBLE \ + "tlbi " #op "\n" \ ALTERNATIVE("nop\n nop", \ "dsb ish\n tlbi " #op, \ ARM64_WORKAROUND_REPEAT_TLBI, \ CONFIG_ARM64_WORKAROUND_REPEAT_TLBI) \ : : ) -#define __TLBI_1 (op, arg) asm ("tlbi " #op ", %0\n" \ +#define __TLBI_1 (op, arg) asm (__TLBI_PREAMBLE \ + "tlbi " #op ", %0\n" \ ALTERNATIVE("nop\n nop", \ "dsb ish\n tlbi " #op ", %0", \ ARM64_WORKAROUND_REPEAT_TLBI, \base-commit:
4834ce9d8e074bb7ae197632e0708219b9f389b5--
2.28.0.163.g6104cc2f0b6-goog
Signature · 7 lines
Thanks, ~Nick Desaulniers _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Catalin Marinas
maintainerQuoted 11 lines · Nick Desaulniers
Quoted 10 lines · Sami Tolvanen
Commit
7c78f67e9bd9("arm64: enable tlbi range instructions") breaks LLVM's integrated assembler, because -Wa,-march is only passed to external assemblers and therefore, the new instructions are not enabled when IAS is used.As binutils doesn't support .arch_extension tlb-rmi, this change adds .arch armv8.4-a to
__TLBI_0and__TLBI_1to fix the issue with both LLVM IAS and binutils.
Quoted 7 lines
Quoted 3 lines
Fixes 7c78f67e9bd9 ("arm64: enable tlbi range instructions")Signed-off-by Sami Tolvanen <[email protected]>I've filed https://sourceware.org/bugzilla/show_bug.cgi?id=26339 to discuss more with ARM binutils devs about some of the compat issues around these assembler directives.
Until we get some alignment between binutils and the LLVM's integrated assembler, the latter will be officially unsupported by the kernel. It's just insane to maintain different options for architecture extensions, e.g. memtag vs mte, armv8.4-a vs tlb-rmi. Even worse, I think you can't add some .arch_extension in binutils without bumping the .arch version. So maybe ".arch_extension tlb-rmi" works for the integrated assembler but, if such option is added to binutils, it would require ".arch armv8.4-a" as well.
So, please sort it out guys, collaborate between yourselves when inventing architecture mnemonics so that you are aligned.
We make take the occasional patch to fix the integrated assembler if it's not intrusive but at some point we may say it's just not supported and reject the fix. We have a hard line on the compiler not generating newer than ARMv8.0 instructions (unless they are in the NOP/HINT space), so we limit newer instructions to (inline) asm. That's why -march doesn't work, it needs to be -Wa,-march.
Signature · 6 lines
Catalin _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi,
Quoted 5 lines · Sami Tolvanen
Commit
7c78f67e9bd9("arm64: enable tlbi range instructions") breaks LLVM's integrated assembler, because -Wa,-march is only passed to external assemblers and therefore, the new instructions are not enabled when IAS is used.
I have looked through the discussion on Github issues. The best way to solve this problem is try to pass the "-Wa,-march" parameter to clang even when IAS is enabled, which may need the cooperation of compilation tool chains :(
Currently, I think we can solve the problem by passing
the '-march=armv8.4-a' when using the integrated assembler, just like:
arch/arm64/Makefile +4 -0
@@ -91,8 +91,12 @@ KBUILD_CFLAGS += $(branch-prot-flags-y) ifeq ($(CONFIG_AS_HAS_ARMV8_4), y) # make sure to pass the newest target architecture to -march. +ifneq ($(LLVM),) +KBUILD_CFLAGS += -march=armv8.4-a +else KBUILD_CFLAGS += -Wa,-march=armv8.4-a endif +endif ifeq ($(CONFIG_SHADOW_CALL_STACK), y)
No need to worry about that this might generate instructions that are not supported on older hardware, because the 'TLB range' feature is only enabled when the hardware support ARMv8.4.
Quoted 7 lines
As binutils doesn't support .arch_extension tlb-rmi, this change adds .arch armv8.4-a to
__TLBI_0and__TLBI_1to fix the issue with both LLVM IAS and binutils.Fixes 7c78f67e9bd9 ("arm64: enable tlbi range instructions")Signed-off-by Sami Tolvanen <[email protected]>
Thanks,
Zhenyu
Catalin Marinas
maintainerQuoted 19 lines · Zhenyu Ye
Quoted 4 lines · Sami Tolvanen
Commit
7c78f67e9bd9("arm64: enable tlbi range instructions") breaks LLVM's integrated assembler, because -Wa,-march is only passed to external assemblers and therefore, the new instructions are not enabled when IAS is used.I have looked through the discussion on Github issues. The best way to solve this problem is try to pass the "-Wa,-march" parameter to clang even when IAS is enabled, which may need the cooperation of compilation tool chains :(
Currently, I think we can solve the problem by passing
the '-march=armv8.4-a' when using the integrated assembler, just like:arch/arm64/Makefile +0
-0
arch/arm64/Makefile KBUILD_CFLAGS += $(branch-prot-flags-y) · line 99
Quoted 9 lines
arch/arm64/Makefile +4
-0@@ -91,8 +91,12 @@ KBUILD_CFLAGS += $(branch-prot-flags-y) ifeq ($(CONFIG_AS_HAS_ARMV8_4), y) # make sure to pass the newest target architecture to -march. +ifneq ($(LLVM),) +KBUILD_CFLAGS += -march=armv8.4-a +else KBUILD_CFLAGS += -Wa,-march=armv8.4-a endif +endif
No, see my other reply. This only works for .S files. For inline assembly, passing -march to .c files will make the compiler generate ARMv8.4 instructions and break the kernel single image that's supposed to run on ARMv8.0 hardware (even if you don't have any range TLBI instructions).
Signature · 6 lines
Catalin _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Catalin Marinas
maintainerQuoted 30 lines · Sami Tolvanen
arch/arm64/include/asm/tlbflush.h +12
-1@@ -16,6 +16,16 @@#include <asm/cputype.h> #include <asm/mmu.h> +/* +* Enable ARMv8.4-TLBI instructions with ARM64_TLB_RANGE. Note that binutils +* doesn't support .arch_extension tlb-rmi, so use .arch armv8.4-a instead. +*/ +#ifdef CONFIG_ARM64_TLB_RANGE +#define __TLBI_PREAMBLE ".arch armv8.4-a\n" +#else +#define __TLBI_PREAMBLE +#endif +/* * Raw TLBI operations. * @@ -28,14 +38,16 @@* not. The macros handles invoking the asm with or without the * register argument as appropriate. */ -#define __TLBI_0 (op, arg) asm ("tlbi " #op "\n" \ +#define __TLBI_0 (op, arg) asm (__TLBI_PREAMBLE \ + "tlbi " #op "\n" \ ALTERNATIVE("nop\n nop", \ "dsb ish\n tlbi " #op, \
arch/arm64/include/asm/tlbflush.h line 53
Quoted 10 lines
arch/arm64/include/asm/tlbflush.h +2
-1ARM64_WORKAROUND_REPEAT_TLBI, \ CONFIG_ARM64_WORKAROUND_REPEAT_TLBI) \ : : ) -#define __TLBI_1 (op, arg) asm ("tlbi " #op ", %0\n" \ +#define __TLBI_1 (op, arg) asm (__TLBI_PREAMBLE \ + "tlbi " #op ", %0\n" \ ALTERNATIVE("nop\n nop", \ "dsb ish\n tlbi " #op ", %0", \ ARM64_WORKAROUND_REPEAT_TLBI, \
A potential problem here is that for gas (not sure about the integrated assembler), .arch overrides any other .arch. So if we end up with two preambles included in the same generated .S files in the future, it will lead to some random behaviour.
Does the LLVM integrated assembler have the same behaviour on .arch overriding a prior .arch?
Maybe a better solution is for all inline asm on arm64 to have a standard preamble which is the maximum supported architecture version. We can add individual .arch_extension as those are not overriding.
Signature · 6 lines
Catalin _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 47 lines · Catalin Marinas
Quoted 30 lines · Sami Tolvanen
arch/arm64/include/asm/tlbflush.h +12
-1@@ -16,6 +16,16 @@#include <asm/cputype.h> #include <asm/mmu.h> +/* +* Enable ARMv8.4-TLBI instructions with ARM64_TLB_RANGE. Note that binutils +* doesn't support .arch_extension tlb-rmi, so use .arch armv8.4-a instead. +*/ +#ifdef CONFIG_ARM64_TLB_RANGE +#define __TLBI_PREAMBLE ".arch armv8.4-a\n" +#else +#define __TLBI_PREAMBLE +#endif +/* * Raw TLBI operations. * @@ -28,14 +38,16 @@* not. The macros handles invoking the asm with or without the * register argument as appropriate. */ -#define __TLBI_0 (op, arg) asm ("tlbi " #op "\n" \ +#define __TLBI_0 (op, arg) asm (__TLBI_PREAMBLE \ + "tlbi " #op "\n" \ ALTERNATIVE("nop\n nop", \ "dsb ish\n tlbi " #op, \arch/arm64/include/asm/tlbflush.h line 53
Quoted 10 lines
arch/arm64/include/asm/tlbflush.h +2
-1ARM64_WORKAROUND_REPEAT_TLBI, \ CONFIG_ARM64_WORKAROUND_REPEAT_TLBI) \ : : ) -#define __TLBI_1 (op, arg) asm ("tlbi " #op ", %0\n" \ +#define __TLBI_1 (op, arg) asm (__TLBI_PREAMBLE \ + "tlbi " #op ", %0\n" \ ALTERNATIVE("nop\n nop", \ "dsb ish\n tlbi " #op ", %0", \ ARM64_WORKAROUND_REPEAT_TLBI, \A potential problem here is that for gas (not sure about the integrated assembler), .arch overrides any other .arch. So if we end up with two preambles included in the same generated .S files in the future, it will lead to some random behaviour.
Quoted 2 lines
Does the LLVM integrated assembler have the same behaviour on .arch overriding a prior .arch?
I would assume so, but each inline assembly block is independent in LLVM, so unless there are .arch changes within the block, that shouldn't be an issue for the integrated assembler.
Quoted 3 lines
Maybe a better solution is for all inline asm on arm64 to have a standard preamble which is the maximum supported architecture version. We can add individual .arch_extension as those are not overriding.
Sure, that works. How would you feel about something like this, so we can keep the preamble in sync with future -Wa,-march changes? I'm not sure if asm/compiler.h is the correct place for the definition though.
arch/arm64/Makefile +8 -3
@@ -82,8 +82,8 @@ endif # compiler to generate them and consequently to break the single image contract # we pass it only to the assembler. This option is utilized only in case of non # integrated assemblers. -ifneq ($(CONFIG_AS_HAS_ARMV8_4), y) -branch-prot-flags-$(CONFIG_AS_HAS_PAC) += -Wa,-march=armv8.3-a +ifeq ($(CONFIG_AS_HAS_PAC), y) +asm-arch := armv8.3-a endif endif
@@ -91,7 +91,12 @@ KBUILD_CFLAGS += $(branch-prot-flags-y) ifeq ($(CONFIG_AS_HAS_ARMV8_4), y) # make sure to pass the newest target architecture to -march. -KBUILD_CFLAGS += -Wa,-march=armv8.4-a +asm-arch := armv8.4-a +endif + +ifdef asm-arch +KBUILD_CFLAGS += -Wa,-march=$(asm-arch) \ + -DARM64_ASM_ARCH='"$(asm-arch)"' endif ifeq ($(CONFIG_SHADOW_CALL_STACK), y)
arch/arm64/include/asm/compiler.h +6 -0
@@ -2,6 +2,12 @@#ifndef __ASM_COMPILER_H#define __ASM_COMPILER_H +#ifdef ARM64_ASM_ARCH +#define ARM64_ASM_PREAMBLE ".arch " ARM64_ASM_ARCH "\n" +#else +#define ARM64_ASM_PREAMBLE +#endif +/* * The EL0/EL1 pointer bits used by a pointer authentication code. * This is dependent on TBI0/TBI1 being enabled, or bits 63:56 would also apply.
arch/arm64/include/asm/tlbflush.h +4 -2
@@ -28,14 +28,16 @@* not. The macros handles invoking the asm with or without the * register argument as appropriate. */ -#define __TLBI_0 (op, arg) asm ("tlbi " #op "\n" \ +#define __TLBI_0 (op, arg) asm (ARM64_ASM_PREAMBLE \ + "tlbi " #op "\n" \ ALTERNATIVE("nop\n nop", \ "dsb ish\n tlbi " #op, \ ARM64_WORKAROUND_REPEAT_TLBI, \ CONFIG_ARM64_WORKAROUND_REPEAT_TLBI) \ : : ) -#define __TLBI_1 (op, arg) asm ("tlbi " #op ", %0\n" \ +#define __TLBI_1 (op, arg) asm (ARM64_ASM_PREAMBLE \ + "tlbi " #op ", %0\n" \ ALTERNATIVE("nop\n nop", \ "dsb ish\n tlbi " #op ", %0", \ ARM64_WORKAROUND_REPEAT_TLBI, \
Sami
PATCH v2 1/1 arm64: use a common .arch preamble for inline assembly
In reply to Sami TolvanenCommit 7c78f67e9bd9 ("arm64: enable tlbi range instructions") breaks LLVM's integrated assembler, because -Wa,-march is only passed to external assemblers and therefore, the new instructions are not enabled when IAS is used.
This change adds a common architecture version preamble, which can be used in inline assembly blocks that contain instructions that require a newer architecture version, and uses it to fix __TLBI_0 and __TLBI_1 with ARM64_TLB_RANGE.
---
Changes in v2:
- Switched to a standard preamble for the architecture version.
--- arch/arm64/Makefile | 11 ++++++++--- arch/arm64/include/asm/compiler.h | 6 ++++++ arch/arm64/include/asm/tlbflush.h | 6 ++++-- 3 files changed, 18 insertions(+), 5 deletions(-)
arch/arm64/Makefile +8 -3
@@ -82,8 +82,8 @@ endif # compiler to generate them and consequently to break the single image contract # we pass it only to the assembler. This option is utilized only in case of non # integrated assemblers. -ifneq ($(CONFIG_AS_HAS_ARMV8_4), y) -branch-prot-flags-$(CONFIG_AS_HAS_PAC) += -Wa,-march=armv8.3-a +ifeq ($(CONFIG_AS_HAS_PAC), y) +asm-arch := armv8.3-a endif endif
@@ -91,7 +91,12 @@ KBUILD_CFLAGS += $(branch-prot-flags-y) ifeq ($(CONFIG_AS_HAS_ARMV8_4), y) # make sure to pass the newest target architecture to -march. -KBUILD_CFLAGS += -Wa,-march=armv8.4-a +asm-arch := armv8.4-a +endif + +ifdef asm-arch +KBUILD_CFLAGS += -Wa,-march=$(asm-arch) \ + -DARM64_ASM_ARCH='"$(asm-arch)"' endif ifeq ($(CONFIG_SHADOW_CALL_STACK), y)
arch/arm64/include/asm/compiler.h +6 -0
@@ -2,6 +2,12 @@#ifndef __ASM_COMPILER_H#define __ASM_COMPILER_H +#ifdef ARM64_ASM_ARCH +#define ARM64_ASM_PREAMBLE ".arch " ARM64_ASM_ARCH "\n" +#else +#define ARM64_ASM_PREAMBLE +#endif +/* * The EL0/EL1 pointer bits used by a pointer authentication code. * This is dependent on TBI0/TBI1 being enabled, or bits 63:56 would also apply.
arch/arm64/include/asm/tlbflush.h +4 -2
@@ -28,14 +28,16 @@* not. The macros handles invoking the asm with or without the * register argument as appropriate. */ -#define __TLBI_0 (op, arg) asm ("tlbi " #op "\n" \ +#define __TLBI_0 (op, arg) asm (ARM64_ASM_PREAMBLE \ + "tlbi " #op "\n" \ ALTERNATIVE("nop\n nop", \ "dsb ish\n tlbi " #op, \ ARM64_WORKAROUND_REPEAT_TLBI, \ CONFIG_ARM64_WORKAROUND_REPEAT_TLBI) \ : : ) -#define __TLBI_1 (op, arg) asm ("tlbi " #op ", %0\n" \ +#define __TLBI_1 (op, arg) asm (ARM64_ASM_PREAMBLE \ + "tlbi " #op ", %0\n" \ ALTERNATIVE("nop\n nop", \ "dsb ish\n tlbi " #op ", %0", \ ARM64_WORKAROUND_REPEAT_TLBI, \
base-commit: 15bc20c6af4ceee97a1f90b43c0e386643c071b4
Signature · 1 line
2.28.0.297.g1956fa8f8d-goog
Re: [PATCH v2] arm64: use a common .arch preamble for inline assembly
Quoted 5 lines · Sami Tolvanen
Commit
7c78f67e9bd9("arm64: enable tlbi range instructions") breaks LLVM's integrated assembler, because -Wa,-march is only passed to external assemblers and therefore, the new instructions are not enabled when IAS is used.
Quoted 8 lines
This change adds a common architecture version preamble, which can be used in inline assembly blocks that contain instructions that require a newer architecture version, and uses it to fix
__TLBI_0and__TLBI_1withARM64_TLB_RANGE.Fixes 7c78f67e9bd9 ("arm64: enable tlbi range instructions")Signed-off-by Sami Tolvanen <[email protected]>
I have verified that this fixes the build with LLVM_IAS=1. Additionally, I have booted a kernel with this patch on my Raspberry Pi and saw no adverse affects through a compilation workload.
Quoted 84 lines
---
Changes in v2:
- Switched to a standard preamble for the architecture version.--- arch/arm64/Makefile | 11 ++++++++--- arch/arm64/include/asm/compiler.h | 6 ++++++ arch/arm64/include/asm/tlbflush.h | 6 ++++-- 3 files changed, 18 insertions(+), 5 deletions(-)arch/arm64/Makefile +8
-3@@ -82,8 +82,8 @@ endif # compiler to generate them and consequently to break the single image contract # we pass it only to the assembler. This option is utilized only in case of non # integrated assemblers. -ifneq ($(CONFIG_AS_HAS_ARMV8_4), y) -branch-prot-flags-$(CONFIG_AS_HAS_PAC) += -Wa,-march=armv8.3-a +ifeq ($(CONFIG_AS_HAS_PAC), y) +asm-arch := armv8.3-a endif endif@@ -91,7 +91,12 @@ KBUILD_CFLAGS += $(branch-prot-flags-y) ifeq ($(CONFIG_AS_HAS_ARMV8_4), y) # make sure to pass the newest target architecture to -march. -KBUILD_CFLAGS += -Wa,-march=armv8.4-a +asm-arch := armv8.4-a +endif + +ifdef asm-arch +KBUILD_CFLAGS += -Wa,-march=$(asm-arch) \ + -DARM64_ASM_ARCH='"$(asm-arch)"' endif ifeq ($(CONFIG_SHADOW_CALL_STACK), y)arch/arm64/include/asm/compiler.h +6
-0@@ -2,6 +2,12 @@#ifndef __ASM_COMPILER_H#define __ASM_COMPILER_H +#ifdef ARM64_ASM_ARCH +#define ARM64_ASM_PREAMBLE ".arch " ARM64_ASM_ARCH "\n" +#else +#define ARM64_ASM_PREAMBLE +#endif +/* * The EL0/EL1 pointer bits used by a pointer authentication code. * This is dependent on TBI0/TBI1 being enabled, or bits 63:56 would also apply. arch/arm64/include/asm/tlbflush.h +4
-2@@ -28,14 +28,16 @@* not. The macros handles invoking the asm with or without the * register argument as appropriate. */ -#define __TLBI_0 (op, arg) asm ("tlbi " #op "\n" \ +#define __TLBI_0 (op, arg) asm (ARM64_ASM_PREAMBLE \ + "tlbi " #op "\n" \ ALTERNATIVE("nop\n nop", \ "dsb ish\n tlbi " #op, \ ARM64_WORKAROUND_REPEAT_TLBI, \ CONFIG_ARM64_WORKAROUND_REPEAT_TLBI) \ : : ) -#define __TLBI_1 (op, arg) asm ("tlbi " #op ", %0\n" \ +#define __TLBI_1 (op, arg) asm (ARM64_ASM_PREAMBLE \ + "tlbi " #op ", %0\n" \ ALTERNATIVE("nop\n nop", \ "dsb ish\n tlbi " #op ", %0", \ ARM64_WORKAROUND_REPEAT_TLBI, \base-commit:
15bc20c6af4ceee97a1f90b43c0e386643c071b4Signature · 1 line
2.28.0.297.g1956fa8f8d-goog
Re: [PATCH v2] arm64: use a common .arch preamble for inline assembly
In reply to Sami TolvanenQuoted 9 lines · Sami Tolvanen
Commit
7c78f67e9bd9("arm64: enable tlbi range instructions") breaks LLVM's integrated assembler, because -Wa,-march is only passed to external assemblers and therefore, the new instructions are not enabled when IAS is used.This change adds a common architecture version preamble, which can be used in inline assembly blocks that contain instructions that require a newer architecture version, and uses it to fix
__TLBI_0and__TLBI_1withARM64_TLB_RANGE.
Applied to arm64 (for-next/fixes), thanks!
[1/1] arm64: use a common .arch preamble for inline assembly
https://git.kernel.org/arm64/c/1764c3edc668
Signature · 1 line
Catalin