Skip to contentSkip to conversation

libbf: fix uninitialized pointer at btf__parse_raw()

PATCH Applied Daniel T. Lee 3 participants 3 messages Aug 5, 2020 – Aug 6, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libbf: fix uninitialized pointer at btf__parse_raw()

Recently, from commit 94a1fedd63ed ("libbpf: Add btf__parse_raw() and generic btf__parse() APIs"), new API has been added to libbpf that allows to parse BTF from raw data file (btf__parse_raw()).

The commit derives build failure of samples/bpf due to improper access of uninitialized pointer at btf_parse_raw().

btf.c: In function btf__parse_raw:
btf.c:625:28: error: btf may be used uninitialized in this function
625 | return err ? ERR_PTR(err) : btf;
| ~~~~~~~~~~~~~~~~~~~^~~~~

This commit fixes the build failure of samples/bpf by adding code of initializing btf pointer as NULL.

Fixes 94a1fedd63ed ("libbpf: Add btf__parse_raw() and generic btf__parse() APIs")
---
 tools/lib/bpf/btf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/lib/bpf/btf.c +1 -1
index 856b09a04563..4843e44916f7 100644
@@ -564,8 +564,8 @@ struct btf *btf__parse_elf(const char *path, struct btf_ext **btf_ext)
 
 struct btf *btf__parse_raw(const char *path)
 {
+	struct btf *btf = NULL;
 	void *data = NULL;
-	struct btf *btf;
 	FILE *f = NULL;
 	__u16 magic;
 	int err = 0;
Signature · 1 line
2.25.1
Acked-by on v1 1/1
#1 lore raw
Quoted 12 lines · Daniel T. Lee

Recently, from commit 94a1fedd63ed ("libbpf: Add btf__parse_raw() and generic btf__parse() APIs"), new API has been added to libbpf that allows to parse BTF from raw data file (btf__parse_raw()).

The commit derives build failure of samples/bpf due to improper access of uninitialized pointer at btf_parse_raw().

btf.c: In function btf__parse_raw:
btf.c:625:28: error: btf may be used uninitialized in this function
625 | return err ? ERR_PTR(err) : btf;
| ~~~~~~~~~~~~~~~~~~~^~~~~

Quoted 6 lines

This commit fixes the build failure of samples/bpf by adding code of initializing btf pointer as NULL.

Fixes 94a1fedd63ed ("libbpf: Add btf__parse_raw() and generic btf__parse() APIs")

---

Unless errno is zero this should be ok in practice, but I guess compiler wont know that.

#2 lore raw
Quoted 17 lines · John Fastabend
Quoted 15 lines · Daniel T. Lee

Recently, from commit 94a1fedd63ed ("libbpf: Add btf__parse_raw() and generic btf__parse() APIs"), new API has been added to libbpf that allows to parse BTF from raw data file (btf__parse_raw()).

The commit derives build failure of samples/bpf due to improper access of uninitialized pointer at btf_parse_raw().

btf.c: In function btf__parse_raw:
btf.c:625:28: error: btf may be used uninitialized in this function
625 | return err ? ERR_PTR(err) : btf;
| ~~~~~~~~~~~~~~~~~~~^~~~~

This commit fixes the build failure of samples/bpf by adding code of initializing btf pointer as NULL.

Quoted 8 lines
Quoted 3 lines
Fixes 94a1fedd63ed ("libbpf: Add btf__parse_raw() and generic btf__parse() APIs")

---

Unless errno is zero this should be ok in practice, but I guess compiler wont know that.

Applied. Thanks