Skip to contentSkip to conversation

configs: socfpga: add CONFIG_BOOTCOMMAND for cyclone5

PATCH New Ooi 2 participants 3 messages Aug 6, 2020 – Aug 13, 2020

lore
Share & tools
lore

Ooi

#0 lore raw

PATCH 1/1 configs: socfpga: add CONFIG_BOOTCOMMAND for cyclone5

From: Joyce Ooi <[email protected]>

Add CONFIG_BOOTCOMMAND in cyclone5 defconfig to run fatscript and enable FPGA bridge

---
 configs/socfpga_cyclone5_defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
configs/socfpga_cyclone5_defconfig +2 -1
index 1633ca1deb5..132b7b7fa81 100644
@@ -8,7 +8,8 @@ CONFIG_TARGET_SOCFPGA_CYCLONE5_SOCDK=y
 CONFIG_SPL_TEXT_BASE=0xFFFF0000
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_FIT=y
-# CONFIG_USE_BOOTCOMMAND is not set
+CONFIG_USE_BOOTCOMMAND=y
+CONFIG_BOOTCOMMAND="run fatscript; bridge enable; run distro_bootcmd"
 CONFIG_SYS_CONSOLE_IS_IN_ENV=y
 CONFIG_SYS_CONSOLE_OVERWRITE_ROUTINE=y
 CONFIG_SYS_CONSOLE_ENV_OVERWRITE=y
Signature · 1 line
2.13.0
#1 lore raw

PATCH 1/1 configs: socfpga: add CONFIG_BOOTCOMMAND for cyclone5

Quoted 15 lines · Joyce

From: Joyce Ooi <[email protected]>

Add CONFIG_BOOTCOMMAND in cyclone5 defconfig to run fatscript and enable FPGA bridge

---
 configs/socfpga_cyclone5_defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
configs/socfpga_cyclone5_defconfig +0 -0
index 1633ca1deb5..132b7b7fa81 100644

configs/socfpga_cyclone5_defconfig CONFIG_TARGET_SOCFPGA_CYCLONE5_SOCDK=y · line 12

Quoted 6 lines
configs/socfpga_cyclone5_defconfig +2 -1
@@ -8,7 +8,8 @@ CONFIG_TARGET_SOCFPGA_CYCLONE5_SOCDK=y
 CONFIG_SPL_TEXT_BASE=0xFFFF0000
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_FIT=y
-# CONFIG_USE_BOOTCOMMAND is not set
+CONFIG_USE_BOOTCOMMAND=y
+CONFIG_BOOTCOMMAND="run fatscript; bridge enable; run distro_bootcmd"

What is 'fatscript' ? Also, this breaks on systems where the FPGA isn't loaded, as it enables bridges to nowhere.

#2 lore raw

PATCH 1/1 configs: socfpga: add CONFIG_BOOTCOMMAND for cyclone5

Quoted 38 lines

-----Original Message-----
From: Marek Vasut <[email protected]>
Sent: Thursday, August 6, 2020 5:56 PM
To: Ooi, Joyce <[email protected]>; Simon Goldschmidt <[email protected]>; Tan, Ley Foon <[email protected]>; See, Chin Liang <[email protected]>; Nguyen, Dinh <[email protected]>
Cc: u-boot at lists.denx.de; Chang, Rebecca Swee Fun <[email protected]>; Lim, Elly Siew Chin <[email protected]>
Subject: Re: [PATCH] configs: socfpga: add CONFIG_BOOTCOMMAND for cyclone5

Quoted 16 lines · Joyce

From: Joyce Ooi <[email protected]>

Add CONFIG_BOOTCOMMAND in cyclone5 defconfig to run fatscript and enable FPGA bridge

---
 configs/socfpga_cyclone5_defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
configs/socfpga_cyclone5_defconfig +0 -0
index 1633ca1deb5..132b7b7fa81 100644

configs/socfpga_cyclone5_defconfig CONFIG_TARGET_SOCFPGA_CYCLONE5_SOCDK=y · line 12

Quoted 6 lines
configs/socfpga_cyclone5_defconfig +2 -1
@@ -8,7 +8,8 @@ CONFIG_TARGET_SOCFPGA_CYCLONE5_SOCDK=y
 CONFIG_SPL_TEXT_BASE=0xFFFF0000
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_FIT=y
-# CONFIG_USE_BOOTCOMMAND is not set
+CONFIG_USE_BOOTCOMMAND=y
+CONFIG_BOOTCOMMAND="run fatscript; bridge enable; run

distro_bootcmd"

Quoted 2 lines

What is 'fatscript' ? Also, this breaks on systems where the FPGA isn't loaded, as it enables bridges to nowhere.

I missed out on adding the fatscript. I'll add in my next version.

For the bridge enabling, I'll add a checking to check if FPGA is in user mode before enabling the bridge.