Skip to contentSkip to conversation

package/smstools3: fix build with gcc 10.x

PATCH New Michael Fischer 2 participants 2 messages Aug 6, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/smstools3: fix build with gcc 10.x

---
 package/smstools3/smstools3.mk | 5 +++++
 1 file changed, 5 insertions(+)
package/smstools3/smstools3.mk +5 -0
index 87d189baa8..b15e189c60 100644
@@ -10,6 +10,11 @@ SMSTOOLS3_LICENSE = GPL-2.0+
 SMSTOOLS3_LICENSE_FILES = doc/license.html LICENSE
 
 SMSTOOLS3_CFLAGS = $(TARGET_CFLAGS)
+
+ifeq ($(BR2_GCC_VERSION_10_X),y)
+	SMSTOOLS3_CFLAGS += -Wl,--allow-multiple-definition
+endif
+
 SMSTOOLS3_CFLAGS += -D NUMBER_OF_MODEMS=$(BR2_PACKAGE_SMSTOOLS3_NB_MODEMS)
 SMSTOOLS3_CFLAGS += -D NOSTATS
 
Signature · 1 line
2.28.0
#1 lore raw

PATCH 1/1 package/smstools3: fix build with gcc 10.x

Quoted 10 lines · On Thu, 6 Aug 2020 11:58:31 +0200 Michael Fischer <[email protected]> wrote:
---
 package/smstools3/smstools3.mk | 5 +++++
 1 file changed, 5 insertions(+)
package/smstools3/smstools3.mk +0 -0
index 87d189baa8..b15e189c60 100644

package/smstools3/smstools3.mk SMSTOOLS3_LICENSE = GPL-2.0+ · line 16

Quoted 7 lines
package/smstools3/smstools3.mk +4 -0
@@ -10,6 +10,11 @@ SMSTOOLS3_LICENSE = GPL-2.0+
 SMSTOOLS3_LICENSE_FILES = doc/license.html LICENSE
 
 SMSTOOLS3_CFLAGS = $(TARGET_CFLAGS)
+
+ifeq ($(BR2_GCC_VERSION_10_X),y)
+	SMSTOOLS3_CFLAGS += -Wl,--allow-multiple-definition
+endif

We generally try to fix the gcc 10.x issues, when possible. In this case, Debian has a patch:

https://salsa.debian.org/debian-mobcom-team/smstools/-/blob/57a358a9eebbe2ca5639cc526f7027944ed95ea1/debian/patches/gcc10.patch

Could you use that instead ?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com