hwrng: optee: fix wait use case
Subsystems (3)
PATCH v3 2/2 hwrng: optee: fix wait use case
The current code waits for data to be available before attempting a second read. However the second read would not be executed as the while loop will exit.
This fix does not wait if all data has been read (skips the call to msleep(0)) and reads a second time if partial data was retrieved on the first read.
Worth noticing that since msleep(0) schedules a one jiffy timeout is better to skip such a call.
Signed-off-by Jorge Ramirez-Ortiz <[email protected]>
Reviewed-by Sumit Garg <[email protected]>
--- drivers/char/hw_random/optee-rng.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/char/hw_random/optee-rng.c +2 -2
@@ -122,14 +122,14 @@ static int optee_rng_read(struct hwrng *rng, void *buf, size_t max, bool wait)if (max >MAX_ENTROPY_REQ_SZ ) max =MAX_ENTROPY_REQ_SZ ; -while (read ==0 ) { +while (read < max) { rng_size =get_optee_rng_data (pvt_data, data, (max - read)); data += rng_size; read += rng_size;if (wait && pvt_data->data_rate) { -if (timeout-- ==0 ) +if ((timeout-- ==0 ) || (read == max))return read;msleep ((1000 * (max - read)) / pvt_data->data_rate); }else {
Signature · 1 line
2.17.1