Skip to contentSkip to conversation

bpf: add missing return to resolve_btfids

PATCH Applied Stanislav Fomichev 2 participants 3 messages Aug 6, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bpf: add missing return to resolve_btfids

int sets_patch(struct object *obj) doesn't have a 'return 0' at the end.

---
 tools/bpf/resolve_btfids/main.c | 1 +
 1 file changed, 1 insertion(+)
tools/bpf/resolve_btfids/main.c +1 -0
index 52d883325a23..4d9ecb975862 100644
@@ -566,6 +566,7 @@ static int sets_patch(struct object *obj)
 
 		next = rb_next(next);
 	}
+	return 0;
 }
 
 static int symbols_patch(struct object *obj)
Signature · 1 line
2.28.0.236.gb10cc79966-goog
#1 lore raw
Quoted 20 lines · Stanislav Fomichev

int sets_patch(struct object *obj) doesn't have a 'return 0' at the end.

---
  tools/bpf/resolve_btfids/main.c | 1 +
  1 file changed, 1 insertion(+)
tools/bpf/resolve_btfids/main.c +1 -1
index 52d883325a23..4d9ecb975862 100644
@@ -566,6 +566,7 @@ static int sets_patch(struct object *obj)
 
  		next = rb_next(next);
  	}
+	return 0;
  }
 
  static int symbols_patch(struct object *obj)
--
Quoted 1 line

2.28.0.236.gb10cc79966-goog

Sorry, forgot:

Fixes fbbb68de80a4 ("bpf: Add resolve_btfids tool to resolve BTF IDs in ELF object")
#2 lore raw
Quoted 21 lines · On Thu, Aug 6, 2020 at 11:22 AM <[email protected]> wrote:
Quoted 18 lines · Stanislav Fomichev

int sets_patch(struct object *obj) doesn't have a 'return 0' at the end.

---
  tools/bpf/resolve_btfids/main.c | 1 +
  1 file changed, 1 insertion(+)
tools/bpf/resolve_btfids/main.c +1 -0
index 52d883325a23..4d9ecb975862 100644
@@ -566,6 +566,7 @@ static int sets_patch(struct object *obj)
 
              next = rb_next(next);
      }
+     return 0;
  }
Quoted 8 lines
Quoted 3 lines
tools/bpf/resolve_btfids/main.c +0 -1
  static int symbols_patch(struct object *obj)
--

2.28.0.236.gb10cc79966-goog

Sorry, forgot:

Fixes fbbb68de80a4 ("bpf: Add resolve_btfids tool to resolve BTF IDs in

ELF object")

Applied. Thanks