virtiofsd: Disable remote posix locks by default
PATCH 1/1 virtiofsd: Disable remote posix locks by default
Right now we enable remote posix locks by default. That means when guest does a posix lock it sends request to server (virtiofsd). But currently we only support non-blocking posix lock and return -EOPNOTSUPP for blocking version.
This means that existing applications which are doing blocking posix locks get -EOPNOTSUPP and fail. To avoid this, people have been running virtiosd with option "-o no_posix_lock". For new users it is still a surprise and trial and error takes them to this option.
Given posix lock implementation is not complete in virtiofsd, disable it by default. This means that posix locks will work with-in applications in a guest but not across guests. Anyway we don't support sharing filesystem among different guests yet in virtiofs so this should not lead to any kind of surprise or regression and will make life little easier for virtiofs users.
--- tools/virtiofsd/passthrough_ll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/virtiofsd/passthrough_ll.c +1 -1
@@ -3208,7 +3208,7 @@ int main(int argc, char *argv[])struct lo_data lo = { .debug =0 , .writeback =0 , - .posix_lock =1 , + .posix_lock =0 , .proc_self_fd =-1 , };struct lo_map_elem *root_elem;
Signature · 1 line
2.25.4
Quoted 17 lines · Vivek Goyal
Right now we enable remote posix locks by default. That means when guest does a posix lock it sends request to server (virtiofsd). But currently we only support non-blocking posix lock and return
-EOPNOTSUPPfor blocking version.This means that existing applications which are doing blocking posix locks get
-EOPNOTSUPPand fail. To avoid this, people have been running virtiosd with option "-ono_posix_lock". For new users it is still a surprise and trial and error takes them to this option.Given posix lock implementation is not complete in virtiofsd, disable it by default. This means that posix locks will work with-in applications in a guest but not across guests. Anyway we don't support sharing filesystem among different guests yet in virtiofs so this should not lead to any kind of surprise or regression and will make life little easier for virtiofs users.
Quoted 6 lines
Reported-by Aa Aa <[email protected]>Suggested-by Miklos Szeredi <[email protected]>Signed-off-by Vivek Goyal <[email protected]>--- tools/virtiofsd/passthrough_ll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 11 lines
Right now we enable remote posix locks by default. That means when guest does a posix lock it sends request to server (virtiofsd). But currently we only support non-blocking posix lock and return
-EOPNOTSUPPfor blocking version.This means that existing applications which are doing blocking posix locks get
-EOPNOTSUPPand fail. To avoid this, people have been running virtiosd with option "-ono_posix_lock". For new users it is still a surprise and trial and error takes them to this option.Given posix lock implementation is not complete in virtiofsd, disable it by default. This means that posix locks will work with-in applications in a guest but not across guests. Anyway we don't support sharing filesystem among different guests yet in virtiofs so this should not lead to any kind of surprise or regression and will make life little easier for virtiofs users.
Quoted 6 lines
Reported-by Aa Aa <[email protected]>Suggested-by Miklos Szeredi <[email protected]>Signed-off-by Vivek Goyal <[email protected]>--- tools/virtiofsd/passthrough_ll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
We should update docs/tools/virtiofsd.rst as well. Given that:
Quoted 18 lines · * [email protected] ([email protected]) wrote:
Quoted 11 lines
Right now we enable remote posix locks by default. That means when guest does a posix lock it sends request to server (virtiofsd). But currently we only support non-blocking posix lock and return
-EOPNOTSUPPfor blocking version.This means that existing applications which are doing blocking posix locks get
-EOPNOTSUPPand fail. To avoid this, people have been running virtiosd with option "-ono_posix_lock". For new users it is still a surprise and trial and error takes them to this option.Given posix lock implementation is not complete in virtiofsd, disable it by default. This means that posix locks will work with-in applications in a guest but not across guests. Anyway we don't support sharing filesystem among different guests yet in virtiofs so this should not lead to any kind of surprise or regression and will make life little easier for virtiofs users.
Quoted 6 lines
Reported-by Aa Aa <[email protected]>Suggested-by Miklos Szeredi <[email protected]>Signed-off-by Vivek Goyal <[email protected]>--- tools/virtiofsd/passthrough_ll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 2 lines
We should update
docs/tools/virtiofsd.rstas well. Given that:Reviewed-by Misono Tomohiro <[email protected]>
Fixed up the doc.
Dave
Quoted 5 lines
_______________________________________________
Virtio-fs mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virtio-fs
Signature · 1 line
Dr. David Alan Gilbert / [email protected] / Manchester, UK
Quoted 19 lines · Dr. David Alan Gilbert
Quoted 18 lines · * [email protected] ([email protected]) wrote:
Quoted 17 lines
Right now we enable remote posix locks by default. That means when guest does a posix lock it sends request to server (virtiofsd). But currently we only support non-blocking posix lock and return
-EOPNOTSUPPfor blocking version.This means that existing applications which are doing blocking posix locks get
-EOPNOTSUPPand fail. To avoid this, people have been running virtiosd with option "-ono_posix_lock". For new users it is still a surprise and trial and error takes them to this option.Given posix lock implementation is not complete in virtiofsd, disable it by default. This means that posix locks will work with-in applications in a guest but not across guests. Anyway we don't support sharing filesystem among different guests yet in virtiofs so this should not lead to any kind of surprise or regression and will make life little easier for virtiofs users.
Reported-by Aa Aa <[email protected]>Suggested-by Miklos Szeredi <[email protected]>Signed-off-by Vivek Goyal <[email protected]>--- tools/virtiofsd/passthrough_ll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 4 lines
Quoted 2 lines
We should update
docs/tools/virtiofsd.rstas well. Given that:Reviewed-by Misono Tomohiro <[email protected]>Fixed up the doc.
Aha.. Looks like we were looking at this at the same time.
Thanks for taking care of this Dave.
Vivek
Quoted 18 lines · On Thu, Aug 06, 2020 at 08:20:39AM +0000, [email protected] wrote:
Quoted 11 lines
Right now we enable remote posix locks by default. That means when guest does a posix lock it sends request to server (virtiofsd). But currently we only support non-blocking posix lock and return
-EOPNOTSUPPfor blocking version.This means that existing applications which are doing blocking posix locks get
-EOPNOTSUPPand fail. To avoid this, people have been running virtiosd with option "-ono_posix_lock". For new users it is still a surprise and trial and error takes them to this option.Given posix lock implementation is not complete in virtiofsd, disable it by default. This means that posix locks will work with-in applications in a guest but not across guests. Anyway we don't support sharing filesystem among different guests yet in virtiofs so this should not lead to any kind of surprise or regression and will make life little easier for virtiofs users.
Quoted 6 lines
Reported-by Aa Aa <[email protected]>Suggested-by Miklos Szeredi <[email protected]>Signed-off-by Vivek Goyal <[email protected]>--- tools/virtiofsd/passthrough_ll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 2 lines
We should update
docs/tools/virtiofsd.rstas well. Given that:Reviewed-by Misono Tomohiro <[email protected]>
Good point Misono. I will update doc to reflect that now default is "no_posix_lock". Will send V2 and retain all the Reviewed-by tags.
Thanks
Vivek
Quoted 17 lines · * Vivek Goyal ([email protected]) wrote:
Right now we enable remote posix locks by default. That means when guest does a posix lock it sends request to server (virtiofsd). But currently we only support non-blocking posix lock and return
-EOPNOTSUPPfor blocking version.This means that existing applications which are doing blocking posix locks get
-EOPNOTSUPPand fail. To avoid this, people have been running virtiosd with option "-ono_posix_lock". For new users it is still a surprise and trial and error takes them to this option.Given posix lock implementation is not complete in virtiofsd, disable it by default. This means that posix locks will work with-in applications in a guest but not across guests. Anyway we don't support sharing filesystem among different guests yet in virtiofs so this should not lead to any kind of surprise or regression and will make life little easier for virtiofs users.
Quoted 3 lines
Reported-by Aa Aa <[email protected]>Suggested-by Miklos Szeredi <[email protected]>Signed-off-by Vivek Goyal <[email protected]>
Thanks, queued into my local dev world; I'll push it out after some others and get it into the qemu world when it reopens.
Dave
Quoted 20 lines
--- tools/virtiofsd/passthrough_ll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/virtiofsd/passthrough_ll.c +1
-1@@ -3208,7 +3208,7 @@ int main(int argc, char *argv[])struct lo_data lo = { .debug =0 , .writeback =0 , - .posix_lock =1 , + .posix_lock =0 , .proc_self_fd =-1 , };struct lo_map_elem *root_elem;Signature · 1 line
2.25.4
Signature · 1 line
Dr. David Alan Gilbert / [email protected] / Manchester, UK