Skip to contentSkip to conversation

bpf: remove inline from bpf_do_trace_printk

PATCH Applied Stanislav Fomichev 2 participants 2 messages Aug 6, 2020

Subsystems (6)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bpf: remove inline from bpf_do_trace_printk

I get the following error during compilation on my side:
kernel/trace/bpf_trace.c: In function 'bpf_do_trace_printk':
kernel/trace/bpf_trace.c:386:34: error: function 'bpf_do_trace_printk' can never be inlined because it uses variable argument lists
static inline __printf(1, 0) int bpf_do_trace_printk(const char *fmt, ...)

                                  ^
Fixes ac5a72ea5c89 ("bpf: Use dedicated bpf_trace_printk event instead of trace_printk()")
---
 kernel/trace/bpf_trace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/trace/bpf_trace.c +1 -1
index cb91ef902cc4..a8d4f253ed77 100644
@@ -383,7 +383,7 @@ static DEFINE_RAW_SPINLOCK(trace_printk_lock);
 
 #define BPF_TRACE_PRINTK_SIZE   1024
 
-static inline __printf(1, 0) int bpf_do_trace_printk(const char *fmt, ...)
+static __printf(1, 0) int bpf_do_trace_printk(const char *fmt, ...)
 {
 	static char buf[BPF_TRACE_PRINTK_SIZE];
 	unsigned long flags;
Signature · 1 line
2.28.0.236.gb10cc79966-goog
#1 lore raw
Quoted 9 lines · Stanislav Fomichev

I get the following error during compilation on my side:
kernel/trace/bpf_trace.c: In function 'bpf_do_trace_printk':
kernel/trace/bpf_trace.c:386:34: error: function 'bpf_do_trace_printk' can never be inlined because it uses variable argument lists
static inline __printf(1, 0) int bpf_do_trace_printk(const char *fmt, ...)

                                  ^
Fixes ac5a72ea5c89 ("bpf: Use dedicated bpf_trace_printk event instead of trace_printk()")

Applied. Thanks