input: sentelic: fix error return when fsp_reg_write fails
Subsystems (3)
PATCH 1/1 input: sentelic: fix error return when fsp_reg_write fails
From: Colin Ian King <[email protected]>
Currently when the call to fsp_reg_write fails -EIO is not being returned because the count is being returned instead of the return value in retval. Fix this by returning the value in retval instead of count.
Addresses-Coverity: ("Unused value")
Fixes fc69f4a6af49 ("Input: add new driver for Sentelic Finger Sensing Pad")
Signed-off-by Colin Ian King <[email protected]>
--- drivers/input/mouse/sentelic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/mouse/sentelic.c +1 -1
@@ -441,7 +441,7 @@ static ssize_t fsp_attr_set_setreg(struct psmouse *psmouse, void *data,fsp_reg_write_enable (psmouse, false); -return count; +return retval; }PSMOUSE_DEFINE_WO_ATTR (setreg,S_IWUSR ,NULL , fsp_attr_set_setreg);
Signature · 1 line
2.25.1
Quoted 9 lines · Colin King
From: Colin Ian King <[email protected]>
Currently when the call to
fsp_reg_writefails-EIOis not being returned because the count is being returned instead of the return value in retval. Fix this by returning the value in retval instead of count.Addresses-Coverity: ("Unused value")
Fixes fc69f4a6af49 ("Input: add new driver for Sentelic Finger Sensing Pad")Signed-off-by Colin Ian King <[email protected]>
Applied, thank you.
Signature · 1 line
Dmitry