Skip to contentSkip to conversation

input: sentelic: fix error return when fsp_reg_write fails

PATCH Applied Colin King 2 participants 2 messages Jun 3, 2020 – Aug 6, 2020

Subsystems (3)
lore
Share & tools
lore

Colin King

author
#0 lore raw

PATCH 1/1 input: sentelic: fix error return when fsp_reg_write fails

From: Colin Ian King <[email protected]>

Currently when the call to fsp_reg_write fails -EIO is not being returned because the count is being returned instead of the return value in retval. Fix this by returning the value in retval instead of count.

Addresses-Coverity: ("Unused value")

Fixes fc69f4a6af49 ("Input: add new driver for Sentelic Finger Sensing Pad")
---
 drivers/input/mouse/sentelic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/mouse/sentelic.c +1 -1
index e99d9bf1a267..e78c4c7eda34 100644
@@ -441,7 +441,7 @@ static ssize_t fsp_attr_set_setreg(struct psmouse *psmouse, void *data,
 
 	fsp_reg_write_enable(psmouse, false);
 
-	return count;
+	return retval;
 }
 
 PSMOUSE_DEFINE_WO_ATTR(setreg, S_IWUSR, NULL, fsp_attr_set_setreg);
Signature · 1 line
2.25.1
maintainer Applied
#1 lore raw
Quoted 9 lines · Colin King

From: Colin Ian King <[email protected]>

Currently when the call to fsp_reg_write fails -EIO is not being returned because the count is being returned instead of the return value in retval. Fix this by returning the value in retval instead of count.

Addresses-Coverity: ("Unused value")

Fixes fc69f4a6af49 ("Input: add new driver for Sentelic Finger Sensing Pad")

Applied, thank you.

Signature · 1 line
Dmitry