Skip to contentSkip to conversation

ucarp: don't hardcode the path for ifconfig

PATCH In review Yu, Mingli 2 participants 2 messages Aug 7, 2020 – Aug 9, 2020

lore
Share & tools
lore

Yu, Mingli

author
#0 lore raw

PATCH 1/1 ucarp: don't hardcode the path for ifconfig

From: Mingli Yu <[email protected]>

Don't hardcode the path for the ifconfig command in case the path for ifconfig on the system may be different from the hardcoded.

---
 meta-cgl-common/recipes-cgl/ucarp/ucarp/vip-down.sh | 2 +-
 meta-cgl-common/recipes-cgl/ucarp/ucarp/vip-up.sh   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
meta-cgl-common/recipes-cgl/ucarp/ucarp/vip-down.sh +1 -1
index a431c32..27e0d2b 100644
@@ -4,4 +4,4 @@ exec 2> /dev/null
 #/sbin/ip addr del "$2"/24 dev "$1"
 
 # or alternatively:
-/sbin/ifconfig "$1":254 down
+ifconfig "$1":254 down
meta-cgl-common/recipes-cgl/ucarp/ucarp/vip-up.sh +1 -1
index c1b8a4f..f81d578 100644
@@ -4,4 +4,4 @@ exec 2> /dev/null
 #/sbin/ip addr add "$2"/24 dev "$1"
 
 # or alternatively:
-/sbin/ifconfig "$1":254 "$2" netmask 255.255.255.0 
+ifconfig "$1":254 "$2" netmask 255.255.255.0
Signature · 1 line
2.26.2
#1 lore raw

Merged.

Quoted 33 lines · Mingli

From: Mingli Yu <[email protected]>

Don't hardcode the path for the ifconfig command in case the path for ifconfig on the system may be different from the hardcoded.

---
  meta-cgl-common/recipes-cgl/ucarp/ucarp/vip-down.sh | 2 +-
  meta-cgl-common/recipes-cgl/ucarp/ucarp/vip-up.sh   | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
meta-cgl-common/recipes-cgl/ucarp/ucarp/vip-down.sh +1 -1
index a431c32..27e0d2b 100644
@@ -4,4 +4,4 @@ exec 2> /dev/null
  #/sbin/ip addr del "$2"/24 dev "$1"
 
  # or alternatively:
-/sbin/ifconfig "$1":254 down
+ifconfig "$1":254 down
meta-cgl-common/recipes-cgl/ucarp/ucarp/vip-up.sh +1 -1
index c1b8a4f..f81d578 100644
@@ -4,4 +4,4 @@ exec 2> /dev/null
  #/sbin/ip addr add "$2"/24 dev "$1"
 
  # or alternatively:
-/sbin/ifconfig "$1":254 "$2" netmask 255.255.255.0
+ifconfig "$1":254 "$2" netmask 255.255.255.0
Signature · 2 lines
Jeremy A. Puhlman
[email protected]