drm/qxl: don't take vga ports on rev5+
Subsystems (4)
Gerd Hoffmann
maintainerPATCH v2 1/1 drm/qxl: don't take vga ports on rev5+
qemu 5.0 introduces a new qxl hardware revision 5. Unlike revision 4 (and below) the device doesn't switch back into vga compatibility mode when someone touches the vga ports. So we don't have to reserve the vga ports any more to avoid that happening.
Signed-off-by Gerd Hoffmann <[email protected]>
--- drivers/gpu/drm/qxl/qxl_drv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/qxl/qxl_drv.c +3 -3
@@ -96,7 +96,7 @@ qxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)if (ret) goto disable_pci; -if (is_vga (pdev)) { +if (is_vga (pdev) && pdev->revision <5 ) { ret =vga_get_interruptible (pdev,VGA_RSRC_LEGACY_IO );if (ret) {DRM_ERROR ("can't get legacy vga ioports\n" );
@@ -127,7 +127,7 @@ qxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) unload:qxl_device_fini (qdev); put_vga: -if (is_vga (pdev)) +if (is_vga (pdev) && pdev->revision <5 )vga_put (pdev,VGA_RSRC_LEGACY_IO ); disable_pci:pci_disable_device (pdev);
@@ -155,7 +155,7 @@ qxl_pci_remove(struct pci_dev *pdev)drm_dev_unregister (dev);drm_atomic_helper_shutdown (dev); -if (is_vga (pdev)) +if (is_vga (pdev) && pdev->revision <5 )vga_put (pdev,VGA_RSRC_LEGACY_IO ); }
Signature · 6 lines
2.18.4 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 6 lines · Gerd Hoffmann
qemu 5.0 introduces a new qxl hardware revision 5. Unlike revision 4 (and below) the device doesn't switch back into vga compatibility mode when someone touches the vga ports. So we don't have to reserve the vga ports any more to avoid that happening.
Signed-off-by Gerd Hoffmann <[email protected]>
Does what it says on the label.
Reviewed-by Daniel Vetter <[email protected]>
Quoted 38 lines
--- drivers/gpu/drm/qxl/qxl_drv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/qxl/qxl_drv.c +3
-3@@ -96,7 +96,7 @@ qxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)if (ret) goto disable_pci; -if (is_vga (pdev)) { +if (is_vga (pdev) && pdev->revision <5 ) { ret =vga_get_interruptible (pdev,VGA_RSRC_LEGACY_IO );if (ret) {DRM_ERROR ("can't get legacy vga ioports\n" );@@ -127,7 +127,7 @@ qxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) unload:qxl_device_fini (qdev); put_vga: -if (is_vga (pdev)) +if (is_vga (pdev) && pdev->revision <5 )vga_put (pdev,VGA_RSRC_LEGACY_IO ); disable_pci:pci_disable_device (pdev);@@ -155,7 +155,7 @@ qxl_pci_remove(struct pci_dev *pdev)drm_dev_unregister (dev);drm_atomic_helper_shutdown (dev); -if (is_vga (pdev)) +if (is_vga (pdev) && pdev->revision <5 )vga_put (pdev,VGA_RSRC_LEGACY_IO ); }Signature · 1 line
2.18.4
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel