Skip to contentSkip to conversation

test: efi_selftest: Do not force serial# setting

PATCH New Tom Rini 3 participants 6 messages Jul 31, 2020 – Aug 7, 2020

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/1 test: efi_selftest: Do not force serial# setting

As part of the EFI self test we set and check the serial# variable. However, we should not be forcing this setting. In the case where we are allowed to change the variable it will change, and we will pass the test. In the case where we cannot change it, force may or may not be allowed, depending on further environment restrictions. Drop the -f flag here as we do not need it.

Cc Heinrich Schuchardt <[email protected]>
---
 test/py/tests/test_efi_selftest.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
test/py/tests/test_efi_selftest.py +1 -1
index 971c9f6053a3..9b520c2070b2 100644
@@ -36,7 +36,7 @@ def test_efi_selftest_device_tree(u_boot_console):
     output = u_boot_console.run_command('bootefi selftest')
     assert '\'device tree\'' in output
     u_boot_console.run_command(cmd='setenv efi_selftest device tree')
-    u_boot_console.run_command(cmd='setenv -f serial# Testing DT')
+    u_boot_console.run_command(cmd='setenv serial# Testing DT')
     u_boot_console.run_command(cmd='bootefi selftest ${fdtcontroladdr}', wait_for_prompt=False)
     m = u_boot_console.p.expect(['serial-number: Testing DT', 'U-Boot'])
     if m != 0:
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH 1/1 test: efi_selftest: Do not force serial# setting

Quoted 9 lines · Tom Rini

As part of the EFI self test we set and check the serial# variable. However, we should not be forcing this setting. In the case where we are allowed to change the variable it will change, and we will pass the test. In the case where we cannot change it, force may or may not be allowed, depending on further environment restrictions. Drop the -f flag here as we do not need it.

Cc Heinrich Schuchardt <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200731/fd5ac547/attachment.sig>
#2 lore raw

PATCH 1/1 test: efi_selftest: Do not force serial# setting

Quoted 9 lines · Tom Rini
Quoted 7 lines · Tom Rini

As part of the EFI self test we set and check the serial# variable. However, we should not be forcing this setting. In the case where we are allowed to change the variable it will change, and we will pass the test. In the case where we cannot change it, force may or may not be allowed, depending on further environment restrictions. Drop the -f flag here as we do not need it.

Quoted 5 lines
Quoted 2 lines
Cc Heinrich Schuchardt <[email protected]>

Applied to u-boot/master, thanks!

With this patch on the Pine64 LTS:

=> => setenv efi_selftest device tree
=> => setenv serial# Testing DT
## Error: Can't overwrite "serial#"
## Error inserting "serial#" variable, errno=1
=>

This worked without your patch.

This patch does not solve any problem.

Best regards

Heinrich

author
#3 lore raw

PATCH 1/1 test: efi_selftest: Do not force serial# setting

Quoted 25 lines · Heinrich Schuchardt
Quoted 9 lines · Tom Rini
Quoted 7 lines · Tom Rini

As part of the EFI self test we set and check the serial# variable. However, we should not be forcing this setting. In the case where we are allowed to change the variable it will change, and we will pass the test. In the case where we cannot change it, force may or may not be allowed, depending on further environment restrictions. Drop the -f flag here as we do not need it.

Quoted 5 lines
Quoted 2 lines
Cc Heinrich Schuchardt <[email protected]>

Applied to u-boot/master, thanks!

With this patch on the Pine64 LTS:

=> => setenv efi_selftest device tree
=> => setenv serial# Testing DT
## Error: Can't overwrite "serial#"
## Error inserting "serial#" variable, errno=1
=>

Quoted 3 lines

This worked without your patch.

This patch does not solve any problem.

This patch resolved the problems trying to use "env set -f" on platforms where CONFIG_ENV_ACCESS_IGNORE_FORCE is unset and the variable is not protected. With:
commit 0f036bf4b87e6416f5c4d23865a62a62d9073c20

Author: Marek Vasut <[email protected]>
Date:   Tue Jul 7 20:51:33 2020 +0200

env: Warn on force access if ENV_ACCESS_IGNORE_FORCE set

applied those platforms fail efi_selftest. The answer I believe is that on your platform serial# is protected so you do have to force overwriting it in order to change it. This is not the case of all platforms with a serial# variable.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200807/2c1b0219/attachment.sig>
#4 lore raw

PATCH 1/1 test: efi_selftest: Do not force serial# setting

Quoted 38 lines · Tom Rini
Quoted 25 lines · Heinrich Schuchardt
Quoted 9 lines · Tom Rini
Quoted 7 lines · Tom Rini

As part of the EFI self test we set and check the serial# variable. However, we should not be forcing this setting. In the case where we are allowed to change the variable it will change, and we will pass the test. In the case where we cannot change it, force may or may not be allowed, depending on further environment restrictions. Drop the -f flag here as we do not need it.

Quoted 5 lines
Quoted 2 lines
Cc Heinrich Schuchardt <[email protected]>

Applied to u-boot/master, thanks!

With this patch on the Pine64 LTS:

=> => setenv efi_selftest device tree
=> => setenv serial# Testing DT
## Error: Can't overwrite "serial#"
## Error inserting "serial#" variable, errno=1
=>

Quoted 3 lines

This worked without your patch.

This patch does not solve any problem.

This patch resolved the problems trying to use "env set -f" on platforms where CONFIG_ENV_ACCESS_IGNORE_FORCE is unset and the variable is not protected. With:
commit 0f036bf4b87e6416f5c4d23865a62a62d9073c20

Author: Marek Vasut <[email protected]>
Date:   Tue Jul 7 20:51:33 2020 +0200
Quoted 6 lines

env: Warn on force access if ENV_ACCESS_IGNORE_FORCE set

applied those platforms fail efi_selftest. The answer I believe is that on your platform serial# is protected so you do have to force overwriting it in order to change it. This is not the case of all platforms with a serial# variable.

So no problem is solved except Marek's fancy warning.

Best regards

Heinrich

author
#5 lore raw

PATCH 1/1 test: efi_selftest: Do not force serial# setting

Quoted 39 lines · Heinrich Schuchardt
Quoted 38 lines · Tom Rini
Quoted 25 lines · Heinrich Schuchardt
Quoted 9 lines · Tom Rini
Quoted 7 lines · Tom Rini

As part of the EFI self test we set and check the serial# variable. However, we should not be forcing this setting. In the case where we are allowed to change the variable it will change, and we will pass the test. In the case where we cannot change it, force may or may not be allowed, depending on further environment restrictions. Drop the -f flag here as we do not need it.

Quoted 5 lines
Quoted 2 lines
Cc Heinrich Schuchardt <[email protected]>

Applied to u-boot/master, thanks!

With this patch on the Pine64 LTS:

=> => setenv efi_selftest device tree
=> => setenv serial# Testing DT
## Error: Can't overwrite "serial#"
## Error inserting "serial#" variable, errno=1
=>

Quoted 3 lines

This worked without your patch.

This patch does not solve any problem.

This patch resolved the problems trying to use "env set -f" on platforms where CONFIG_ENV_ACCESS_IGNORE_FORCE is unset and the variable is not protected. With:
commit 0f036bf4b87e6416f5c4d23865a62a62d9073c20

Author: Marek Vasut <[email protected]>
Date:   Tue Jul 7 20:51:33 2020 +0200
Quoted 8 lines
Quoted 6 lines

env: Warn on force access if ENV_ACCESS_IGNORE_FORCE set

applied those platforms fail efi_selftest. The answer I believe is that on your platform serial# is protected so you do have to force overwriting it in order to change it. This is not the case of all platforms with a serial# variable.

So no problem is solved except Marek's fancy warning.

It's not a "fancy warning". It's an important bit of user feedback. In fact, the next question I keep coming back to is, how was, or is, this working before? Without Marek's patch, we silently return 0 and don't change the variable. With Marek's patch we tell the user we aren't doing anything and return 0. So are we actually changing serial# when it's supposed to be unchangable?

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200807/16824adb/attachment.sig>